Re: [Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-29 Thread Wayne Stambaugh
Hey John, I'm all for a read only hot key list based on the hot key list editor. It would be more user friendly than the current flat hotkey list. Since both of these bug reports are wishlist items, they should be tagged for 5.1. Cheers, Wayne On 09/28/2018 12:44 PM, John Beard wrote: > Hi

Re: [Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread John Beard
Hi Wayne, I understand - my question is what would be the better resolution for lp:1778374 for 5.1 (not 5.0.1)? I have not done any work on the list dialog yet on any branch, as I don't want to waste time making a read-only widget if that's not the preferred method. My feeling is that it would

Re: [Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread Wayne Stambaugh
Hi John, That was quick! I merged your patch in the 5.0 branch. Thanks, Wayne On 09/28/2018 10:18 AM, John Beard wrote: > HI Wayne, > > Yes, here is a separate patch for the 5.0 series. > > Cheers, > > John > On Fri, Sep 28, 2018 at 3:11 PM Wayne Stambaugh wrote: >> >> Hey John, >> >>

Re: [Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread Wayne Stambaugh
Thanks for the clarification. Wishlist bugs are always tagged for the next release version so there is no need to make any hotkey list dialog changes for 5.0.1. On 09/28/2018 10:42 AM, John Beard wrote: > Hi Wayne, > > I was only planning to make changes to the list dialog (as opposed to > the

Re: [Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread Wayne Stambaugh
Hey John, Given that 5.1 is pretty far along and the delta between the 5.0 and development branches, I would rather you didn't spent a lot of time trying to back port the dialog fixes which are low priority. I want to get 5.0.1 tagged as soon as possible and merge the eeschema-gal stuff so we

Re: [Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread John Beard
Hi Wayne, I was only planning to make changes to the list dialog (as opposed to the editor dialog) in the master branch. I'm not planning to backport any of the filter stuff to 5.0.1. The aim is to check off https://bugs.launchpad.net/kicad/+bug/1778374 (Wishlist: add search box to Help --> List

Re: [Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread John Beard
Hi Wayne, Do you have any preference on the hotkey list dialog? I'm happy to go either way, but I'd like to know the preferred direction before I spend too much time on it! Cheers, John On Fri, Sep 28, 2018 at 3:11 PM Wayne Stambaugh wrote: >> Hey John, > > Nice work! I merged your patch into

Re: [Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread John Beard
HI Wayne, Yes, here is a separate patch for the 5.0 series. Cheers, John On Fri, Sep 28, 2018 at 3:11 PM Wayne Stambaugh wrote: > > Hey John, > > Nice work! I merged your patch into the development branch. I do have > one favor to ask if you have the time. Patch 6 does not apply to the >

Re: [Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread Wayne Stambaugh
Hey John, Nice work! I merged your patch into the development branch. I do have one favor to ask if you have the time. Patch 6 does not apply to the 5.0 branch which also suffers from the crash bug. If you could merge it into the 5.0 branch and send me a separate patch I would appreciate it.

[Kicad-developers] [PATCH] Hotkey edit dialog filter + fixes

2018-09-28 Thread John Beard
Hi, Here is a patch set for adding a filter control to the hotkey editor dialog. Preview video: https://sendvid.com/je0cyg87 Most of the work in the first commit is separating out the hotkey data from the UI widget code. This also fixes a couple of other bugs (one crashing, and one able to get