Hi,
I have worked out how to do unit tests of the Pcbnew code.
The first example test is a pretty unexciting one about the import
plugin manager (which is what I was doing at the time).
This is followed by a fix for a minor 5.1 bug with a unit test on the
logic (numbered NPTH pads in arrays)
Al
Hi John-
Patch 0002 does not apply cleanly to qa/CMakeLists.txt even after
applying 0001
-S
Am 2019-01-04 09:36, schrieb John Beard:
Hi,
I have worked out how to do unit tests of the Pcbnew code.
The first example test is a pretty unexciting one about the import
plugin manager (which is wh
On Sat, Jan 5, 2019 at 4:23 PM Seth Hillbrand wrote:
> Patch 0002 does not apply cleanly to qa/CMakeLists.txt even after
> applying 0001
Hmm, that's odd: I can apply this with "git am 0002". I'm applying
on top of 69fc301bf. Where are you applying it to? Do you still have
the triangulation t
I just did git am 000* and it worked fine for me, on master.
On Sun, 6 Jan 2019 at 01:20, John Beard wrote:
> On Sat, Jan 5, 2019 at 4:23 PM Seth Hillbrand wrote:
>
> > Patch 0002 does not apply cleanly to qa/CMakeLists.txt even after
> > applying 0001
>
> Hmm, that's odd: I can apply this with
Am 2019-01-05 19:24, schrieb John Beard:
On Sat, Jan 5, 2019 at 4:23 PM Seth Hillbrand
wrote:
Patch 0002 does not apply cleanly to qa/CMakeLists.txt even after
applying 0001
Hmm, that's odd: I can apply this with "git am 0002". I'm applying
on top of 69fc301bf. Where are you applying it
Except it fails to build for me :/
http://ci.kicad-pcb.org/job/linux-kicad-full-gcc-head/4485/consoleText
CMake Error at qa/pcbnew/CMakeLists.txt:62 (target_link_libraries):
Target "pcbnew_kiface_objects" of type OBJECT_LIBRARY may not be linked
into another target. One may link only to STAT
Am 2019-01-06 12:52, schrieb Nick Østergaard:
Except it fails to build for me :/
http://ci.kicad-pcb.org/job/linux-kicad-full-gcc-head/4485/consoleText
Hmm... Must be a cmake version thing. Clean build works fine in Debian
Buster.
Maybe we can add the libraries to the executable def?
Le 06/01/2019 à 19:31, Seth Hillbrand a écrit :
> Am 2019-01-06 12:52, schrieb Nick Østergaard:
>> Except it fails to build for me :/
>>
>> http://ci.kicad-pcb.org/job/linux-kicad-full-gcc-head/4485/consoleText
>
> Hmm... Must be a cmake version thing. Clean build works fine in Debian
> Buster.
>
Hi,
I'm not quite sure what happened here, but patch 0001 in the top email hasn't
been applied, but instead the RFC patch for the combined utilities tool program
has been applied (now commit 502306) instead.
If nothing else, this is unlikely to work on older boosts with that missing
first comm
Am 2019-01-06 15:14, schrieb John Beard:
Hi,
I'm not quite sure what happened here, but patch 0001 in the top email
hasn't been applied, but instead the RFC patch for the combined
utilities tool program has been applied (now commit 502306) instead.
Ugh. Sorry all! I clearly mixed up the comm
Hi Seth,
The revert commit (8f11a2133efd95526d1a3783dbaca76f732b8efb) also
killed the CMake add_subdirectory (because the original commit was
conflicted). Here is a patch to put it back in order (and put the
existing subdirs into some order).
Cheers,
John
On Mon, Jan 7, 2019 at 12:20 AM Seth Hi
Le 07/01/2019 à 12:33, John Beard a écrit :
> Hi Seth,
>
> The revert commit (8f11a2133efd95526d1a3783dbaca76f732b8efb) also
> killed the CMake add_subdirectory (because the original commit was
> conflicted). Here is a patch to put it back in order (and put the
> existing subdirs into some order).
Hi JP,
Sorry, I thought that issue was just a side effect of conflicted
merges in these files, but maybe not. I had built this code on Linux
GCC, Windows Msys2 and MSVC on Simon's Jenkins with no issues, so I'm
working blind in trying to fix it.
I think it might be an issue with older CMakes, but
I just ran a 32 bit build on windows with commit 3f9230fa and I didn't
have any build or test issues.
Cheers,
Wayne
On 1/7/2019 8:00 AM, John Beard wrote:
> Hi JP,
>
> Sorry, I thought that issue was just a side effect of conflicted
> merges in these files, but maybe not. I had built this code
Hi Wayne,
3f9230fa5 doesn't have add_subdirectory( pcbnew ) in
qa/CMakeLists.txt, because the reversion of the merge conflicts with
the stray patch removed it.
if you add the add_subdirectory( pcbnew ) line back, it is reported to
break on some systems. This could be a CMake version thing, but al
Hey John,
I only see three tests. Does your latest patch enable this so I can
test it?
Cheers,
Wayne
On 1/7/2019 8:39 AM, John Beard wrote:
> Hi Wayne,
>
> 3f9230fa5 doesn't have add_subdirectory( pcbnew ) in
> qa/CMakeLists.txt, because the reversion of the merge conflicts with
> the stray p
Le 07/01/2019 à 14:00, John Beard a écrit :
> Hi JP,
>
> Sorry, I thought that issue was just a side effect of conflicted
> merges in these files, but maybe not. I had built this code on Linux
> GCC, Windows Msys2 and MSVC on Simon's Jenkins with no issues, so I'm
> working blind in trying to fix
For macOS, I'm working on making it easy for folks to request a build with
a patch/git branch. It'll happen!
On Mon, Jan 7, 2019 at 8:48 AM jp charras wrote:
> Le 07/01/2019 à 14:00, John Beard a écrit :
> > Hi JP,
> >
> > Sorry, I thought that issue was just a side effect of conflicted
> > mer
On Mon, Jan 7, 2019 at 2:47 PM jp charras wrote:
> This patch works.
Great!
> make test works and shows only 3 tests:
Looks like you don't have the python scripting on, so you are missing
the qa_python target. The pcbnew target (this one) is there.
> So it can be a cmake issue and/or a operat
JP,
If you still have this patch applied to your repo, please push it to the
development branch when you get a chance. If not, please let me know
and I will get it pushed.
Thanks,
Wayne
On 1/7/2019 9:59 AM, John Beard wrote:
> On Mon, Jan 7, 2019 at 2:47 PM jp charras wrote:
>
>> This patch
Le 07/01/2019 à 17:57, Wayne Stambaugh a écrit :
> JP,
>
> If you still have this patch applied to your repo, please push it to the
> development branch when you get a chance. If not, please let me know
> and I will get it pushed.
>
> Thanks,
>
> Wayne
I just pushed it.
--
Jean-Pierre CHARR
21 matches
Mail list logo
