Re: [Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-31 Thread Pedro Martin
Oops, sorry! I answered to the wrong mail. I wanted to answer to this other mail. Hi ��igo, I totally disagree. I'll send you a private email. Or better, we could discuss this issue in front of a beer ;-) Pedro. El 31/07/18 a las 09:35, I�igo escribi�: There are some issues

Re: [Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-31 Thread Nick Østergaard
FYI there is also a GTK setting to choose to show icons or not, so some users on linux see the icons and other not depending on that option, and also depending on the kicad option to show icons or not. Den tir. 31. jul. 2018 kl. 13.45 skrev John Beard : > > Flag icons are also (ab)used in the

Re: [Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-31 Thread John Beard
Flag icons are also (ab)used in the About dialog for the translator credits. According to `git grep "lang_.*_xpm`, that's the only other use. As expected, I don't see them in the menu on Arch Linux, but I do have other menu icons. Cheers, John On Tue, Jul 31, 2018 at 12:24 PM, jp charras

Re: [Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-31 Thread jp charras
Le 31/07/2018 à 13:16, Jeff Young a écrit : > I don’t see the flag icons in my languages menu (OSX).  Is this > platform-specific? > wxMenuItems with type = wxITEM_CHECK do not display icons on all platforms or window managers. They are displayed on Windows, and not on my Linux Ubuntu / KDE

Re: [Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-31 Thread Jeff Young
I don’t see the flag icons in my languages menu (OSX). Is this platform-specific? > On 31 Jul 2018, at 08:35, Iñigo wrote: > > There are some issues there. > There is Spanish and Castilian. Castilian is the Spanish spoken in Spain, and > is the actual Spanish used in KiCad. So,

Re: [Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-31 Thread Iñigo
There are some issues there.There is Spanish and Castilian. Castilian is the Spanish spoken in Spain, and is the actual Spanish used in KiCad. So, technically, the KiCad language menu should show Castilian as an option and not Spanish.Iñigo.___ Mailing

Re: [Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-30 Thread Mark Roszko
Is KiCad still really doing language icons? Are we going to ignore how offensive it is to mix up English with just the British flag and Spanish with the flag of Spain when there is an entire continent of countries speaking the language... On Mon, Jul 30, 2018 at 5:57 PM Seth Hillbrand wrote: > >

Re: [Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-30 Thread Seth Hillbrand
​Good catch! Thanks John. Best- Seth​ Am Do., 26. Juli 2018 um 08:16 Uhr schrieb John Beard < john.j.be...@gmail.com>: > Hi, > > The SVGs for Catalan and Chinese did not match the XPM constant names, > so there were linking errors. > > I'm not sure how this hasn't been causing breakages since

[Kicad-developers] [PATCH] Rename lang_catalan and lang_chinese SVGs

2018-07-26 Thread John Beard
Hi, The SVGs for Catalan and Chinese did not match the XPM constant names, so there were linking errors. I'm not sure how this hasn't been causing breakages since 7841f8a466, but presumably it only breaks if you have MAINTAIN_PNGs on *and* clean something in a way most people don't, as the old