Re: [Kicad-developers] [PATCH] Rewrite loop conditions in SchematicCleanUp

2016-06-29 Thread Wayne Stambaugh
On 6/29/2016 1:37 PM, Simon Richter wrote: > Hi Wayne, > > On 29.06.2016 17:29, Wayne Stambaugh wrote: > >> This patch needs rebased as well. Please include the patch as an >> attachment rather than inline. Bazaar doesn't play as nicely with >> inline mail merges as git does. > > The "Rewrite

Re: [Kicad-developers] [PATCH] Rewrite loop conditions in SchematicCleanUp

2016-06-29 Thread Simon Richter
Hi Wayne, On 29.06.2016 17:29, Wayne Stambaugh wrote: > This patch needs rebased as well. Please include the patch as an > attachment rather than inline. Bazaar doesn't play as nicely with > inline mail merges as git does. The "Rewrite loop conditions" one, or the "BOOST_FOREACH" one? The

Re: [Kicad-developers] [PATCH] Rewrite loop conditions in SchematicCleanUp

2016-06-29 Thread Wayne Stambaugh
I really need to start reading my email more carefully. On 6/29/2016 11:36 AM, Wayne Stambaugh wrote: > Sorry about the confusion. This patch was an attachment but your rebase ^^ Simon's > of replacing boost::shared_ptr with

Re: [Kicad-developers] [PATCH] Rewrite loop conditions in SchematicCleanUp

2016-06-29 Thread Wayne Stambaugh
Sorry about the confusion. This patch was an attachment but your rebase of replacing boost::shared_ptr with std::shared_ptr patch was not so I just wanted to make sure your updated boost FOREACH patch was an attachment. On 6/29/2016 11:34 AM, Chris Pavlina wrote: > That is an attachment, I think

Re: [Kicad-developers] [PATCH] Rewrite loop conditions in SchematicCleanUp

2016-06-29 Thread Chris Pavlina
That is an attachment, I think you need a better mail client. ;) On Wed, Jun 29, 2016 at 11:29:56AM -0400, Wayne Stambaugh wrote: > Simon, > > This patch needs rebased as well. Please include the patch as an > attachment rather than inline. Bazaar doesn't play as nicely with > inline mail

Re: [Kicad-developers] [PATCH] Rewrite loop conditions in SchematicCleanUp

2016-06-29 Thread Wayne Stambaugh
Simon, This patch needs rebased as well. Please include the patch as an attachment rather than inline. Bazaar doesn't play as nicely with inline mail merges as git does. Thanks, Wayne On 6/21/2016 11:26 AM, Simon Richter wrote: > > These are a tiny bit more readable, and do not depend on

[Kicad-developers] [PATCH] Rewrite loop conditions in SchematicCleanUp

2016-06-21 Thread Simon Richter
These are a tiny bit more readable, and do not depend on all branches to correctly advance the loop variable. --- eeschema/sch_screen.cpp | 27 +++ 1 file changed, 7 insertions(+), 20 deletions(-) diff --git a/eeschema/sch_screen.cpp b/eeschema/sch_screen.cpp index