Re: [Kicad-developers] [PATCH] eeschema: neatly wrap placeholder text in symbol chooser

I can't think of a better place to put it. I was hoping once legacy canvas is removed completely from KiCad that this file would go away but that isn't going to be any time soon. Maybe we move this to a dialog helper file at that point if it's still necessary. On 01/07/2018 05:09 PM, Chris

Re: [Kicad-developers] [PATCH] eeschema: neatly wrap placeholder text in symbol chooser

Okay, I'll put it there and push. I wasn't sure it was a good fit there, but it's better there than hidden away as a static. On Sun, Jan 07, 2018 at 10:06:16PM +, Wayne Stambaugh wrote: > The best place I can think of is the common/gr_basic.cpp file where all > of the other wxDC drawing

Re: [Kicad-developers] [PATCH] eeschema: neatly wrap placeholder text in symbol chooser

The best place I can think of is the common/gr_basic.cpp file where all of the other wxDC drawing functions reside. On 01/07/2018 05:03 PM, Chris Pavlina wrote: > Yeah, I was asking if anybody saw a better place for the static function > I implemented, it could definitely be moved into common/

Re: [Kicad-developers] [PATCH] eeschema: neatly wrap placeholder text in symbol chooser

Yeah, I was asking if anybody saw a better place for the static function I implemented, it could definitely be moved into common/ where it can be used from elsewhere but I wasn't sure where to put it. On Sun, Jan 07, 2018 at 10:02:42PM +, Wayne Stambaugh wrote: > I tested it on Debian testing

Re: [Kicad-developers] [PATCH] eeschema: neatly wrap placeholder text in symbol chooser

I tested it on Debian testing and it looks fine to me. On 01/07/2018 04:40 PM, Chris Pavlina wrote: > Yup, I held it back to wait for comments. > > On Sun, Jan 07, 2018 at 09:31:06PM +, Wayne Stambaugh wrote: >> Chris, >> >> I didn't see this patch in your latest series of pushes. Is this

Re: [Kicad-developers] [PATCH] eeschema: neatly wrap placeholder text in symbol chooser

Yup, I held it back to wait for comments. On Sun, Jan 07, 2018 at 09:31:06PM +, Wayne Stambaugh wrote: > Chris, > > I didn't see this patch in your latest series of pushes. Is this still > relevant? > > Cheers, > > Wayne > > On 01/03/2018 08:55 PM, Chris Pavlina wrote: > > Hi, > > > >

Re: [Kicad-developers] [PATCH] eeschema: neatly wrap placeholder text in symbol chooser

Chris, I didn't see this patch in your latest series of pushes. Is this still relevant? Cheers, Wayne On 01/03/2018 08:55 PM, Chris Pavlina wrote: > Hi, > > The placeholder text that was added to the symbol preview in the chooser > ("double-click here...") has a manually placed line break,

Re: [Kicad-developers] [PATCH] eeschema: neatly wrap placeholder text in symbol chooser

Thanks for testing this Nick. Chris, do you need any further testing. I could boot into windows if you need it tested there. On 01/06/2018 07:52 AM, Nick Østergaard wrote: > I tested it on linux, seemed to work fine. > > Den 6. jan. 2018 1.45 PM skrev "Wayne Stambaugh"

Re: [Kicad-developers] [PATCH] eeschema: neatly wrap placeholder text in symbol chooser

I tested it on linux, seemed to work fine. Den 6. jan. 2018 1.45 PM skrev "Wayne Stambaugh" : > Hey Chris, I saw. I just haven't gotten around to testing it yet. I'm > drowning in the current patch volume. I'm going to try to get caught up > over the weekend. > > On

Re: [Kicad-developers] [PATCH] eeschema: neatly wrap placeholder text in symbol chooser

Hey Chris, I saw. I just haven't gotten around to testing it yet. I'm drowning in the current patch volume. I'm going to try to get caught up over the weekend. On 01/05/2018 09:51 PM, Chris Pavlina wrote: > Hey Wayne, did you see this? I'm pretty confident it's ready to push but > I'd like a

Re: [Kicad-developers] [PATCH] eeschema: neatly wrap placeholder text in symbol chooser

Hey Wayne, did you see this? I'm pretty confident it's ready to push but I'd like a second opinion on finding a good place for the function I had to write. On Thu, Jan 04, 2018 at 01:55:08AM +, Chris Pavlina wrote: > Hi, > > The placeholder text that was added to the symbol preview in the

[Kicad-developers] [PATCH] eeschema: neatly wrap placeholder text in symbol chooser

Hi, The placeholder text that was added to the symbol preview in the chooser ("double-click here...") has a manually placed line break, making it flow poorly anywhere the line length doesn't work well --- on my system with my DPI setting and fonts the line is cut off at almost any non-ridiculous