Re: [Kicad-developers] [PATCH] fix MANDATORY_FIELDS comparisons

2017-11-20 Thread Maciej Sumiński
Thank you Julius, I have just merged your patch. Regards, Orson On 11/18/2017 01:32 PM, Julius Schmidt wrote: > Apologies for the delay, but here's the patch as an attachment. > > On Thu, 9 Nov 2017, Wayne Stambaugh wrote: > >> Julius, >> >> I cannot git am this patch.  Apparently, the extra

Re: [Kicad-developers] [PATCH] fix MANDATORY_FIELDS comparisons

2017-11-18 Thread Julius Schmidt
Apologies for the delay, but here's the patch as an attachment. On Thu, 9 Nov 2017, Wayne Stambaugh wrote: Julius, I cannot git am this patch. Apparently, the extra info added by launchpad is causing an issue. Please resend this patch as an attachment so I can get it merged. Thanks, Wayne

Re: [Kicad-developers] [PATCH] fix MANDATORY_FIELDS comparisons

2017-11-09 Thread Wayne Stambaugh
Julius, I cannot git am this patch. Apparently, the extra info added by launchpad is causing an issue. Please resend this patch as an attachment so I can get it merged. Thanks, Wayne On 11/7/2017 4:31 AM, Julius Schmidt wrote: > I found a few places where SCH_FIELD::GetId() is incorrectly

[Kicad-developers] [PATCH] fix MANDATORY_FIELDS comparisons

2017-11-07 Thread Julius Schmidt
I found a few places where SCH_FIELD::GetId() is incorrectly (signed) compared to MANDATORY_FIELDS. I'm not sure all of these are bugs but at least the sch_component.cpp one triggers an assertion here when creating components with non-mandatory fields defined. --- eeschema/class_libentry.cpp