Hi Brano and Orson!
Code of the zooming was not modified in this patch. But I noticed, that
there is present MAC-specific block:
common/view/wx_view_controls.cpp (+147):
>
> #ifdef __WXMAC__
> // The following is to support Apple pointer devices (MagicMouse &
> // Macbook touchpad
Hi Orson,
this occurs when touchpad panning enabled. When TP panning disabled
wheel works ok (withou need to push ctrl).
When TP panning enabled it zoom in work ok. When zooming out it look to
me that sw zooms out and immediately zooms in again.
I am using wireless apple mouse which has bo
Hi Brano,
Are the problems occurring when touchpad panning is enabled? Is
everything fine once you disable it?
Would you give more details about zoom out being problematic? Does it
zoom out too quickly, is it choppy?
Regards,
Orson
On 01/19/2017 10:52 PM, Brano Panak wrote:
> Today i checked be
Today i checked behavior on osx with version: (2017-01-18 revision
2eb840b)-master
and behavior in pcbnew during zooming with wheel+ctrl(cmd on mac) on
apple mouse is very erratic.
Zoom in works ok, zoom out is very problematic.
Eeschema looks ok, pcbnew with zooming and scrolling on touchpad
Hi Konstantin,
I committed your patch. Thank you for making the changes Orson
suggested and the patch. In the future, please update the copyright
date when you make changes to source files.
Cheers,
Wayne
On 1/17/2017 12:17 PM, Константин Барановский wrote:
> In attachment placed new patch, th
In attachment placed new patch, that contains both previous patches and in
mousewheelpan mode, with pressed Shift key, does horizontal scrolling.
So, in common, we will get:
* mousewheelpan disabled:
- mousewheel = zooming;
- mousewheel + ctrl = horizontal scrolling;
- mousewheel + shift = vertic
Hi Konstantin,
Your patches were not ignored, the problem was neither me nor Wayne
could fully apply the patches in their original version. Thank you for
correcting this.
I still hold my previous remark about wheel scroll and shift+wheel
scroll doing the same thing when touchpad panning is enable
I tested the patches and both the legacy and GAL canvases appear to
behave the same way so if no one objects, I'm going to commit the changes.
In the future, please commit your changes and use git format-patch to
generate patches. It makes my life easier.
On 1/16/2017 1:38 PM, Константин Баранов
Thank you, Wayne, for your response. I'm attached the checked patches.
2017-01-16 20:07 GMT+02:00 Wayne Stambaugh :
> You are not being ignored. I can't speak for all of the lead developers
> but I've been really busy so pretty much everyone has been getting
> ignored by me. It's not intentiona
You are not being ignored. I can't speak for all of the lead developers
but I've been really busy so pretty much everyone has been getting
ignored by me. It's not intentional, it's just the reality of my
current work load.
Patch is giving me an unexpected eof with 3d_viewer-pan_step.patch.
Did
Hello. I'm sorry for disturbing you, but I'm not understand why my messages
are ignored. Proposed feature not needed for no one, except me? Or I'm made
something wrong? Please, give any comment.
2017-01-06 12:03 GMT+02:00 Константин Барановский <
baranovskiykonstan...@gmail.com>:
> 2016-11-23 0:2
2016-11-23 0:22 GMT+02:00 Maciej Sumiński :
> I could not apply the second patch, it gives me "unexpected end of file
> in patch" error. Would you verify the file?
>
>
I downloaded both patches and checked them, they looks good for me. I do
not got any problems or errors.
The patch seems reasonable to me. Currently with touchpad panning
enabled there is no way to zoom with the scroll motion. With the patch
applied zoom both are enabled. I do not have a two-wheel mouse or a
touchpad to test if everything works well for the second axis, but the
patch seems correct.
I
Please, pay attention to these patches.
2016-11-12 22:35 GMT+02:00 Константин Барановский <
baranovskiykonstan...@gmail.com>:
> New version of the patch that works in legacy/opengl/cairo/3d_viewer.
>
> Also I noticed that in 3d_viewer pan step is to big, so I propose decrease
> it.
>
> 2016-11-12
New version of the patch that works in legacy/opengl/cairo/3d_viewer.
Also I noticed that in 3d_viewer pan step is to big, so I propose decrease
it.
2016-11-12 9:33 GMT+02:00 Константин Барановский <
baranovskiykonstan...@gmail.com>:
> Hmm. This patch really works only in legacy mode and doesn't
Hmm. This patch really works only in legacy mode and doesn't work in GAL
mode, but I don't understand why. It looks like both modes legacy and GAL
used the same event handler for mouse wheel event, but still does not
work. Can anyone to point me to right direction for searching, please?
2016-11-1
Thanks Bernhard. The behavior should be the same for the gal canvas and
the 3d-viewer.
On 11/11/2016 2:26 PM, Bernhard Stegmaier wrote:
> I’ll try to test ASAP, but I can’t promise when.
>
> At least on first glance it seems to be somewhat incomplete.
> It only seems to change legacy canvas, but
I’ll try to test ASAP, but I can’t promise when.
At least on first glance it seems to be somewhat incomplete.
It only seems to change legacy canvas, but not GAL canvas or 3d-viewer, which
should probably behave the same then?
Regards,
Bernhard
> On 11 Nov 2016, at 16:04, Wayne Stambaugh wrote:
This doesn't break anything on osx does it? That is what I need to know
before I commit the patch. Would one of the osx devs please confirm
this form me when you get a chance?
Thanks,
Wayne
On 11/11/2016 10:01 AM, Константин Барановский wrote:
> I'm using archlinux x86_64 on thinkpad t420 (tha
I'm using archlinux x86_64 on thinkpad t420 (that allows two-finger
scrolling) and all modifier keys (ctrl, shift, alt) does nothing.
2016-11-11 16:31 GMT+02:00 Brano Panak :
> in osx even without this patch this functionality works (cmd+ mouse wheel
> is zooming).
>
> On 10/11/16 11:41, Констант
in osx even without this patch this functionality works (cmd+ mouse
wheel is zooming).
On 10/11/16 11:41, Константин Барановский wrote:
That patch allows to use mouse wheel + ctrl for zooming, when option
"Use touchpad to pan" is enabled.
___
Mai
That patch allows to use mouse wheel + ctrl for zooming, when option "Use
touchpad to pan" is enabled.
diff --git a/common/draw_panel.cpp b/common/draw_panel.cpp
index a705791..f4970d8 100644
--- a/common/draw_panel.cpp
+++ b/common/draw_panel.cpp
@@ -981,15 +981,25 @@ void EDA_DRAW_PANEL::OnMouseW
22 matches
Mail list logo
