Re: [Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

2016-05-05 Thread Simon Richter
Hi, On 05.05.2016 20:01, Bernhard Stegmaier wrote: > Just a note… I may be wrong, but I guess for OS X this is only true if you > build against the curl supplied by OS X natively? Would it make sense to serialize the network accesses if libcurl tells us that it is using the OpenSSL backend (at

Re: [Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

2016-05-05 Thread Bernhard Stegmaier
Just a note… I may be wrong, but I guess for OS X this is only true if you build against the curl supplied by OS X natively? My builds per default always pick the one from MacPorts, which links against OpenSSL or GnuTLS (depending on MacPorts config)… in this case I guess you will see the same

Re: [Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

2016-05-05 Thread Mark Roszko
You don't need openssl locking for OSX >= 10.9. curl uses Apple Common Crypto. Other platforms may need it depending on Linux distro (some have dropped openssl for curl, some haven't). On Thu, May 5, 2016 at 12:17 PM, Adam Wolf wrote: > Simon, > > Is the OpenSSL

Re: [Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

2016-05-05 Thread Adam Wolf
Simon, Is the OpenSSL locking workaround something we know we'll need for the libcurl backport? If so, do we have someone who can work on it? I can set up a build for this whenever it's needed. Adam Wolf On Thu, May 5, 2016 at 10:26 AM, Simon Richter wrote: > Hi

Re: [Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

2016-05-05 Thread Wayne Stambaugh
On 5/5/2016 11:26 AM, Simon Richter wrote: > Hi Wayne, > > On 05.05.2016 16:15, Wayne Stambaugh wrote: > >> Thanks Simon! Nice work. I just tested this on windows and it appears >> to work fine. I'm assuming you tested this on Linux. > > Yes, briefly. These are just the two "switch to CURL"

Re: [Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

2016-05-05 Thread Simon Richter
Hi Wayne, On 05.05.2016 16:15, Wayne Stambaugh wrote: > Thanks Simon! Nice work. I just tested this on windows and it appears > to work fine. I'm assuming you tested this on Linux. Yes, briefly. These are just the two "switch to CURL" patches from the devel branch, and one small fix, so not

Re: [Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

2016-05-05 Thread Wayne Stambaugh
Please excuse my fat fingers. That should be 6440. On 5/5/2016 11:04 AM, Chris Pavlina wrote: > I do hope you didn't intent to credit Dick for 6640, that one's mine! ;) > > On Thu, May 05, 2016 at 10:57:34AM -0400, Wayne Stambaugh wrote: >> On 5/5/2016 10:47 AM, Chris Pavlina wrote: >>> On Thu,

Re: [Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

2016-05-05 Thread Chris Pavlina
I do hope you didn't intent to credit Dick for 6640, that one's mine! ;) On Thu, May 05, 2016 at 10:57:34AM -0400, Wayne Stambaugh wrote: > On 5/5/2016 10:47 AM, Chris Pavlina wrote: > > On Thu, May 05, 2016 at 10:15:02AM -0400, Wayne Stambaugh wrote: > >> [snip] > >> > >> I didn't see any credit

Re: [Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

2016-05-05 Thread Chris Pavlina
On Thu, May 05, 2016 at 10:15:02AM -0400, Wayne Stambaugh wrote: > [snip] > > I didn't see any credit to Dick for the work he did on libcurl > transition so that will need to be added to commit message. Hm, did he write any of the code in these patches? > > On 5/5/2016 4:39 AM, Simon Richter

Re: [Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

2016-05-05 Thread Wayne Stambaugh
On 5/5/2016 10:47 AM, Chris Pavlina wrote: > On Thu, May 05, 2016 at 10:15:02AM -0400, Wayne Stambaugh wrote: >> [snip] >> >> I didn't see any credit to Dick for the work he did on libcurl >> transition so that will need to be added to commit message. > > Hm, did he write any of the code in these

Re: [Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

2016-05-05 Thread Wayne Stambaugh
Thanks Simon! Nice work. I just tested this on windows and it appears to work fine. I'm assuming you tested this on Linux. Would one of our osx devs please apply these patches to the 4 stable branch and make sure that it builds and works correctly on osx? Once I finish vetting Chris` file

[Kicad-developers] [PATCH 0/4] Backport libcurl code from development branch

2016-05-05 Thread Simon Richter
Hi, this backports Mark's avhttp -> libcurl transition to the stable series. With these, I've been able to build a stable version of KiCad with the GitHub plugin enabled that does not link against OpenSSL, which should allow everyone to ship binaries with the Github plugin enabled. Simon