Re: [Kicad-developers] [PATCH 0/6] A few compatibility fixes

2017-12-06 Thread Chris Pavlina
On Wed, Dec 06, 2017 at 11:53:09PM +, Wayne Stambaugh wrote: > On 12/06/2017 06:42 PM, Chris Pavlina wrote: > > On Wed, Dec 06, 2017 at 11:38:21PM +, Wayne Stambaugh wrote: > >> Simon, > >> > >> I'm OK with most of these patches but since when is it invalid to > >> initialize a c array in

Re: [Kicad-developers] [PATCH 0/6] A few compatibility fixes

2017-12-06 Thread Wayne Stambaugh
Simon, I merged your patches into the development branch. Thanks, Wayne On 12/05/2017 09:42 PM, Simon Richter wrote: > Hi, > > these are a few things that cause build errors on MSVC, where gcc accepts > invalid code. Most of them are obvious. > > The pcb_test_window executable needs to be

Re: [Kicad-developers] [PATCH 0/6] A few compatibility fixes

2017-12-06 Thread Wayne Stambaugh
On 12/06/2017 06:42 PM, Chris Pavlina wrote: > On Wed, Dec 06, 2017 at 11:38:21PM +, Wayne Stambaugh wrote: >> Simon, >> >> I'm OK with most of these patches but since when is it invalid to >> initialize a c array in c++ (patch 4)? Isn't c a subset of c++ > > No, no it is not. OK,

Re: [Kicad-developers] [PATCH 0/6] A few compatibility fixes

2017-12-06 Thread Seth Hillbrand
Wayne- That was my mistake. C++ doesn't specify the C99 initialize by enum reference. So Simon is correct. -S On Wed, Dec 6, 2017 at 3:38 PM, Wayne Stambaugh wrote: > Simon, > > I'm OK with most of these patches but since when is it invalid to > initialize a c array in

Re: [Kicad-developers] [PATCH 0/6] A few compatibility fixes

2017-12-06 Thread Chris Pavlina
On Wed, Dec 06, 2017 at 11:38:21PM +, Wayne Stambaugh wrote: > Simon, > > I'm OK with most of these patches but since when is it invalid to > initialize a c array in c++ (patch 4)? Isn't c a subset of c++ No, no it is not. > or is > this just a fix to get kicad to compile with msvc? If

Re: [Kicad-developers] [PATCH 0/6] A few compatibility fixes

2017-12-06 Thread Wayne Stambaugh
Simon, I'm OK with most of these patches but since when is it invalid to initialize a c array in c++ (patch 4)? Isn't c a subset of c++ or is this just a fix to get kicad to compile with msvc? If it's the latter, the coding policy is pretty clear about that. Cheers, Wayne On 12/05/2017 09:42

[Kicad-developers] [PATCH 0/6] A few compatibility fixes

2017-12-05 Thread Simon Richter
Hi, these are a few things that cause build errors on MSVC, where gcc accepts invalid code. Most of them are obvious. The pcb_test_window executable needs to be linked with /SUBSYSTEM:WINDOWS on Windows because it is a GUI app, which uses different startup code than a console application. The