Re: [Kicad-developers] [PATCH 00/12] Minor cleanups and improvements

2017-11-09 Thread Maciej Suminski
Hi Marvin, On 11/09/2017 08:12 PM, Marvin Schmidt wrote: > Hey Orson, > > I actually didn't skip any patch, #8 ("Remove orphaned code files") > should is there: > https://lists.launchpad.net/kicad-developers/msg31304.html Strange, I have never received this message, but now I am glad that I

Re: [Kicad-developers] [PATCH 00/12] Minor cleanups and improvements

2017-11-07 Thread Maciej Sumiński
On 11/07/2017 01:24 AM, Wayne Stambaugh wrote: > On 11/3/2017 9:08 AM, Maciej Sumiński wrote: >> On 11/03/2017 01:38 PM, Carsten Schoenert wrote: >>> Hello Marvin, >>> >>> Am 02.11.2017 um 21:58 schrieb Marvin Schmidt: Just a set of small code cleanups to fix a bunch of warnings and

Re: [Kicad-developers] [PATCH 00/12] Minor cleanups and improvements

2017-11-06 Thread Wayne Stambaugh
On 11/3/2017 9:08 AM, Maciej Sumiński wrote: > On 11/03/2017 01:38 PM, Carsten Schoenert wrote: >> Hello Marvin, >> >> Am 02.11.2017 um 21:58 schrieb Marvin Schmidt: >>> Just a set of small code cleanups to fix a bunch of warnings >>> and remove dead code. >>> Other than that the 'build:' commits

Re: [Kicad-developers] [PATCH 00/12] Minor cleanups and improvements

2017-11-05 Thread Maciej Suminski
Hi Carsten, On 11/04/2017 08:47 AM, Carsten Schoenert wrote: > Hello Orson, > > Am 03.11.2017 um 14:08 schrieb Maciej Sumiński: > ... >> I think the e-mail subject contains the first line of commit message >> that explains the changes and most likely is handled correctly by >> git-am. > > I

Re: [Kicad-developers] [PATCH 00/12] Minor cleanups and improvements

2017-11-05 Thread Maciej Suminski
Hi Marvin, Have you skipped patch 0008 intentionally? Some of the changes from this set do not apply cleanly, would you rebase them? Regards, Orson On 11/02/2017 09:58 PM, Marvin Schmidt wrote: > Just a set of small code cleanups to fix a bunch of warnings > and remove dead code. > Other than

Re: [Kicad-developers] [PATCH 00/12] Minor cleanups and improvements

2017-11-04 Thread Carsten Schoenert
Hello Orson, Am 03.11.2017 um 14:08 schrieb Maciej Sumiński: ... > I think the e-mail subject contains the first line of commit message > that explains the changes and most likely is handled correctly by > git-am. I disagree on that. The subject off a commit should briefly describe *what* the

Re: [Kicad-developers] [PATCH 00/12] Minor cleanups and improvements

2017-11-03 Thread Maciej Sumiński
On 11/03/2017 01:38 PM, Carsten Schoenert wrote: > Hello Marvin, > > Am 02.11.2017 um 21:58 schrieb Marvin Schmidt: >> Just a set of small code cleanups to fix a bunch of warnings >> and remove dead code. >> Other than that the 'build:' commits avoid/remove/fix the >> installation of certain

Re: [Kicad-developers] [PATCH 00/12] Minor cleanups and improvements

2017-11-03 Thread Carsten Schoenert
Hello Marvin, Am 02.11.2017 um 21:58 schrieb Marvin Schmidt: > Just a set of small code cleanups to fix a bunch of warnings > and remove dead code. > Other than that the 'build:' commits avoid/remove/fix the > installation of certain files: > - it doesn't make much sense to install the