Re: [Kicad-developers] [PATCH 1/2] pin table: Add GetString() to retrieve string value for column

2016-01-14 Thread Chris Pavlina
Committed in 6472. Thank you. I also committed a minor fix to the coding style in 6473. On Wed, Jan 13, 2016 at 01:21:23AM +0100, Simon Richter wrote: > > This is in anticipation of the introduction of icons -- retrieving all the > icons and throwing them away during sorting takes ages. > --- >

Re: [Kicad-developers] [PATCH 1/2] pin table: Add GetString() to retrieve string value for column

2016-01-13 Thread Simon Richter
Hi Chris, Am 13.01.2016 um 02:23 schrieb Chris Pavlina: > This patch doesn't apply to the latest revision for me, at very least > the line numbers are off. Might have to rebase. Ah yes, that is on top of the other stack of patches I sent, where I split out the comparison function into a new fil

Re: [Kicad-developers] [PATCH 1/2] pin table: Add GetString() to retrieve string value for column

2016-01-12 Thread Chris Pavlina
Simon, This patch doesn't apply to the latest revision for me, at very least the line numbers are off. Might have to rebase. -- Chris On Wed, Jan 13, 2016 at 01:21:23AM +0100, Simon Richter wrote: > > This is in anticipation of the introduction of icons -- retrieving all the > icons and throw

[Kicad-developers] [PATCH 1/2] pin table: Add GetString() to retrieve string value for column

2016-01-12 Thread Simon Richter
This is in anticipation of the introduction of icons -- retrieving all the icons and throwing them away during sorting takes ages. --- eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 88 ++ 1 file changed, 47 insertions(+), 41 deletions(-) diff --git a/eeschema/dialogs/d