Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-07 Thread Wayne Stambaugh
Patch committed in product branch r6352. Thanks. On 12/1/2015 2:14 AM, Simon Richter wrote: > > CMake 3.0 defines two new variables, > > * CMAKE_CXX_VISIBILITY_PRESET and > * CMAKE_VISIBILITY_INLINES_HIDDEN > > to control whether symbols not explicitly tagged for export are implicitly > expo

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-02 Thread Bernhard Stegmaier
I am on a stock MacPorts boost since over a year now… 1.58 and now 1.59 (don’t know since when). I didn’t see any problems with it. Regards, Bernhard > On 02 Dec 2015, at 16:51, Wayne Stambaugh wrote: > > In the not too distant future, you will have to build boost (probably > version 1.59) in

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-02 Thread Wayne Stambaugh
I've already updated the markdown file for the 64-bit boost 1.59 issue and will commit it as soon as I get a chance. As far as anything else is concerned, I would rather not turn this into step by step instructions. I expect a developer competent enough to build kicad from source to know how to r

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-02 Thread Aljaž Srebrnič
Just a heads-up. It’s not committed yet, as I wanted to integrate your patches to wxWidgets. Right now a number of features do not work (pinch-to-zoom, …) and there is an irritating amount of ghosting when placing new components or tracks in eeschema. On 2 dicembre 2015 at 17:50:27, Adam Wolf (

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-02 Thread Adam Wolf
I will see about pulling in Aljaž's work--not sure how much of it is Macports specific until I take a look. On Wed, Dec 2, 2015 at 10:05 AM, Wayne Stambaugh wrote: > On 12/2/2015 11:03 AM, Mark Roszko wrote: > >> In the not too distant future, you will have to build boost (probably > version 1.5

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-02 Thread Mark Roszko
O yea I was going to submit a patch to add a note along with some more elaboration on "hard way" building because its incomplete for a fresh install. i.e. missing make and cmake packages. Also the run "pacman -Syu" after fresh install is wrong as it will throw errors, theres a command you have to r

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-02 Thread Wayne Stambaugh
On 12/2/2015 11:03 AM, Mark Roszko wrote: >> In the not too distant future, you will have to build boost (probably >> version 1.59) > > If there's ever a recommendation written somewhere. There needs to be > a big note somewhere that 1.59 is broken on 64-bit windows in > boost::context. I suggest

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-02 Thread Mark Roszko
>In the not too distant future, you will have to build boost (probably version >1.59) If there's ever a recommendation written somewhere. There needs to be a big note somewhere that 1.59 is broken on 64-bit windows in boost::context. I suggest using a recommended of 1.57 since that's before it br

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-02 Thread Aljaž Srebrnič
Hello! I managed to build everything without any downloaded deps on OS X. I’ve already updated my Portfile to build the 4.0.0 stable, and so far it builds and runs. I’ll try to use and test it some more later today. On 2 dicembre 2015 at 16:51:54, Wayne Stambaugh (stambau...@gmail.com) wrote: I

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-02 Thread Wayne Stambaugh
In the not too distant future, you will have to build boost (probably version 1.59) instead of using download_boost.cmake to download, patch, and build boost 1.54. Has anyone else in OSX land successfully built KiCad using their own boost build? I may have to hold off getting rid of the boost dep

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-02 Thread Adam Wolf
I do not think so. Right now, the nightly packages use something like this for CMake settings: KiCad CMake Settings: -DDEFAULT_INSTALL_PATH=/Library/Application Support/kicad -DCMAKE_C_COMPILER=/usr/bin/clang -DCMAKE_CXX_COMPILER=/usr/bin/clang++ -DCMAKE_OSX_SYSROOT=/Users/wolf/projects/kicad-mac

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-02 Thread Wayne Stambaugh
No hurry. The stable release OSX package has priority. I just need confirmation on OSX builds that the patch wont break anything. One other question: do you use the KICAD_BUILD_STATIC or KICAD_BUILD_DYNAMIC options for your build configuration? I can't see where they were used outside of OSX_DE

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-02 Thread Adam Wolf
I can but I need to get the 4.0.0 build out first. If someone else can do it sooner than end of this week/weekend, please do :) On Wed, Dec 2, 2015 at 8:30 AM, Wayne Stambaugh wrote: > Would one of our OSX devs please confirm this doesn't break anything on > OSX builds before I commit it. > > T

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-02 Thread Wayne Stambaugh
Would one of our OSX devs please confirm this doesn't break anything on OSX builds before I commit it. Thanks, Wayne On 12/1/2015 2:14 AM, Simon Richter wrote: > > CMake 3.0 defines two new variables, > > * CMAKE_CXX_VISIBILITY_PRESET and > * CMAKE_VISIBILITY_INLINES_HIDDEN > > to control w

Re: [Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-12-01 Thread Wayne Stambaugh
Any way to make this patch less noisy? It seems to work fine on windows builds but it would be nice if it didn't spew so many cmake policy warnings. I wont bump the cmake version until it's available on Debian stable (currently cmake 3.0.2) which I use as my benchmark for version availability. O

[Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-11-30 Thread Simon Richter
CMake 3.0 defines two new variables, * CMAKE_CXX_VISIBILITY_PRESET and * CMAKE_VISIBILITY_INLINES_HIDDEN to control whether symbols not explicitly tagged for export are implicitly exported. Because only version 3.3 and following also applies that to static libraries when in 3.3 mode, compatibi