Re: [Kicad-developers] [PATCH 13/16] Avoid static variable in wire merge

2016-06-27 Thread Wayne Stambaugh
Patch committed in product branch r6951. Thanks. On 6/27/2016 2:36 PM, Simon Richter wrote: > Hi Wayne, > > On 27.06.2016 20:21, Wayne Stambaugh wrote: > >> This patch and 0014-Reserve-appropriate-space-in-local-vector.patch have >> been committed to the product branch r6950. > > I have an eve

Re: [Kicad-developers] [PATCH 13/16] Avoid static variable in wire merge

2016-06-27 Thread Simon Richter
Hi Wayne, On 27.06.2016 20:21, Wayne Stambaugh wrote: > This patch and 0014-Reserve-appropriate-space-in-local-vector.patch have > been committed to the product branch r6950. I have an even better implementation by now, using std::min and std::max, that I posted a few days later. That patch, reb

Re: [Kicad-developers] [PATCH 13/16] Avoid static variable in wire merge

2016-06-27 Thread Wayne Stambaugh
This patch and 0014-Reserve-appropriate-space-in-local-vector.patch have been committed to the product branch r6950. FYI, U fixed a coding policy violation. The line: candidates.reserve(4); should read: candidates.reserve( 4 ); Also, please update the copy right date as needed when modifying

[Kicad-developers] [PATCH 13/16] Avoid static variable in wire merge

2016-06-07 Thread Simon Richter
There is little to no reason why this variable should be static, given that it is cleared after each iteration. --- eeschema/sch_line.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/eeschema/sch_line.cpp b/eeschema/sch_line.cpp index 72efb5c..050b786 100644 --- a/eeschem