Re: [Kicad-developers] [RFC] Eeschema dialog tweaks

2014-10-08 Thread Brian Sidebotham
Hi Mark, Thanks for your work, I've not had a chance to look at the merge request. Generally discussion is always a great idea because it's hard to glean from a diff what the intended changes are and what the impact is going to be. I'm at work at the moment so still can't review the diff. I'm

Re: [Kicad-developers] [RFC] Eeschema dialog tweaks

2014-10-08 Thread Wayne Stambaugh
On 10/8/2014 12:34 AM, Mark Roszko wrote: I was thinking it could be Total issues, Warnings, Errors, having the word count repeat 3 times seems...redundant. Total errors is also wrong since its warnings + errors. Using Total would be just as clear and would line up nicer with Warnings and

Re: [Kicad-developers] [RFC] Eeschema dialog tweaks

2014-10-08 Thread Mark Roszko
Thanks for your work, I've not had a chance to look at the merge request. No problem. I'm currently working on the eeschema options dialog to improve the template field names editor so please don't change that at the moment, Ok, personally I haven't found much issue with the Options dialog.

[Kicad-developers] [RFC] Eeschema dialog tweaks

2014-10-07 Thread Mark Roszko
I submitted this as a merge request but it may be best to discuss it on the mailing list. I started to hit up the other Eeschema dialogs while I was working on the hotkey editor. https://code.launchpad.net/~mark-roszko/kicad/eeschema-dialog-tweaks Changes: = -Use the verb Generate

Re: [Kicad-developers] [RFC] Eeschema dialog tweaks

2014-10-07 Thread Mark Roszko
Also fixes ERC Dialog not counting errors at all. For some reason SetLabel was used on wxTextCtrl isntead of SetValue. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] [RFC] Eeschema dialog tweaks

2014-10-07 Thread Blair Bonnett
On 8 October 2014 16:43, Mark Roszko mark.ros...@gmail.com wrote: I submitted this as a merge request but it may be best to discuss it on the mailing list. I started to hit up the other Eeschema dialogs while I was working on the hotkey editor.

Re: [Kicad-developers] [RFC] Eeschema dialog tweaks

2014-10-07 Thread Mark Roszko
I was thinking it could be Total issues, Warnings, Errors, having the word count repeat 3 times seems...redundant. Total errors is also wrong since its warnings + errors. ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] [RFC] Eeschema dialog tweaks

2014-10-07 Thread Blair Bonnett
On 8 October 2014 17:34, Mark Roszko mark.ros...@gmail.com wrote: I was thinking it could be Total issues, Warnings, Errors, having the word count repeat 3 times seems...redundant. Total errors is also wrong since its warnings + errors. Sounds even better.