Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-16 Thread Mathias Grimmberger
Hi Clemens, Clemens Koller writes: > Hi, Mathias! > > On 2016-01-14 20:06, Mathias Grimmberger wrote: > > In the current drawing code in some places we build polygons > > approximating the corner quarter circles, e.g. using 8 segments. For a > > very small radius there will be segments of zero

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-15 Thread jp charras
Le 14/01/2016 01:39, Cirilo Bernardo a écrit : > On Tue, Jan 12, 2016 at 10:06 AM, Mathias Grimmberger > wrote: <> > I'd like to implement arbitrary pad shapes but this requires a functional 2D > geometry kernel first. I'm starting on one but I may have nothing to >

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-15 Thread Tomasz Wlostowski
On 15.01.2016 21:02, jp charras wrote: > Le 14/01/2016 01:39, Cirilo Bernardo a écrit : >> On Tue, Jan 12, 2016 at 10:06 AM, Mathias Grimmberger >> wrote: > > <> > >> I'd like to implement arbitrary pad shapes but this requires a functional 2D >> geometry kernel first.

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-14 Thread Clemens Koller
Hello, Cirilo! On 2016-01-14 01:39, Cirilo Bernardo wrote: > I'd like to implement arbitrary pad shapes but this requires a functional 2D > geometry kernel first. I'm starting on one but I may have nothing to > demonstrate > until the end of the year. That sounds very interesting - until I read

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-14 Thread Clemens Koller
Hi, Mathias! On 2016-01-14 20:06, Mathias Grimmberger wrote: > In the current drawing code in some places we build polygons > approximating the corner quarter circles, e.g. using 8 segments. For a > very small radius there will be segments of zero length in that > approximation. Can you point me

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-14 Thread Mathias Grimmberger
Hello Clemens. Clemens Koller writes: > Hello, Mathias! > > Thank you for your time spending on this. > > >>> Clemens Koller writes: > >> First feedback: It would be great to make the corner radius variable > >> instead of fixing it to 25% of the shorter pad edge and <=0.25mm.

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-13 Thread Clemens Koller
Hello, Mathias! Thank you for your time spending on this. >>> Clemens Koller writes: >> First feedback: It would be great to make the corner radius variable >> instead of fixing it to 25% of the shorter pad edge and <=0.25mm. [1] > That can certainly be done. > What do you

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-12 Thread Mathias Grimmberger
Hello Clemens, Clemens Koller writes: > Hi, Mathias! > > On 2016-01-12 00:06, Mathias Grimmberger wrote: >> I refreshed a part of my patch for rounded rectangle pads (minus the >> plotting stuff, OpenGL canvas, stuff I probably forgot) so everybody >> interested can have a look

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-12 Thread Clemens Koller
Hello, Mathias! On 2016-01-12 21:29, Mathias Grimmberger wrote: > Clemens Koller writes: >> Can you rebase your patch, please? > > Please find attached a patch done against rev 6455, I hope I put it all > together correctly, especially the DRC clearance stuff. > > I also added

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-12 Thread Clemens Koller
Hi, Wayne! On 2016-01-13 01:35, Wayne Stambaugh wrote: > I have a very simple rule about file compatibility. We will always > maintain backwards compatibility. If you want to take advantage of the > new file features during development, then you should be willing help > with testing of those

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-12 Thread Wayne Stambaugh
I have a very simple rule about file compatibility. We will always maintain backwards compatibility. If you want to take advantage of the new file features during development, then you should be willing help with testing of those features. That is your cost for having a free (as in beer and

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-12 Thread Wayne Stambaugh
This patch changes the pcb file format. While I'm not opposed to that, we really should decide on a set of changes for this development cycle and implement them in one go. Otherwise we will have a bunch of incompatible file formats during this dev cycle which I would like to avoid. The other

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-12 Thread Clemens Koller
Hello, Wayne! On 2016-01-13 00:55, Wayne Stambaugh wrote: > This patch changes the pcb file format. Are there ideas to migrate at some time towards file formats or conventions which are versioned, extensible and still backward compatible? Opening a file/project with an old version can then warn

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-11 Thread Clemens Koller
Thanks, Mathias! I'm looking forward to test that as soon as I can. (Currently a busy with commercial stuff.) On 2016-01-12 00:06, Mathias Grimmberger wrote: > I refreshed a part of my patch for rounded rectangle pads (minus the > plotting stuff, OpenGL canvas, stuff I probably forgot) so

[Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-11 Thread Mathias Grimmberger
Hi all, I refreshed a part of my patch for rounded rectangle pads (minus the plotting stuff, OpenGL canvas, stuff I probably forgot) so everybody interested can have a look and play a bit with it, see below. Now to my question: is there interest in this stuff, is there maybe a different plan in

Re: [Kicad-developers] [RFC PATCH] Rounded rectangle pads

2016-01-11 Thread Clemens Koller
Hi, Mathias! On 2016-01-12 00:06, Mathias Grimmberger wrote: > I refreshed a part of my patch for rounded rectangle pads (minus the > plotting stuff, OpenGL canvas, stuff I probably forgot) so everybody > interested can have a look and play a bit with it, see below. Unfortunately, your patch