Re: [Kicad-developers] 3d viewer updates

2015-03-28 Thread jp charras
Le 28/03/2015 01:07, Mário Luzeiro a écrit : > Hi Jean-Pierre, > > Here is my updates as you suggested. > I make an overall pass with some improvements in the documentation and coding > style. Still some missing, let me know if still something really needs > attention. > > Additional, some impr

Re: [Kicad-developers] 3d viewer updates

2015-03-24 Thread jp charras
Le 24/03/2015 10:43, Mário Luzeiro a écrit : > Hi Jean-Pierre, > >> and >> unsigned char* m_pixels; >> should be: >> unsigned char* m_Pixels; > > I am a little confused about this. > I was checking with the coding style policy and this look different because > there are no example cas

Re: [Kicad-developers] 3d viewer updates

2015-03-24 Thread Mário Luzeiro
Hi Jean-Pierre, > and > unsigned char* m_pixels; > should be: > unsigned char* m_Pixels; I am a little confused about this. I was checking with the coding style policy and this look different because there are no example case for m_* use. I checked in the source files and I can see i

Re: [Kicad-developers] 3d viewer updates

2015-03-23 Thread Mário Luzeiro
I will! I missed a bit that overall evaluation of the coding policy. MRL From: jp charras [jp.char...@wanadoo.fr] Sent: 23 March 2015 20:48 To: Mário Luzeiro; kicad-developers@lists.launchpad.net Subject: Re: 3d viewer updates Le 23/03/2015 12:01, Mário Lu

Re: [Kicad-developers] 3d viewer updates

2015-03-23 Thread jp charras
Le 23/03/2015 12:01, Mário Luzeiro a écrit : > Hello all, > here are my new contribution for the 3d-viewer. > > > I feel that I cannot do or think in any major improvements to 3d-viewer in > the way it is now. > I think that changes must be done in the 3d-viewer architecture and > integration w