Re: [Kicad-developers] A reminder on Git commit comments

2018-05-12 Thread Carsten Schoenert
Hello Rene, I'm answering with a it of delay, to much to do in to less time. We are going to be oftopic for this list and should do discussions about these specific topics on kicad-lib-committers ... but unfortunately this list is mostly dead and unused. Am 03.05.2018 um 12:57 schrieb Rene

Re: [Kicad-developers] A reminder on Git commit comments

2018-05-03 Thread Rene Pöschl
On 03/05/18 08:31, Carsten Schoenert wrote: Hello Rene, Am 02.05.2018 um 14:57 schrieb Rene Pöschl: Most of our contributors have no previous experience with git. So we really can not expect them to understand anything beyond the github workflow. (They are experts in electronics. Not IT) I

Re: [Kicad-developers] A reminder on Git commit comments

2018-05-03 Thread Martijn Kuipers
FWIW, there are a few software packages out there that can help with git and are free to use with open source projects, such as, Gitkraken and Smartgit. I am not affiliated with any of them, but I have used them both. They are pretty much similar for the most common use cases and both provide a

Re: [Kicad-developers] A reminder on Git commit comments

2018-05-03 Thread Carsten Schoenert
Hello Rene, Am 02.05.2018 um 14:57 schrieb Rene Pöschl: > Most of our contributors have no previous experience with git. So we > really can not expect them to understand anything beyond the github > workflow. (They are experts in electronics. Not IT) I also don't believe > we should burden the

Re: [Kicad-developers] A reminder on Git commit comments

2018-05-02 Thread Rene Pöschl
Most of our contributors have no previous experience with git. So we really can not expect them to understand anything beyond the github workflow. (They are experts in electronics. Not IT) I also don't believe we should burden the contributors with too much with this. This is even true for

Re: [Kicad-developers] A reminder on Git commit comments

2018-05-02 Thread Wayne Stambaugh
This is why we have a commit message policy. Obviously this isn't a perfect solution. Feel free to adopt this policy for library developer commits. There is always the hard line approach where you kick the merge request back to the submitted and ask them to fix the commit message or use `git

Re: [Kicad-developers] A reminder on Git commit comments

2018-05-02 Thread Rene Pöschl
Thanks for the reminder, we will try to better our ways. See: https://github.com/KiCad/kicad-symbols/issues/569 On 02/05/18 00:03, Reece R. Pollack wrote: I'd like to make an observation on some of the Git commit comments I'm reading. Some of these commit log entries are really unhelpful.

Re: [Kicad-developers] A reminder on Git commit comments

2018-05-01 Thread Adam Wolf
I believe most of the contributors to kicad-symbols actually do not read this mailing list. I know Rene does, but this may be better addressed by watching PRs on the kicad-symbols GitHub repository and helping contributors better phrase their commit messages. Adam Wolf On Tue, May 1, 2018, 5:04

[Kicad-developers] A reminder on Git commit comments

2018-05-01 Thread Reece R. Pollack
I'd like to make an observation on some of the Git commit comments I'm reading. Some of these commit log entries are really unhelpful. When I was at University many, many years ago, students were taught to place comments in their code. Many misunderstood the purpose of comments, though, and