Re: [Kicad-developers] Additional parameters on simulation dialog

Hi Sylwester, On 8/18/19 5:15 PM, Sylwester Kocjan wrote: > Hi Wayne & KiCad devs, > > Apologies for previous message, wrong formatting made it unreadable. > Let me repeat: > > I made some progress with simulation changes (see the attached patch). > I fixed your findings (hopefully this is what

Re: [Kicad-developers] Additional parameters on simulation dialog

Never mind, gmail apparently is too smart for it's own good. It moved the second email into my spam folder. Sorry for the noise. On 8/19/19 9:19 AM, Nick Østergaard wrote: > In his second email that is. > > man. 19. aug. 2019 15.19 skrev Nick Østergaard >: > > I

Re: [Kicad-developers] Additional parameters on simulation dialog

In his second email that is. man. 19. aug. 2019 15.19 skrev Nick Østergaard : > I can see the attachment in my email client (gmail android app). > > man. 19. aug. 2019 15.03 skrev Wayne Stambaugh : > >> Sylwester, >> >> Either your patch was removed by the launchpad moderation system or you >> fo

Re: [Kicad-developers] Additional parameters on simulation dialog

I can see the attachment in my email client (gmail android app). man. 19. aug. 2019 15.03 skrev Wayne Stambaugh : > Sylwester, > > Either your patch was removed by the launchpad moderation system or you > forgot to attach it. > > Cheers, > > Wayne > > On 8/18/19 4:11 PM, Sylwester Kocjan wrote: >

Re: [Kicad-developers] Additional parameters on simulation dialog

Sylwester, Either your patch was removed by the launchpad moderation system or you forgot to attach it. Cheers, Wayne On 8/18/19 4:11 PM, Sylwester Kocjan wrote: > Hi Wayne & KiCad devs, I made some progress with simulation changes > (see the attached patch). I fixed your findings (hopefully

Re: [Kicad-developers] Additional parameters on simulation dialog

Hi Wayne & KiCad devs, I made some progress with simulation changes (see the attached patch). I fixed your findings (hopefully this is what you intended) and made further changes. Currently it is possible to set initial condition for capacitors and inductors in DIALOG_SPICE_MODEL.At the s

Re: [Kicad-developers] Additional parameters on simulation dialog

Hi Sylwester, I took a look at your repo and I have a few comments on your changes. I did not test it so there may be functional issues as well. Please simplify your logic in DIALOG_SIM_SETTINGS::TransferDataToWindow(). It's way more complicated than it needs to be. Get rid of DIALOG_SIM_SETTI

Re: [Kicad-developers] Additional parameters on simulation dialog

Hi Sylwester- On 2019-06-23 16:27, Sylwester Kocjan wrote: In KiCad's codebase, \n is standard. But we don't really worry (...) I think we have misunderstanding here. I was wondering not about Windows/Unix line endings in source files, but rather line endings used in string literals in KiCad so

Re: [Kicad-developers] Additional parameters on simulation dialog

Sylwester - On Sun, Jun 23, 2019 at 10:27:31PM +0200, Sylwester Kocjan wrote: > I was wondering not about > Windows/Unix line endings in source files, but rather line endings used > in string literals in KiCad source code, for example: > [...] > Maybe they should be unified somehow? Maybe relate

Re: [Kicad-developers] Additional parameters on simulation dialog

Thanks Seth, > tabs being used instead of spaces and two blank lines between > functions in .cpp files. It looks like retval in > DIALOG_SIM_SETTINGS::TransferDataToWindow() isn't getting initialized > properly. Fixed in commit: e87ee2624892ad51e95cd9b8206e8d408de46939 > Are the "," replacements

Re: [Kicad-developers] Additional parameters on simulation dialog

On 2019-06-21 15:00, Sylwester Kocjan wrote: Hi, I prepared some changes in KiCad simulation dialog. They are about additional simulation parameters. According to tutorial, which I've found on website, I store them on GitHub repository in branch "Sim_InitialConditions_SK" here: https://github.c

[Kicad-developers] Additional parameters on simulation dialog

Hi, I prepared some changes in KiCad simulation dialog. They are about additional simulation parameters. According to tutorial, which I've found on website, I store them on GitHub repository in branch "Sim_InitialConditions_SK" here: https://github.com/skocjan/kicad_initialconditions.git Could y