Re: [Kicad-developers] CPolyLine refactor

2016-11-29 Thread Alejandro Garcia Montoro
> > Because we need mainly a class to store a polygon with holes (to replace > CPolyLine) improving > iterators and functions, especially to handle the first outline with holes > can be an option. > This was my only concern, CPolyLine is a single polygon with holes and we have no other class with

Re: [Kicad-developers] CPolyLine refactor

2016-11-29 Thread jp charras
Le 28/11/2016 à 15:37, Tomasz Wlostowski a écrit : > On 23.11.2016 15:02, jp charras wrote: >> Le 23/11/2016 à 13:32, Alejandro Garcia Montoro a écrit : >>> Hi! >>> >>> Thanks for the tips :) >>> >>> I have some more doubts, one of them quite important: we have a class for >>> storing a set of

Re: [Kicad-developers] CPolyLine refactor

2016-11-28 Thread Tomasz Wlostowski
On 23.11.2016 15:02, jp charras wrote: > Le 23/11/2016 à 13:32, Alejandro Garcia Montoro a écrit : >> Hi! >> >> Thanks for the tips :) >> >> I have some more doubts, one of them quite important: we have a class for >> storing a set of polygons >> with holes, SHAPE_POLY_SET, but there is no

Re: [Kicad-developers] CPolyLine refactor

2016-11-23 Thread jp charras
Le 23/11/2016 à 13:32, Alejandro Garcia Montoro a écrit : > Hi! > > Thanks for the tips :) > > I have some more doubts, one of them quite important: we have a class for > storing a set of polygons > with holes, SHAPE_POLY_SET, but there is no explicit class to store a single > polygon with

Re: [Kicad-developers] CPolyLine refactor

2016-11-23 Thread Alejandro Garcia Montoro
Hi! Thanks for the tips :) I have some more doubts, one of them quite important: we have a class for storing a set of polygons with holes, SHAPE_POLY_SET, but there is no explicit class to store a single polygon with holes. There's a POLYGON typedef that could do the trick, but I think it would

Re: [Kicad-developers] CPolyLine refactor

2016-11-21 Thread jp charras
Le 21/11/2016 à 18:07, Tomasz Wlostowski a écrit : > On 21.11.2016 13:56, Alejandro Garcia Montoro wrote: >> Hi! >> >> I'm working on the CPolyLine refactor into SHAPE_POLY_SET. Before coding >> anything more, I want to discuss with you the changes I have to do, just >> to be sure I'm not doing

Re: [Kicad-developers] CPolyLine refactor

2016-11-21 Thread Tomasz Wlostowski
On 21.11.2016 13:56, Alejandro Garcia Montoro wrote: > Hi! > > I'm working on the CPolyLine refactor into SHAPE_POLY_SET. Before coding > anything more, I want to discuss with you the changes I have to do, just > to be sure I'm not doing any useless work. > > The classes that use CPolyLine, and

[Kicad-developers] CPolyLine refactor

2016-11-21 Thread Alejandro Garcia Montoro
Hi! I'm working on the CPolyLine refactor into SHAPE_POLY_SET. Before coding anything more, I want to discuss with you the changes I have to do, just to be sure I'm not doing any useless work. The classes that use CPolyLine, and that have to be modified, are: - ZONE_CONTAINER: This class has