Re: [Kicad-developers] Coding Style Guide

2010-09-15 Thread Dick Hollenbeck
On 09/15/2010 06:02 PM, Wayne Stambaugh wrote: > I'm > comfortable with committing to the testing branch as it is. If we need > to add any other clarifications, we can revise it as they arise. Should > we put a note about it in the "Getting Started" FAQ? > > Thanks for finishing this up. Hopeful

Re: [Kicad-developers] Coding Style Guide

2010-09-15 Thread Wayne Stambaugh
On 9/13/2010 12:42 AM, Dick Hollenbeck wrote: > Attached is the document that Wayne and I have put together, first > public draft. It looks good to me. I especially like the tip you added about using GCC to make sure your header files will compile cleanly. I'm comfortable with committing to the

Re: [Kicad-developers] Coding Style Guide

2010-09-13 Thread Alex G
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 > I will add do not use 'this->'. > > I would not have thought it to be a problem until I just now grepped for it: > > $ grep -R 'this->' . > > and see it is seeping in from folks that have not lived long enough in > the C++ world yet. > Seven years

Re: [Kicad-developers] Coding Style Guide

2010-09-13 Thread Dick Hollenbeck
On 09/13/2010 08:52 AM, Alex G wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > > >>> Thanks! One particular item of interest to me is that I wasn't able >>> gauge is the use of "this->" to explicitly state that the variable is a >>> member of the object. Is this acceptable? >>> >

Re: [Kicad-developers] Coding Style Guide

2010-09-13 Thread Alex G
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 >> Thanks! One particular item of interest to me is that I wasn't able >> gauge is the use of "this->" to explicitly state that the variable is a >> member of the object. Is this acceptable? >> > > No. This is not really C++. What you talk about

Re: [Kicad-developers] Coding Style Guide

2010-09-13 Thread Dick Hollenbeck
On 09/13/2010 04:17 AM, Alex G wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA1 > > On 09/13/2010 08:09 AM, Dick Hollenbeck wrote: > >> On 09/12/2010 11:42 PM, Dick Hollenbeck wrote: >> >>> Attached is the document that Wayne and I have put together, first >>> public draft. >>> >>>

Re: [Kicad-developers] Coding Style Guide

2010-09-13 Thread Lorenzo Marcantonio
On Mon, 13 Sep 2010, Alex G wrote: Thanks! One particular item of interest to me is that I wasn't able gauge is the use of "this->" to explicitly state that the variable is a member of the object. Is this acceptable? It's considered bad form everywhere, except for inheritance related work (whe

Re: [Kicad-developers] Coding Style Guide

2010-09-13 Thread Alex G
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 09/13/2010 08:09 AM, Dick Hollenbeck wrote: > On 09/12/2010 11:42 PM, Dick Hollenbeck wrote: >> Attached is the document that Wayne and I have put together, first >> public draft. >> >> There should be hyperlinks from the PDF table of contents, but