The short answer is a lot. I know the OS will clean up allocated memory
on application close but this lackadaisical attitude is not good
programming practice. Chances are if you are not concerned about
cleaning up memory on application close, then you are probably not very
concerned about memory
Hi,
FWIW, I've been running the tests with memory checking enabled on both
Linux and Windows (MSVC), and we have several leaks there already, some
from us, some from wxWidgets, some from Gtk, some from Python, and
apparently some from Boost.Test. I don't exactly trust DrMemory yet, it
seems to
I would prefer a single MR for each leak just in case we need to revert
something that gets broken. I'm fine with grouping related leaks in a
single MR. There is no need to file an issue report.
On 5/29/20 10:51 AM, Johannes Pfister wrote:
> At least one leak is not in this issues. I made a MR
> If the memory is allocated at startup and doesn't grow in size, I
> wouldn't be too worried about not freeing it at shutdown.
But removing them can help remove real leaks since the output of
valgrind / ASan will be shorter and therefore clearer.
Am Fr., 29. Mai 2020 um 14:33 Uhr schrieb Andrew
At least one leak is not in this issues. I made a MR for the one i
found https://gitlab.com/kicad/code/kicad/-/merge_requests/231
Question, when i see multiple ones but have only fixed one of them,
while the others will take a few days, should i make a MR for each one
of them or is it better to
There are quite a few leaks in the code at present, and every now and then
I go through and try to plug some of them (but I don't find all of them,
that is for sure). My suggestion is that you can either propose a patch in
a merge request if you think you know where the memory should be freed and
If the memory is allocated at startup and doesn't grow in size, I
wouldn't be too worried about not freeing it at shutdown.
True leaks (growing in size over time) are a major problem. I routinely
leave kicad instances open for weeks or months while working on large
projects.
On 5/29/20 7:22 AM,
We should not be leaking memory in either case and we should care about it.
Which plot window are you are you talking about?
On 5/29/20 10:22 AM, Johannes Pfister wrote:
> As an example, if opening and closing the plot window would leak 3 kB
> each time, would we care about that? And is it
As an example, if opening and closing the plot window would leak 3 kB
each time, would we care about that? And is it justified to increase
code complexity to avoid this leak?
If yes, what about "leaks" that alloc memory only once, use the same
memory till the application is closed and don't free
9 matches
Mail list logo
