Re: [Kicad-developers] Inserting new pins based on pin orientation in eeschema

2015-04-22 Thread jp charras
Le 22/04/2015 14:02, Ed Johns a écrit : > JP and Simon, thanks for your feedback. It was late when I sent the email > and I didn't trust myself to refactor. I just updated the calculation. :) > > JP, > > Good point about making sure the update is consistent with the library > standards. If the

Re: [Kicad-developers] Inserting new pins based on pin orientation in eeschema

2015-04-22 Thread Ed Johns
JP and Simon, thanks for your feedback. It was late when I sent the email and I didn't trust myself to refactor. I just updated the calculation. :) JP, Good point about making sure the update is consistent with the library standards. If the user is using the default grid and default text height

Re: [Kicad-developers] Inserting new pins based on pin orientation in eeschema

2015-04-22 Thread jp charras
Le 22/04/2015 08:42, Simon Richter a écrit : > Hi, > > On 22.04.2015 08:25, jp charras wrote: > >> https://github.com/KiCad/kicad-library/blob/master/KiCad_Library_Convent >> >> ion.txt > >> Automatic insertion of pins have to comply with that. > > Good point. Would it make sense to leave this

Re: [Kicad-developers] Inserting new pins based on pin orientation in eeschema

2015-04-21 Thread Simon Richter
Hi, On 22.04.2015 08:25, jp charras wrote: > https://github.com/KiCad/kicad-library/blob/master/KiCad_Library_Convent > ion.txt > Automatic insertion of pins have to comply with that. Good point. Would it make sense to leave this to the user still, but somehow warn them (e.g. in the config dial

Re: [Kicad-developers] Inserting new pins based on pin orientation in eeschema

2015-04-21 Thread jp charras
Le 22/04/2015 05:05, Simon Richter a écrit : > Hi, > > On 22.04.2015 04:16, Ed Johns wrote: > >> I just re-implemented the calculations for pin offsets when >> inserting pins in the library editor in eeschema. They are no >> longer dependent on global settings. They are only dependent on >>

Re: [Kicad-developers] Inserting new pins based on pin orientation in eeschema

2015-04-21 Thread Simon Richter
Hi, On 22.04.2015 04:16, Ed Johns wrote: > I just re-implemented the calculations for pin offsets when inserting pins > in the library editor in eeschema. They are no longer dependent on global > settings. They are only dependent on the currently selected grid size and > the size of the text.

Re: [Kicad-developers] Inserting new pins based on pin orientation in eeschema

2015-04-21 Thread Ed Johns
I just re-implemented the calculations for pin offsets when inserting pins in the library editor in eeschema. They are no longer dependent on global settings. They are only dependent on the currently selected grid size and the size of the text. The direction of the offset is determined by the or

[Kicad-developers] Inserting new pins based on pin orientation in eeschema

2015-04-21 Thread Ed Johns
I just updated the eeschema code to insert new pins based on orientation. I have a few questions and wasn't able to find the answers in the code: 1. Where is the global variable g_RepeatStep set? It is used to determine horizontal and vertical step distances? 2. Am I using this global as it is i