Re: [Kicad-developers] MacOS build issue with new geometry tests

Hi John, Thanks for the patch. I have had the same problem compiling KiCad with clang and I confirm that the proposed fix solves the problem, so I merged it. Cheers, Orson On 07/29/2018 05:34 PM, John Beard wrote: > Hi Adam, > > Sorry, this in my stuff - I though that was a way to get PI

Re: [Kicad-developers] MacOS build issue with new geometry tests

Hi, it’s not constexpr that breaks clang. Usage of floating point isn’t valid in a constexpr (only literals allowed, floating point isn’t a literal)… https://en.cppreference.com/w/cpp/language/constexpr Regards, Bernhard > On 29. Jul

Re: [Kicad-developers] MacOS build issue with new geometry tests

Hi Adam, Sorry, this in my stuff - I though that was a way to get PI without having to guess the setting of _USE_MATH_DEFINES or do #ifdefs like at the top of dl_codes.h, but obviously not. The attached patch might work, but I can't test on a Mac, so all I can say is "it builds for me and the

[Kicad-developers] MacOS build issue with new geometry tests

Hi folks! There's a build failure on the new geometry test stuff with MacOS. qa/geometry/geom_test_utils.h:33:18: error: constexpr variable 'PI' must be initialized by a constant expression constexpr double PI = atan(1.0) * 4.0; ^ ~~~ qa/geometry/geom_test_utils.h:33:23: note: