[Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-07-26 Thread jp charras
Hi, GAL gurus, I wrote this fix that add the code to draw bitmaps that can be used in page layout editor and eeschema. (Currently, this code is missing, and bitmaps used in page layout are shown in legacy canvas, but not in GAL canvases) I need a GAL guru to verify this patch (I am not a OpenGL

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-07-26 Thread Tiger12506
I know nothing about kicad's GAL, but I'd use one rectangle and give it a texture that is the bitmap. It's been too long since I've messed with it for me to provide an example, but maybe something like this page would help? https://open.gl/textures On 7/26/2018 5:46 AM, jp charras wrote: Hi,

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-07-26 Thread Mário Luzeiro
o GPU textures. I believe the GAL specialists will have a good understanding how to add that feature. Mário Luzeiro From: Kicad-developers on behalf of jp charras Sent: 26 July 2018 10:46:33 To: Kicad Developers Subject: [Kicad-developers] Patch to dra

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-07-27 Thread jp charras
I believe the GAL specialists will have a good understanding how to add that > feature. Yes, I think so.. > > Mário Luzeiro Thanks. > > > From: Kicad-developers > on behalf of > jp charras > Sent: 26 July 2018 10:46:3

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-07-27 Thread Tomasz Wlostowski
On 27/07/18 13:28, jp charras wrote: > Le 26/07/2018 à 18:13, Mário Luzeiro a écrit : >> Hi JP, >> Don't know about CAIRO, but a "for xy DrawRectangle" it is too heavy. > > In fact "for xy DrawRectangle" is used only to convert the wxWidgets internal > image format to the > Cairo internal image f

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-07-27 Thread jp charras
Le 27/07/2018 à 15:20, Tomasz Wlostowski a écrit : > On 27/07/18 13:28, jp charras wrote: >> Le 26/07/2018 à 18:13, Mário Luzeiro a écrit : >>> Hi JP, >>> Don't know about CAIRO, but a "for xy DrawRectangle" it is too heavy. >> >> In fact "for xy DrawRectangle" is used only to convert the wxWidgets

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-07-29 Thread Tomasz Wlostowski
On 27/07/18 15:31, jp charras wrote: > Le 27/07/2018 à 15:20, Tomasz Wlostowski a écrit : >> On 27/07/18 13:28, jp charras wrote: >>> Le 26/07/2018 à 18:13, Mário Luzeiro a écrit : Hi JP, Don't know about CAIRO, but a "for xy DrawRectangle" it is too heavy. >>> >>> In fact "for xy DrawRec

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-07-30 Thread jp charras
Le 30/07/2018 à 00:29, Tomasz Wlostowski a écrit : > On 27/07/18 15:31, jp charras wrote: >> Le 27/07/2018 à 15:20, Tomasz Wlostowski a écrit : >> > Hi again, > > I've optimized the OpenGL bitmap drawing code (now it caches the bitmaps > and uses textures to draw them). Both mine and your patch ar

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-07-30 Thread Tomasz Wlostowski
On 30/07/18 11:14, jp charras wrote: > Le 30/07/2018 à 00:29, Tomasz Wlostowski a écrit : >> On 27/07/18 15:31, jp charras wrote: >>> Le 27/07/2018 à 15:20, Tomasz Wlostowski a écrit : >>> >> Hi again, >> >> I've optimized the OpenGL bitmap drawing code (now it caches the bitmaps >> and uses textur

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-10-06 Thread Seth Hillbrand
Hi All- It looks like the bitmap GAL function did not get cherry-picked into 5.0.1. Was this intentional? -S ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.ne

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-10-06 Thread Wayne Stambaugh
IFAIR, this was done to get some testing because it was a fairly large change. I'm fine with cherry-picking this for 5.0.1 since there have not been any bug reports filed on it recently. On 10/06/2018 09:24 AM, Seth Hillbrand wrote: > Hi All- > > It looks like the bitmap GAL function did not get

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-10-06 Thread jp charras
Le 06/10/2018 à 15:24, Seth Hillbrand a écrit : > Hi All- > > It looks like the bitmap GAL function did not get cherry-picked into > 5.0.1.  Was this intentional? > > -S It was intentional when I committed my work because: - The opengl code was not good. Thanks to Tomasz to fix it. - the code ne

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-10-06 Thread Seth Hillbrand
Am Sa., 6. Okt. 2018 um 06:58 Uhr schrieb jp charras : > Le 06/10/2018 à 15:24, Seth Hillbrand a écrit : > > Hi All- > > > > It looks like the bitmap GAL function did not get cherry-picked into > > 5.0.1. Was this intentional? > > > > -S > > It was intentional when I committed my work because: >

Re: [Kicad-developers] Patch to draw bitmaps in GAL canvases

2018-10-06 Thread jp charras
Le 06/10/2018 à 16:00, Seth Hillbrand a écrit : > > > Am Sa., 6. Okt. 2018 um 06:58 Uhr schrieb jp charras > mailto:jp.char...@wanadoo.fr>>: > > Le 06/10/2018 à 15:24, Seth Hillbrand a écrit : > > Hi All- > > > > It looks like the bitmap GAL function did not get cherry-picked int