Re: [Kicad-developers] Question about const SHAPE_LINE_CHAIN Outline() const

2016-04-06 Thread jp charras
Le 06/04/2016 11:59, Tomasz Wlostowski a écrit : > On 04.04.2016 14:15, Maciej Sumiński wrote: >> On 04/04/2016 01:39 PM, jp charras wrote: >>> Sorry if you already sent me a response to this "old" message (first posted >>> on feb 05) >>> but I did not remember this response. > > Hi Jean-Pierre,

Re: [Kicad-developers] Question about const SHAPE_LINE_CHAIN Outline() const

2016-04-06 Thread Tomasz Wlostowski
On 04.04.2016 14:15, Maciej Sumiński wrote: > On 04/04/2016 01:39 PM, jp charras wrote: >> Sorry if you already sent me a response to this "old" message (first posted >> on feb 05) >> but I did not remember this response. Hi Jean-Pierre, If you mean this code in your patch:

Re: [Kicad-developers] Question about const SHAPE_LINE_CHAIN Outline() const

2016-04-04 Thread Maciej Sumiński
On 04/04/2016 01:39 PM, jp charras wrote: > Sorry if you already sent me a response to this "old" message (first posted > on feb 05) > but I did not remember this response. > > It is annoying for the rounded rect pads which use this method. > (I currently use a fixed (modified) version in my

[Kicad-developers] Question about const SHAPE_LINE_CHAIN Outline() const

2016-04-04 Thread jp charras
Sorry if you already sent me a response to this "old" message (first posted on feb 05) but I did not remember this response. It is annoying for the rounded rect pads which use this method. (I currently use a fixed (modified) version in my patch) I can easily fix it, but I do not want to create

[Kicad-developers] Question about const SHAPE_LINE_CHAIN Outline() const

2016-02-05 Thread jp charras
Orson, Tomasz, I am thinking there is a bug in geometry/shape_rect.h: In const SHAPE_LINE_CHAIN Outline() const m_h and m_w look like they are swapped in calculations, and the outline is incorrect (assuming m_w is the X axis rect size (width), and m_h is the Y axis rect size (height)). Can you