Re: [Kicad-developers] Questionably useful code

2016-03-11 Thread Sergey Borshch
On 12.03.2016 05:20, Carl Poirier wrote: Sooo: - If the size is not specified, then assume it is 60mils - From now on, default size is 50mils (as per KLC) - From now on, never omit the size (or specify it in a header) It would be great if developers add grid origin and user grid size to file he

Re: [Kicad-developers] Questionably useful code

2016-03-11 Thread Carl Poirier
Sooo: - If the size is not specified, then assume it is 60mils - From now on, default size is 50mils (as per KLC) - From now on, never omit the size (or specify it in a header) Then we have the backwards compatibility and contributors don't get caught by submitting pull requests using a 60mils si

Re: [Kicad-developers] Questionably useful code

2016-03-11 Thread Wayne Stambaugh
I'm not opposed to adding a global font definition but adding the default parameters for every single text definition would be unacceptable. I'm assuming you are going to include the font, weight, italics, orientation, etc. information to this as well as they all have default values which are curr

Re: [Kicad-developers] Questionably useful code

2016-03-11 Thread Adam Wolf
I hope we don't add more things like this in the future. Adding a header to the file with "default font size is 60 mils" or whatever, and setting omitted font size in the file to use the header value, would add only a few bytes over what the current is--except there wouldn't be a magic constant in

Re: [Kicad-developers] Questionably useful code

2016-03-11 Thread Wayne Stambaugh
On 3/11/2016 2:55 AM, jp charras wrote: > Le 11/03/2016 00:01, Jon Neal a écrit : >> Oh, I should add that to prevent breaking backwards compatibility the >> parser could just continue interpreting a missing size and thickness value >> with the current defaults hard coded there. > > No problem for

Re: [Kicad-developers] Questionably useful code

2016-03-11 Thread Sergey Borshch
On 11.03.2016 00:59, Jon Neal wrote: Hi, What I would like to request is that we remove the bit of code that omits text size and thickness if they are default. This increases file size by about 40ish chars/bytes. I think it is reasonable to still omit bold, italic, justification, and whether t

Re: [Kicad-developers] Questionably useful code

2016-03-10 Thread jp charras
Le 11/03/2016 00:01, Jon Neal a écrit : > Oh, I should add that to prevent breaking backwards compatibility the > parser could just continue interpreting a missing size and thickness value > with the current defaults hard coded there. No problem for me to always store the text font size, especiall

Re: [Kicad-developers] Questionably useful code

2016-03-10 Thread Chris Pavlina
I feel like emphasizing here that our attempt at saving file size doesn't actually do anything since we've changed defaults in our library standard anyway. :\ On Thu, Mar 10, 2016 at 11:01:32PM +, Jon Neal wrote: > Oh, I should add that to prevent breaking backwards compatibility the > parser

Re: [Kicad-developers] Questionably useful code

2016-03-10 Thread Jon Neal
Oh, I should add that to prevent breaking backwards compatibility the parser could just continue interpreting a missing size and thickness value with the current defaults hard coded there. On Thu, Mar 10, 2016 at 5:59 PM Jon Neal wrote: > Hi, > > I was looking in to helping the library team by c

[Kicad-developers] Questionably useful code

2016-03-10 Thread Jon Neal
Hi, I was looking in to helping the library team by changing the default kicad text size to 50 mils rather than the current 60 mils. Well, I discovered that the s-expr formatter and parser omits certain text settings if they are the default. I assume this is to make kicad files smaller which yay,