[Kicad-developers] Undo buffer refactor

2016-09-05 Thread Maciej Sumiński
Recently I was refactoring the undo buffer code [1], as I have mentioned sometime ago. The main goal was to make the code simpler and more generic, remove some redundant parts. Short changelog: - BOARD_COMMIT class. Wrapper around undo buffer to simplify storing changes. Also performs all the nec

Re: [Kicad-developers] Undo buffer refactor

2016-09-05 Thread Sergey Borshch
On 05.09.2016 17:06, Maciej Sumiński wrote: As you may have noticed, there are a lot of changes to the KiCad internals. It would be great if there were some brave folks to take the branch for a test ride. I'm unable to compile it: sources/pcb_calculator/attenuators/attenuator_classes.cpp:100:2

Re: [Kicad-developers] Undo buffer refactor

2016-09-05 Thread Maciej Sumiński
On 09/05/2016 11:34 PM, Sergey Borshch wrote: > On 05.09.2016 17:06, Maciej Sumiński wrote: >> As you may have noticed, there are a lot of changes to the KiCad >> internals. It would be great if there were some brave folks to take the >> branch for a test ride. > > I'm unable to compile it: > [sni

Re: [Kicad-developers] Undo buffer refactor

2016-09-05 Thread Wayne Stambaugh
On 9/5/2016 10:06 AM, Maciej Sumiński wrote: > Recently I was refactoring the undo buffer code [1], as I have mentioned > sometime ago. The main goal was to make the code simpler and more > generic, remove some redundant parts. > > Short changelog: > > - BOARD_COMMIT class. > Wrapper around undo

Re: [Kicad-developers] Undo buffer refactor

2016-09-06 Thread jp charras
Le 05/09/2016 à 23:34, Sergey Borshch a écrit : > On 05.09.2016 17:06, Maciej Sumiński wrote: >> As you may have noticed, there are a lot of changes to the KiCad >> internals. It would be great if there were some brave folks to take the >> branch for a test ride. > > I'm unable to compile it: > >

Re: [Kicad-developers] Undo buffer refactor

2016-09-06 Thread Sergey Borshch
On 06.09.2016 01:19, Maciej Sumiński wrote: On 09/05/2016 11:34 PM, Sergey Borshch wrote: On 05.09.2016 17:06, Maciej Sumiński wrote: As you may have noticed, there are a lot of changes to the KiCad internals. It would be great if there were some brave folks to take the branch for a test ride.

Re: [Kicad-developers] Undo buffer refactor

2016-09-07 Thread Wayne Stambaugh
Orson, I did some limited testing on this and it seems OK. The only thing I'm going to ask to wait until your going to be available in case things go sideways before you commit it. Thanks, Wayne On 9/5/2016 10:06 AM, Maciej Sumiński wrote: > Recently I was refactoring the undo buffer code [1],

Re: [Kicad-developers] Undo buffer refactor

2016-09-07 Thread Sergey Borshch
On 06.09.2016 11:45, jp charras wrote: Le 05/09/2016 à 23:34, Sergey Borshch a écrit : On 05.09.2016 17:06, Maciej Sumiński wrote: As you may have noticed, there are a lot of changes to the KiCad internals. It would be great if there were some brave folks to take the branch for a test ride. I