Re: [Kicad-developers] data in headers

2013-05-23 Thread Wayne Stambaugh
On 5/23/2013 10:04 AM, Dick Hollenbeck wrote: > On 05/23/2013 01:37 AM, jp charras wrote: >> Le 23/05/2013 04:08, Dick Hollenbeck a écrit : >>> On 05/22/2013 07:36 PM, Lorenzo Marcantonio wrote: On Wed, May 22, 2013 at 03:05:29PM -0500, Dick Hollenbeck wrote: > The more common practice is

Re: [Kicad-developers] data in headers

2013-05-23 Thread Dick Hollenbeck
On 05/23/2013 01:37 AM, jp charras wrote: > Le 23/05/2013 04:08, Dick Hollenbeck a écrit : >> On 05/22/2013 07:36 PM, Lorenzo Marcantonio wrote: >>> On Wed, May 22, 2013 at 03:05:29PM -0500, Dick Hollenbeck wrote: The more common practice is to use extern declarations in the header, and

Re: [Kicad-developers] data in headers

2013-05-22 Thread jp charras
Le 23/05/2013 04:08, Dick Hollenbeck a écrit : On 05/22/2013 07:36 PM, Lorenzo Marcantonio wrote: On Wed, May 22, 2013 at 03:05:29PM -0500, Dick Hollenbeck wrote: The more common practice is to use extern declarations in the header, and define the data in a *.cpp file. Why are you doing this

Re: [Kicad-developers] data in headers

2013-05-22 Thread Lorenzo Marcantonio
On Wed, May 22, 2013 at 09:08:35PM -0500, Dick Hollenbeck wrote: > IMO, data should not be defined in a header file. Completely agree. I was only suggesting a useful workaround for a common case. Another technique I like for big, one-file-only data is to declare them at the beginning and define t

Re: [Kicad-developers] data in headers

2013-05-22 Thread Lorenzo Marcantonio
On Wed, May 22, 2013 at 03:05:29PM -0500, Dick Hollenbeck wrote: > The more common practice is to use extern declarations in the header, and > define the data > in a *.cpp file. > > > Why are you doing this? *If* it's only used there, I think he simply wanted to put aside a big definition block

Re: [Kicad-developers] data in headers

2013-05-22 Thread Dick Hollenbeck
On 05/22/2013 03:05 PM, Dick Hollenbeck wrote: > > > > Ki_WorkSheetDataWS_Revision = > { > WS_REV, > &WS_SizeSheet, > BLOCK_REV_X, BLOCK_REV_Y, > 0, 0, > wxT( "Rev: " ),NULL > }; > > > > Jean-Pierre, > > > I noticed in title_block_shapes.h

[Kicad-developers] data in headers

2013-05-22 Thread Dick Hollenbeck
Ki_WorkSheetDataWS_Revision = { WS_REV, &WS_SizeSheet, BLOCK_REV_X, BLOCK_REV_Y, 0, 0, wxT( "Rev: " ),NULL }; Jean-Pierre, I noticed in title_block_shapes.h you have data definitions rather than declarations: http://www.cprogramming.co