Re: [Kicad-developers] knowing last commit included in a nightly build?

> On 10. Sep 2019, at 15:23, Wayne Stambaugh wrote: > > Adam, > > I took a look at this patch set and I have some concerns. The CMake > changes seem acceptable but I'm curious as to why you had to add all of > the python paths in pcbnew.cpp to get Python working under macos. Does > Python on

Re: [Kicad-developers] knowing last commit included in a nightly build?

Wayne, Thanks for taking a look. CMake's COPY_RESOLVED_BUNDLE... and COPY_DIRECTORY don't handle symlinks correctly, and I ended up having to do a lot of work modifying CMake stuff, doing a custom Python build, and a few helper scripts to make sure the proper rpaths stick around. All of these sh

Re: [Kicad-developers] knowing last commit included in a nightly build?

Adam, I took a look at this patch set and I have some concerns. The CMake changes seem acceptable but I'm curious as to why you had to add all of the python paths in pcbnew.cpp to get Python working under macos. Does Python on macos not look in the install path for library paths like it does on

Re: [Kicad-developers] knowing last commit included in a nightly build?

It would be awesome to have them merged into upstream. They're all very packaging specific. Here is the current list: * https://github.com/KiCad/kicad-mac-builder/tree/master/kicad-mac-builder/patches/kicad Adam Wolf On Thu, Sep 5, 2019 at 8:19 AM Jeff Young wrote: > > Yeah, it would be -rea

Re: [Kicad-developers] knowing last commit included in a nightly build?

Yeah, it would be -really- nice if we could fix this somehow. I’ve run into it many times. Cheers, Jeff. > On 5 Sep 2019, at 14:07, Jonatan Liljedahl wrote: > > On Thu, Sep 5, 2019 at 1:59 PM Nick Østergaard wrote: >> >> Does the sha listed in the version info from the runtime app not matc

Re: [Kicad-developers] knowing last commit included in a nightly build?

On Thu, Sep 5, 2019 at 1:59 PM Nick Østergaard wrote: > > Does the sha listed in the version info from the runtime app not match? Unfortunately not. For example (5.1.4-60-ga2950354a) lijon-mbp:kicad lijon$ git branch * 5.1 master lijon-mbp:kicad lijon$ git log --oneline | grep ga2950354a lijon

Re: [Kicad-developers] knowing last commit included in a nightly build?

Should (can?) these patches be merged into the source repo? I was caught of guard recently by this as well. I'm guessing this only affects macos builds. Wayne On 9/5/19 4:46 AM, Ian McInerney wrote: > I believe that OSX adds several patches to the build process still, so > the last few commits

Re: [Kicad-developers] knowing last commit included in a nightly build?

Does the sha listed in the version info from the runtime app not match? On Thu, 5 Sep 2019 at 12:49, Jonatan Liljedahl wrote: > > Oh, I see. So then how can I check if a commit is included or not in a > specific nightly 5.1 download? > > Cheers > > On Thu, Sep 5, 2019 at 10:47 AM Ian McInerney

Re: [Kicad-developers] knowing last commit included in a nightly build?

Oh, I see. So then how can I check if a commit is included or not in a specific nightly 5.1 download? Cheers On Thu, Sep 5, 2019 at 10:47 AM Ian McInerney wrote: > > I believe that OSX adds several patches to the build process still, so the > last few commits are OSX specific and the one being

Re: [Kicad-developers] knowing last commit included in a nightly build?

I believe that OSX adds several patches to the build process still, so the last few commits are OSX specific and the one being picked for the version string is probably one of this. Adam should be able to confirm this. -Ian On Thu, Sep 5, 2019 at 10:12 AM Jonatan Liljedahl wrote: > Hmm, weird.

Re: [Kicad-developers] knowing last commit included in a nightly build?

Hmm, weird. I'm looking at nightlies of the 5.1 branch for OSX. For example the latest: https://kicad-downloads.s3.cern.ch/osx/testing/5.1/kicad-5.1-nightly-20190904-112458-3d75100e0-10_14.dmg Looking at the hash (3d75100e0), this yields no results: $ git log --oneline | grep 3d75100e0 On Thu,

Re: [Kicad-developers] knowing last commit included in a nightly build?

Hello, What do you mean? The hex string in the file name is the prefix of the commit hash, common way to identify commits in git. E.g. latest nightly kicad-r14168.6688e8013-x86_64.exe is built from commit 6688e80

[Kicad-developers] knowing last commit included in a nightly build?

Hi list, Is there any way to see from which commit a nightly was built? The hex strings in the download files doesn't seem to be git refs. -- /Jonatan http://kymatica.com ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-dev