Re: [Kicad-developers] packages3d fix for OS X

2015-11-21 Thread Adam Wolf
The autobuilder packages tested fine this morning, so I just kicked off RC2-3, which'll close at least three OS X packaging bugs in Launchpad. Please disregard the patches in this thread, thanks! Adam Wolf Cofounder and Engineer W&L On Fri, Nov 20, 2015 at 9:29 PM, Adam Wolf wrote: > Initial t

Re: [Kicad-developers] packages3d fix for OS X

2015-11-20 Thread Adam Wolf
Initial tests seem to have the symlink method working. This is a fix that doesn't require any changes to KiCad, just my packaging scripts. The build is going through the autobuilder (but won't be uploaded), and I'll test that one over this weekend, and we can punt on this issue. It is annoying s

Re: [Kicad-developers] packages3d fix for OS X

2015-11-19 Thread Adam Wolf
Actually, Wayne, hold off on any of these patches, I may be able to fix this in the nightly/release packaging scripts with a symlink. I will keep in touch! Adam Wolf On Nov 19, 2015 1:59 PM, "Wayne Stambaugh" wrote: > None that wouldn't require a bunch of code changes which at this point > is a

Re: [Kicad-developers] packages3d fix for OS X

2015-11-19 Thread Adam Wolf
Hi folks, It is possible that I may be able to use symlinks to make this just work for everyone, and then it is just an packaging change in my nightlies and releases. I know I tried symlinks to do something else in the OS X KiCad stuff, and there are edge cases where they don't work when being pa

Re: [Kicad-developers] packages3d fix for OS X

2015-11-19 Thread Wayne Stambaugh
None that wouldn't require a bunch of code changes which at this point is a no go. I can commit your second patch that handles either install path for packages3d. This should work on new installs and folks who are brave enough to build and install from source on OSX. Any changes beyond that we s

Re: [Kicad-developers] packages3d fix for OS X

2015-11-19 Thread Adam Wolf
Do you have any ideas on how to make it work for the release? Adam Wolf On Thu, Nov 19, 2015, 12:18 PM Wayne Stambaugh wrote: > It sounds like this is going to break the existing behavior so I would > rather wait until after the stable release unless we can guarantee that > it will continue to

Re: [Kicad-developers] packages3d fix for OS X

2015-11-19 Thread Wayne Stambaugh
It sounds like this is going to break the existing behavior so I would rather wait until after the stable release unless we can guarantee that it will continue to work on existing installs. Moving forward, it probably makes more sense to install the 3D models along side the library and module path

Re: [Kicad-developers] packages3d fix for OS X

2015-11-19 Thread Adam Wolf
So originally, I mostly forgot that people do source builds on OS X. :) After thinking about it, I think we need both search paths in kiface_i, the new default in pgmbase, and the docs changed. All of these are in the patch on this list. Then we also could make the kicad-library repo put the pa

Re: [Kicad-developers] packages3d fix for OS X

2015-11-19 Thread Wayne Stambaugh
Adam, I forgot to ask, would this change be on top of your current patch or replace the current patch? Wayne On 11/18/2015 8:49 PM, Adam Wolf wrote: > Slick! Faster than I thought to make the change on a branch for > kicad-libraries. This would make it so new from-source builders on OS X > in

Re: [Kicad-developers] packages3d fix for OS X

2015-11-19 Thread Wayne Stambaugh
As long as you can verify that it works with both your package builds and source builds on OSX and doesn't break any other platforms, I'm OK with it. On 11/18/2015 8:49 PM, Adam Wolf wrote: > Slick! Faster than I thought to make the change on a branch for > kicad-libraries. This would make it so

Re: [Kicad-developers] packages3d fix for OS X

2015-11-18 Thread Adam Wolf
Slick! Faster than I thought to make the change on a branch for kicad-libraries. This would make it so new from-source builders on OS X install their packages3d to the same place as nightly and release users. If you think it's a good idea, I'll propose the 8 line patch to Carl and the rest of th

Re: [Kicad-developers] packages3d fix for OS X

2015-11-18 Thread Adam Wolf
Hi Wayne, Attached is the updated patch. Do you think I should also do a patch for the library group so from-source builders on OS X will match the nightlies? (I probably should have done this a long time ago actually!) Adam Wolf On Wed, Nov 18, 2015 at 6:31 PM, Adam Wolf wrote: > I can defi

Re: [Kicad-developers] packages3d fix for OS X

2015-11-18 Thread Adam Wolf
I can definitely add the extra search path in. It was only meant to impact new users without preferences already. Adam Wolf On Nov 18, 2015 6:01 PM, "Wayne Stambaugh" wrote: > Adam, > > Is this going to break anything for users who compile from source? It > looks as though it might. If so, yo

Re: [Kicad-developers] packages3d fix for OS X

2015-11-18 Thread Wayne Stambaugh
Adam, Is this going to break anything for users who compile from source? It looks as though it might. If so, you might want to have both paths in the search list just in case. AFAIK, the search path code removes all non-existent paths from the list. Wayne On 11/18/2015 3:57 PM, Adam Wolf wrot

Re: [Kicad-developers] packages3d fix for OS X

2015-11-18 Thread Adam Wolf
Hi Cirilo, This patch should just change the default packages3d (for new users who don't have preferences saved) to match what we're currently shipping. I will definitely look at your branch once 4.0.0 is released :) Adam Wolf On Wed, Nov 18, 2015, 5:44 PM Cirilo Bernardo wrote: > On Thu, Nov

Re: [Kicad-developers] packages3d fix for OS X

2015-11-18 Thread Cirilo Bernardo
On Thu, Nov 19, 2015 at 7:57 AM, Adam Wolf wrote: > Hi folks, > > I'm trying to wrap up all the OS X packaging related bugs ASAP before > 4.0.0 drops shortly. I got a nasty one where we weren't actually > supporting 10.8, but as of this morning I fixed that! (It wasn't a KiCad > code change.) >

[Kicad-developers] packages3d fix for OS X

2015-11-18 Thread Adam Wolf
Hi folks, I'm trying to wrap up all the OS X packaging related bugs ASAP before 4.0.0 drops shortly. I got a nasty one where we weren't actually supporting 10.8, but as of this morning I fixed that! (It wasn't a KiCad code change.) However! For OS X, we put packages3d next to modules, rather th