Re: [Kicad-developers] wxGrid boolean changes

Works great for me too, thanks Jeff! On Sat, Mar 24, 2018 at 9:49 AM, Jeff Young wrote: > Commit: > > Notify clients when GRID_TRICKS toggles checkboxes. > > 97fffe875fd9355505a20200bf24f038bf11df51 > > > On 24 Mar 2018, at 11:49, Jeff Young wrote: > > > >

Re: [Kicad-developers] wxGrid boolean changes

Le 24/03/2018 à 14:49, Jeff Young a écrit : > Commit: > > Notify clients when GRID_TRICKS toggles checkboxes. > > 97fffe875fd9355505a20200bf24f038bf11df51 > Looks good to me now. bool vars in wxGrid are much better now. Thanks. -- Jean-Pierre CHARRAS

Re: [Kicad-developers] wxGrid boolean changes

Commit: Notify clients when GRID_TRICKS toggles checkboxes. 97fffe875fd9355505a20200bf24f038bf11df51 > On 24 Mar 2018, at 11:49, Jeff Young wrote: > > Got it. Reproduces on Mac, so I can debug that…. > >> On 24 Mar 2018, at 11:40, jp charras

Re: [Kicad-developers] wxGrid boolean changes

Got it. Reproduces on Mac, so I can debug that…. > On 24 Mar 2018, at 11:40, jp charras wrote: > > Le 24/03/2018 à 12:23, Jeff Young a écrit : >> The Footprint Wizard parameter grid now uses GRID_TRICKS, so this line fixes >> updates there. >> > > No Jeff, it is not.

Re: [Kicad-developers] wxGrid boolean changes

Le 24/03/2018 à 12:23, Jeff Young a écrit : > The Footprint Wizard parameter grid now uses GRID_TRICKS, so this line fixes > updates there. > No Jeff, it is not. The user interface only is updated and this is not enough. The Footprint is not updated, and does not take in account the boolean

Re: [Kicad-developers] wxGrid boolean changes

The Footprint Wizard parameter grid now uses GRID_TRICKS, so this line fixes updates there. > On 24 Mar 2018, at 10:33, jp charras wrote: > > Le 24/03/2018 à 11:28, Jeff Young a écrit : >> GRID_TRICKS. (Or did you mean in git? >>

Re: [Kicad-developers] wxGrid boolean changes

Le 24/03/2018 à 11:28, Jeff Young a écrit : > GRID_TRICKS. (Or did you mean in git? > 5957bc7dbaf0c7f5db7d0a7680b273666b8e9316) OK, I saw that. But I was thinking you were talking about footprint wizards, that are not updated when changing a boolean. > >> On 24 Mar 2018, at 08:54, jp

Re: [Kicad-developers] wxGrid boolean changes

GRID_TRICKS. (Or did you mean in git? 5957bc7dbaf0c7f5db7d0a7680b273666b8e9316) > On 24 Mar 2018, at 08:54, jp charras wrote: > > Le 23/03/2018 à 17:15, Jeff Young a écrit : >> Hey guys, >> >> I merged a fix for the lack of update issue. A re-test would be appreciated

Re: [Kicad-developers] wxGrid boolean changes

Le 23/03/2018 à 17:15, Jeff Young a écrit : > Hey guys, > > I merged a fix for the lack of update issue. A re-test would be appreciated > when you have time (nothing urgent). > > Cheers, > Jeff. > Hi Jeff, Where is this fix? -- Jean-Pierre CHARRAS

Re: [Kicad-developers] wxGrid boolean changes

Hey guys, I merged a fix for the lack of update issue. A re-test would be appreciated when you have time (nothing urgent). Cheers, Jeff. > On 23 Mar 2018, at 15:36, jp charras wrote: > > On W7/32 bits I confirm the UI works fine, but the footprint wizard table >

Re: [Kicad-developers] wxGrid boolean changes

Yes, it looks like the code that actually updates the parameter wizard model was removed in a0364a113 On Fri, Mar 23, 2018 at 11:36 AM, jp charras wrote: > On W7/32 bits I confirm the UI works fine, but the footprint wizard table > does not update the > footprint when

Re: [Kicad-developers] wxGrid boolean changes

On W7/32 bits I confirm the UI works fine, but the footprint wizard table does not update the footprint when clicking on a boolean. The change is taken in account only when modifying an other parameter. (perhaps the grid event is not propagated to the wizard) -- Jean-Pierre CHARRAS

Re: [Kicad-developers] wxGrid boolean changes

The behavior is the same on windows. On 3/23/2018 9:38 AM, Wayne Stambaugh wrote: > The keyboard behavior seems to work just fine. I'll take a look at it > in windows in a few minutes and let you know if it there are any issues. > > On 03/23/2018 09:31 AM, Jeff Young wrote: >> Mac had the same

Re: [Kicad-developers] wxGrid boolean changes

Mac had the same behaviour with the keyboard (tab or return to the cell in question, and then hit spacebar). I’ll apply the same fix to click events, but if you could confirm that the keyboard behaviour works then I’ll be a step ahead of the game. > On 23 Mar 2018, at 13:10, Wayne Stambaugh

Re: [Kicad-developers] wxGrid boolean changes

The keyboard behavior seems to work just fine. I'll take a look at it in windows in a few minutes and let you know if it there are any issues. On 03/23/2018 09:31 AM, Jeff Young wrote: > Mac had the same behaviour with the keyboard (tab or return to the cell in > question, and then hit

Re: [Kicad-developers] wxGrid boolean changes

Hi Jeff, This version works great in the library tables, but breaks the footprint wizard table (it's no longer possible to check/uncheck booleans using mouse or keyboard). Unfortunately I don't have time to debug tonight, but can try tomorrow unless you have an idea of what is wrong. By the way,

Re: [Kicad-developers] wxGrid boolean changes

OK, guys, here’s a modified-Jon-solution in GRID_TRICKS. Note that I can’t seem to build with Python on my Mac so the Footprint Wizard is totally untested (although it has, in theory, been updated to use GRID_TRICKS). Please let me know how it looks…. Cheers, Jeff.

Re: [Kicad-developers] wxGrid boolean changes

My change was in GRID_TRICKS, but doesn’t work very well. Jon’s was only in the Footprint Wizard, but seems to work better. I’m currently moving Jon’s to GRID_TRICKS. > On 21 Mar 2018, at 21:48, Wayne Stambaugh wrote: > > Does the footprint wizard use GRID_TRICKS? In

Re: [Kicad-developers] wxGrid boolean changes

Does the footprint wizard use GRID_TRICKS? In either case, we should roll these changes into GRID_TRICKS so it can be used everywhere we us boolean checkboxes in wxGrid. On 03/21/2018 05:38 PM, Jon Evans wrote: It's already committed, if you use the footprint wizard, any of the boolean

Re: [Kicad-developers] wxGrid boolean changes

It's already committed, if you use the footprint wizard, any of the boolean values in the parameters table use the new behavior On Wed, Mar 21, 2018 at 5:31 PM, Wayne Stambaugh wrote: > Jeff, > > I don't remember the outcome testing Jon's patch. That was a few weeks > ago

Re: [Kicad-developers] wxGrid boolean changes

Jeff, I don't remember the outcome testing Jon's patch. That was a few weeks ago so my old man memory is at work here. I don't have that patch any longer so if Jon reposts it, I will test it on windows. Cheers, Wayne On 03/21/2018 05:07 PM, Jeff Young wrote: Hi Wayne, That sounds

Re: [Kicad-developers] wxGrid boolean changes

Cool; I’ll stick it into GRID_TRICKS and test it on Mac. > On 21 Mar 2018, at 21:15, Jon Evans wrote: > > I tested my change (to the footprint wizard parameters table) on Windows and > didn't see any bad behavior. > > On Wed, Mar 21, 2018 at 5:07 PM, Jeff Young

Re: [Kicad-developers] wxGrid boolean changes

I tested my change (to the footprint wizard parameters table) on Windows and didn't see any bad behavior. On Wed, Mar 21, 2018 at 5:07 PM, Jeff Young wrote: > Hi Wayne, > > That sounds pretty similar to the bad behaviour I was trying to fix on > Linux, so I’m guessing it’ll be

Re: [Kicad-developers] wxGrid boolean changes

Hi Wayne, That sounds pretty similar to the bad behaviour I was trying to fix on Linux, so I’m guessing it’ll be the same. The native control on Mac does a fade-in when checked or unchecked, which I was trying to retain. But it looks like we’ll have to go with something more like Jon’s idea

Re: [Kicad-developers] wxGrid boolean changes

Jeff, This doesn't work on windows. The first click works as expected where is selects the row and checks the checkbox. The subsequent click selects the row and the next click behaves like two consecutive clicks which leave the checkbox in it's original state. I will try to test this on linux

Re: [Kicad-developers] wxGrid boolean changes

Oops, scratch that last one (it doesn’t even compile).Let’s try again: 0003-Don-t-make-users-click-twice-to-toggle-a-wxGrid-chec.patch Description: Binary data On 21 Mar 2018, at 10:59, Jeff Young wrote:Hi Jon,Could you try this one out on Linux?  (It should be active for the

Re: [Kicad-developers] wxGrid boolean changes

Hi Jon,Could you try this one out on Linux?  (It should be active for the library tables, but not the footprint wizard.)Thanks,Jeff. 0003-Don-t-make-users-click-twice-to-toggle-a-wxGrid-chec.patch Description: Binary data On 20 Mar 2018, at 13:49, Jon Evans wrote:I haven't

Re: [Kicad-developers] wxGrid boolean changes

I haven't started on it yet, feel free to do so if you want and have time. On Tue, Mar 20, 2018, 09:48 Jeff Young wrote: > Hi Jon, > > Do you want me to take this up, or are you working on it? > > Cheers, > Jeff. > > > On 15 Mar 2018, at 12:20, Jon Evans

Re: [Kicad-developers] wxGrid boolean changes

Hi Jon, Do you want me to take this up, or are you working on it? Cheers, Jeff. > On 15 Mar 2018, at 12:20, Jon Evans wrote: > > Yes, you'd need python scripting turned on. > > I will try to make a version that applies to the library tables for testing. > > -Jon > >

Re: [Kicad-developers] wxGrid boolean changes

Yes, you'd need python scripting turned on. I will try to make a version that applies to the library tables for testing. -Jon On Thu, Mar 15, 2018, 07:32 Jeff Young wrote: > I tried to test out your version, Jon, but I don’t have a Footprint > Wizard. (Is that because I have

Re: [Kicad-developers] wxGrid boolean changes

I tried to test out your version, Jon, but I don’t have a Footprint Wizard. (Is that because I have scripting turned off?) > On 15 Mar 2018, at 01:16, Jon Evans wrote: > > I gave it a try and there is some strange behavior on Linux :-( > Clicks on the checkboxes seem to

Re: [Kicad-developers] wxGrid boolean changes

I gave it a try and there is some strange behavior on Linux :-( Clicks on the checkboxes seem to sometimes get handled twice so the box quickly toggles between states. So, I don't think it should be merged as-is. Can you guys confirm that the behavior is good from my version (as implemented in

Re: [Kicad-developers] wxGrid boolean changes

Yep, only tested on OSX.Patch attached.Cheers,Jeff. 0019-Don-t-make-users-click-twice-on-wxGrid-checkboxes.patch Description: Binary data On 14 Mar 2018, at 19:56, Wayne Stambaugh wrote:I'm assuming you only tested this on macos correct?  If so, pleasesubmit a patch so we

Re: [Kicad-developers] wxGrid boolean changes

@Wayne, any opinion on this one? Should I merge it or play it safe and leave it in 6.0? > On 14 Mar 2018, at 14:12, Jeff Young wrote: > > IIRC, it was tricky to get right because you can’t fire it when the cell > *does* have focus or wxWidgets gets itself tied in knots.

Re: [Kicad-developers] wxGrid boolean changes

IIRC, it was tricky to get right because you can’t fire it when the cell *does* have focus or wxWidgets gets itself tied in knots. (It turns out that’s OK because when it does have focus wxWidgets toggles it with a single-click anyway.) It was also a bit tricky around reference counting. The

Re: [Kicad-developers] wxGrid boolean changes

Thanks Jeff, it doesn't look like that big a change but if you think it should wait I don't feel strongly, except that it might make maintenance more annoying if we have one implementation in 5.0 and one in 6.0. Anyone else have opinions on this? I think (2) should be added to Jeff's

Re: [Kicad-developers] wxGrid boolean changes

Hi Jon, I implemented (1), (3) and (4) in 6.0. It was tweaky enough that I don’t recommend it for 5.0 (but I don’t fee strongly). You can see my implementation here: https://git.launchpad.net/~jeyjey/kicad/commit/?h=6.0=7dda85fdae21f162bd7413fdceb16e49698f31bf

[Kicad-developers] wxGrid boolean changes

Hi all, I recently (2f86b497) changed the behavior of the wxGrid in the footprint wizard dialog to fix some issues with boolean (checkbox) parameters. The default behavior from wxWidgets (at least in 3.0) is buggy in that the update events don't get sent out when you'd expect from the