Hi tom!
I took a look at your branch and your changes are a lot more smooth than
mine, I went back to your implementation and added the net propagation
stuff, they did indeed crash kicad when copying between different PCBs.
How should I submit this patch to you?
Also, I think that we should
Unfortunately I cannot test this at work. But I took a look at the diff
between what I had made in the and your additions.
Are you no longer using the pi.Load() function to append the items from
the clipboard? From where I am looking it looks this way. This is good.
Same thing I did in my bran
On 25.09.2017 10:03, Kristoffer Ödmark wrote:
> Maybe I could get access to the work you have done and cherry pick
> patches from there, or just test it and see the difference?
Hi,
Sorry, I totally forgot to send you the link:
https://github.com/twlostow/kicad-dev/tree/tom-copypasta
Tom
>
> -
On 09/25/2017 12:21 AM, Tomasz Wlostowski wrote:
Hi Kristoffer,
I've had some time to work on your code during the past few days (I
wasn't aware you're still improving it). I fixed the crashes, refactored
placement of pasted items, fixed the zone refill issue, added snapping
to item's anchors a
On 24.09.2017 19:44, Kristoffer Ödmark wrote:
> I just pushed a larger change for this patch. Before the items was
> always added to the board on paste, even if the user aborted the action.
> This resulted in duplicate items stuck on the board since they were
> pasted directly to the same position,
Thank you Tomasz!
That was most likely the error, I cannot reproduce the crash after
fixing so that I do not modify the existing board!
I updated the branch, now bed for me!
- Kristofffer
On 09/18/2017 11:54 PM, Tomasz Wlostowski wrote:
On 18.09.2017 22:37, Kristoffer Ödmark wrote:
I have
On 18.09.2017 22:37, Kristoffer Ödmark wrote:
> I have made almost no changes as of yet. Just trying to figure out what
> causes the crash.
Hi,
Looking at kicad_clipboard.cpp:
// only a module selected.
if( aSelected.Size() == 1 && aSelected.Front()->Type() == PCB_MODULE_T )
{
//
I have made almost no changes as of yet. Just trying to figure out what
causes the crash.
I noticed in pcbnew/tools/edit_tool.cpp cutToClipboard that the method
does not cause a crash If i only run on of the two method calls in it.
Doesnt matter which one I remove, I also noticed that the cras
On 18.09.2017 21:18, Kristoffer Ödmark wrote:
> I cannot reproduce the crash on copying, I can however crash it on the
> Cut functionality, I am at a total loss as to why though.
>
> I noticed that the crash does not happen if one hides the board
> ratsnest, but it will later crash when trying to
I cannot reproduce the crash on copying, I can however crash it on the
Cut functionality, I am at a total loss as to why though.
I noticed that the crash does not happen if one hides the board
ratsnest, but it will later crash when trying to re-enable the ratsnest.
Can someone maybe help shed
Thank you! I will take a look at that PCB when I get home from work.
The refill zones is probably only one of the few quirks that comes with
the fact that I am piggybacking on the appendBoard function.
This is the broad flow:
I wrapped/inherited the real parser and redirected the output/input
Hmm, I cannot manage to reproduce the crash.
The things you are testing on, is the components pasted in using an
earlier version?
On 09/18/2017 11:19 AM, Tomasz Wlostowski wrote:
On 18.09.2017 00:32, Kristoffer Ödmark wrote:
That being said, I dont like the way the ref.pt is set now either,
On 18.09.2017 00:32, Kristoffer Ödmark wrote:
> That being said, I dont like the way the ref.pt is set now either, which
> is not at all. Personally I would like have the components added at the
> point of the cursor, but I also believe having a copy functionality that
> is not perfect as of now is
That being said, I dont like the way the ref.pt is set now either, which
is not at all. Personally I would like have the components added at the
point of the cursor, but I also believe having a copy functionality that
is not perfect as of now is better than none at all.
I do not have the time
I hope that the branch can be merged as is, and that the reference point
can be marked as a wishlist.
I will think about the reference point. I do not know if I like the extra
step of adding a reference point compared to having it set automatically.
On Sep 17, 2017 22:38, "Tomasz Wlostowski"
wro
On 17.09.2017 19:56, Kristoffer Ödmark wrote:
> Thanks for taking the time to test this, I know testing takes time!
>
> I took a look at some of the things you mentioned.
>
> - I fixed menu entries
> - I changed some names of functions ( still kept appendFromClipboard,
> but made the action cal
On 17.09.2017 20:43, Simon Küppers wrote:
> Oh wait, there are a few mistakes.
>
> 1. Select elements
> 2. Ctrl+C (or Ctrl+X)
> 3. Cursor changes. Now select origin by clicking.
>
> 4. Ctrl+V (paste)
> 5. Elements are now moving with the offset to the cursor that has been
> selected in Step 3
> 6
Oh wait, there are a few mistakes.
1. Select elements
2. Ctrl+C (or Ctrl+X)
3. Cursor changes. Now select origin by clicking.
4. Ctrl+V (paste)
5. Elements are now moving with the offset to the cursor that has been
selected in Step 3
6. Final Click to place the items. Cursor might be snapping to
Altium Designer handles it the following way:
1. Select elements
2. Ctrl+C (or Ctrl+V)
3. Cursor changes. Now select origin by clicking.
4. Elements are now moving along with constant offset to cursor
5. Move to destination and click again (cursor might be snapping to
grid) to paste elements
Am
Thanks for taking the time to test this, I know testing takes time!
I took a look at some of the things you mentioned.
- I fixed menu entries
- I changed some names of functions ( still kept appendFromClipboard,
but made the action called pasteFromClipboard )
- Footprints now render correct
On 17.09.2017 17:06, Kristoffer Ödmark wrote:
> Hey again, I needed this feature again when copying some tedious
> silkscreen drawings that I have not made into a footprint.
>
> Updated my branch to fit into master. I do agree that adding context
> menu entries should be done, but I do not feel it
Hey again, I needed this feature again when copying some tedious
silkscreen drawings that I have not made into a footprint.
Updated my branch to fit into master. I do agree that adding context
menu entries should be done, but I do not feel it necessary for merging
this unless any other bugs ar
Kristoffer,
I finally had a chance to test this and it seems to work fine. You
definitely need to add copy and paste to the context menu and probably
to the main menu as well. While ctrl-c and ctrl-v are will known,
Pcbnew has never had a copy and paste feature so it may be wise to add
the menu
I will review it as soon as I can free up the time. It certainly is
something we could use. If other developers can review it and give
feedback, that would be helpful.
Wayne
On 6/5/2017 7:03 AM, Nick Østergaard wrote:
> Sure seems interesting, but I suspect people just have not had time to
> re
Sure seems interesting, but I suspect people just have not had time to
review or test this yet, including me.
2017-06-05 10:07 GMT+02:00 Kristoffer Ödmark :
> Hello!
>
> Is there any interest in this?
>
> - Kristoffer
>
>
> On 2017-05-21 22:32, Kristoffer Ödmark wrote:
>>
>> Hello!
>>
>> I fixed t
Hello!
Is there any interest in this?
- Kristoffer
On 2017-05-21 22:32, Kristoffer Ödmark wrote:
Hello!
I fixed the kicad clipboard code according to your comments, it is now
linked to ctrl+c and ctrl+v, utilizing different code paths depending on
what frame they are invoked at.
I also fi
Hello!
I fixed the kicad clipboard code according to your comments, it is now
linked to ctrl+c and ctrl+v, utilizing different code paths depending on
what frame they are invoked at.
I also fixed the crashes when trying to paste strange stuff.
The code is available for testing at:
h
Hey!
I made some tests and I think that the best way to move forward with
this is to have separate copy paste functionality for the Module editor
and the pcb editor, since the module editor doesnt allow for much things
from the pcb editor. In short keeping both the module-copy paste and the
p
Thank you Orson!
I also saw the copy/paste in the footprint editor. But that one needs to
only accept modules or primitives to modules. I will investigate the
crashes, to be honest I hadnt really checked the functionality of my
implementation in the footprint editor at all.
Regarding the lic
Hi Kristoffer,
It is a neat feature. Your application is a good application, but I
think it would really shine in the footprint editor. Unfortunately, it
crashes when I tried to copy and paste a bunch of pads. Could you check it?
IMHO it would be better to keep standard Ctrl+C and Ctrl+V hot keys
It will be cool to have this feature. Good work
В Четверг, 4 май. 2017 в 11:41 , Kristoffer Ödmark
написал:
Hello all!
Last night I was doing some design that used a PCB antenna. I had
this antenna design made in zones, It was very frustrating to try to
copy this between an old design and a
31 matches
Mail list logo
