Re: [Kicad-developers] [PATCH] GerbView non-standard extensions

2017-09-29 Thread jp charras
Le 29/09/2017 à 00:42, Seth Hillbrand a écrit : > Attached is a patch to allow GerbView to "correctly" process %FSD commands.  > It also displays a > warning message after processing the file that the Gerber is invalid. > > Background: > - %FSD is used by older versions of Altium Designer [1],

Re: [Kicad-developers] [PATCH] Use wxImage instead of wxBitmap in COLOR4D picker (Fixes LP:1718389)

2017-09-29 Thread Seppe Stas
The problem is caused by the alpha channel of KIGFX::COLOR4D being initialised to 0. This causes the color pickers to be invisible if the alpha channel is not set. I sent a patch for this in a separate thread. macOS is actually the only platform where the color picker behaves correctly XD. Ubuntu

[Kicad-developers] [PATCH] Set color picker color alpha channel to 1

2017-09-29 Thread Seppe Stas
Fixes lp:1718389 . The alpha channel of KIGFX::COLOR4D, which is used to draw the color pickers, initialises to 0. This causes the color picker to be invisible on platforms that support alpha channels in a wxBitmap (like macOS). This patch sets the

Re: [Kicad-developers] [PATCH] Use wxImage instead of wxBitmap in COLOR4D picker (Fixes LP:1718389)

2017-09-29 Thread Jon Evans
Nice catch! On Sep 29, 2017 08:17, "Seppe Stas" wrote: > The problem is caused by the alpha channel of KIGFX::COLOR4D being > initialised to 0. This causes the color pickers to be invisible if the > alpha channel is not set. I sent a patch for this in a separate thread. > >

Re: [Kicad-developers] [PATCH] 3D Viewer: Fix for labels from popup menu

2017-09-29 Thread jp charras
Le 29/09/2017 à 15:24, Константин Барановский a écrit : > In popup menu of 3D Viewer the entry for setting bottom view is labeled as > Top View (present two > entries with label "Top View") and the entries for move left/right has > different writing style > (left/right starts with lower case). >

[Kicad-developers] [PATCH] 3D Viewer: Fix for labels from popup menu

2017-09-29 Thread Константин Барановский
In popup menu of 3D Viewer the entry for setting bottom view is labeled as Top View (present two entries with label "Top View") and the entries for move left/right has different writing style (left/right starts with lower case). Attached small patch fixess this. From

Re: [Kicad-developers] [PATCH] Set color picker color alpha channel to 1

2017-09-29 Thread Jon Evans
KiCad recently (early 2017) moved from indexed color to full RGBA color, and I picked the COLOR4D struct to do that because it was already in use elsewhere for the 3D viewer (probably because OpenGL uses floating point color). It's kind of an arbitrary choice because any integer mapping can be

[Kicad-developers] [PATCH] Multiple Zone bugfix

2017-09-29 Thread Seth Hillbrand
​The attached patch fixes two issues with t​he multiple zone handling when duplicating. One is a segfault when accessing SetLayerSet() on a layer that doesn't have a copper zone assigned and the second ensures that the layerset is propagated to new layers when cloning and assigning. -S From

Re: [Kicad-developers] [PATCH] Set color picker color alpha channel to 1

2017-09-29 Thread jp charras
Le 29/09/2017 à 14:08, Seppe Stas a écrit : > Fixes lp:1718389 . The alpha > channel of > |KIGFX::COLOR4D|, which is used to draw the color pickers, initialises to 0. > This causes the color > picker to be invisible on platforms that support alpha

Re: [Kicad-developers] [Patch] Update PCB from Schematic hotkey in pcbnew and bug in schematic filename

2017-09-29 Thread Jon Neal
Just a suggestion, since the "Update PCB from schematic" functionality hasn't been in a release yet maybe update the hotkey in eeschema so it matches the hotkey in pcbnew? Yes, people who have been using the nightlies will have to relearn the hotkey, but that is better than another UI