Re: [Kicad-developers] spaces not allowed in SCH library nicknames

2018-01-27 Thread Jeff Young
The rename bug: https://bugs.launchpad.net/kicad/+bug/1745437 > On 27 Jan 2018, at 13:03, Jeff Young wrote: > > Fixing the symbol library table editor to accept spaces will cause merge > conflicts with:

Re: [Kicad-developers] spaces not allowed in SCH library nicknames

2018-01-27 Thread Wayne Stambaugh
On 01/27/2018 08:18 AM, jp charras wrote: > Le 27/01/2018 à 13:41, Wayne Stambaugh a écrit : >> On 01/27/2018 05:55 AM, jp charras wrote: >>> Le 26/01/2018 à 23:11, Jeff Young a écrit : It is a great idea.  I hope it pans out…. >>> >>> I perhaps missed something, but the only one reason

Re: [Kicad-developers] Loading symbol libraries

2018-01-27 Thread Maciej Suminski
Hi Wayne, Sorry for late response, I am traveling again. I have not tested the patch itself but read the code, mostly focusing on CMP_TREE_MODEL and LIB_MANAGER{,_ADAPTER} classes. I think the proposed changes make sense and are rather safe. It might be a good idea to merge this patch, judging by

Re: [Kicad-developers] spaces not allowed in SCH library nicknames

2018-01-27 Thread Wayne Stambaugh
On 01/27/2018 05:55 AM, jp charras wrote: Le 26/01/2018 à 23:11, Jeff Young a écrit : It is a great idea.  I hope it pans out…. I perhaps missed something, but the only one reason spaces are not accepted in component lib names (component lib_id) is the fact the space breaks the

Re: [Kicad-developers] spaces not allowed in SCH library nicknames

2018-01-27 Thread Jeff Young
Fixing the symbol library table editor to accept spaces will cause merge conflicts with: https://bugs.launchpad.net/kicad/+bug/1248451 . On the other hand, that fix also allows the correction of symbols which won’t load onto the canvas because of

Re: [Kicad-developers] Loading symbol libraries

2018-01-27 Thread Wayne Stambaugh
Hey Jeff, I merged your patch. Keep up the great work. Cheers, Wayne On 01/25/2018 06:54 PM, Jeff Young wrote: > Hi JP, /et al/, > > Please find V2 of the Edit Symbol in Library performance patch attached. > > Cheers, > Jeff. > > > > > >> On 25 Jan 2018, at 16:30, jp charras

Re: [Kicad-developers] Why timestamp in Zone Outline messages?

2018-01-27 Thread Wayne Stambaugh
On 01/27/2018 05:43 AM, jp charras wrote: Le 26/01/2018 à 22:55, Wayne Stambaugh a écrit : I'm not sure why we do this other than possibly to help with debugging. JP, is there any reason to expose the zone timestamps to users? If not, we should probably remove them. On 01/26/2018 03:33 PM,

Re: [Kicad-developers] spaces not allowed in SCH library nicknames

2018-01-27 Thread jp charras
Le 27/01/2018 à 13:41, Wayne Stambaugh a écrit : > On 01/27/2018 05:55 AM, jp charras wrote: >> Le 26/01/2018 à 23:11, Jeff Young a écrit : >>> It is a great idea.  I hope it pans out…. >>> >> >> I perhaps missed something, but the only one reason spaces are not accepted >> in component lib names

[Kicad-developers] macos patch removal.

2018-01-27 Thread Wayne Stambaugh
Is it safe for me to remove the wx macos patches from the source tree? I would like to get that done this weekend. Cheers, Wayne ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] macos patch removal.

2018-01-27 Thread Bernhard Stegmaier
I guess so. AFAIK Adam has the patches for his build setup anyway. Anyway, would be good to get that confirmed… @Adam? I still have to adjust the build instructions (I also try to do that this weekend). So, if you remove them now maybe someone new won’t find them according to the docs.

[Kicad-developers] The big rename?

2018-01-27 Thread Jeff Young
Are we still doing the big rename? I don’t remember exactly what we were going to change, but I just stumbled on some particularly egregious examples: wxBasePcbFrame.h (defines PCB_BASE_FRAME) basepcbframe.cpp (better, but still backwards and without separators) And maybe start all the icon

Re: [Kicad-developers] Why timestamp in Zone Outline messages?

2018-01-27 Thread jp charras
Le 26/01/2018 à 22:55, Wayne Stambaugh a écrit : > I'm not sure why we do this other than possibly to help with debugging. > JP, is there any reason to expose the zone timestamps to users? If not, > we should probably remove them. > > On 01/26/2018 03:33 PM, Jeff Young wrote: >> Why do we put

Re: [Kicad-developers] Loading symbol libraries

2018-01-27 Thread Wayne Stambaugh
Hey Orson, LOL! I just emailed you directly about this less than a minute ago. Please ignore that message. I'll get it merged. Thanks for the reply. Cheers, Wayne On 01/27/2018 08:49 AM, Maciej Suminski wrote: > Hi Wayne, > > Sorry for late response, I am traveling again. I have not tested

Re: [Kicad-developers] The big rename?

2018-01-27 Thread Wayne Stambaugh
If we are, it has to happen soon. Once I branch v5, we cannot do this until the end of v6 development. Otherwise, cherry-picking bug fixes from the development branch will be a major headache. Chris, are you still planning on doing this? Cheers, Wayne On 01/27/2018 09:04 AM, Jeff Young

Re: [Kicad-developers] spaces not allowed in SCH library nicknames

2018-01-27 Thread jp charras
Le 26/01/2018 à 23:11, Jeff Young a écrit : > It is a great idea.  I hope it pans out…. > I perhaps missed something, but the only one reason spaces are not accepted in component lib names (component lib_id) is the fact the space breaks the compatibility with old kicad versions. I don't think

Re: [Kicad-developers] The big rename?

2018-01-27 Thread Jeff Young
Another one: DRC is defined in drc.cpp, but the header is drc_stuff.h. > On 27 Jan 2018, at 14:07, Wayne Stambaugh wrote: > > If we are, it has to happen soon. Once I branch v5, we cannot do this > until the end of v6 development. Otherwise, cherry-picking bug fixes >

Re: [Kicad-developers] The big rename?

2018-01-27 Thread Chris Pavlina
Nah, go on without me. Sorry. On Sat, Jan 27, 2018 at 02:07:48PM +, Wayne Stambaugh wrote: > If we are, it has to happen soon. Once I branch v5, we cannot do this > until the end of v6 development. Otherwise, cherry-picking bug fixes > from the development branch will be a major headache.

Re: [Kicad-developers] The big rename?

2018-01-27 Thread Jon Evans
I can send a patch for this later today. On Sat, Jan 27, 2018 at 2:00 PM, Chris Pavlina wrote: > Nah, go on without me. Sorry. > > On Sat, Jan 27, 2018 at 02:07:48PM +, Wayne Stambaugh wrote: > > If we are, it has to happen soon. Once I branch v5, we cannot do this

Re: [Kicad-developers] The big rename?

2018-01-27 Thread jp charras
Le 27/01/2018 à 20:00, Chris Pavlina a écrit : > Nah, go on without me. Sorry. > > On Sat, Jan 27, 2018 at 02:07:48PM +, Wayne Stambaugh wrote: >> If we are, it has to happen soon. Once I branch v5, we cannot do this >> until the end of v6 development. Otherwise, cherry-picking bug fixes >>

Re: [Kicad-developers] macos patch removal.

2018-01-27 Thread Adam Wolf
It is fine on my end, but if Bernhard only has a day or two left on updated docs maybe wait for those? No strong opinion here. On Sat, Jan 27, 2018 at 7:48 AM, Bernhard Stegmaier wrote: > I guess so. > AFAIK Adam has the patches for his build setup anyway. > Anyway,

Re: [Kicad-developers] The big rename?

2018-01-27 Thread Wayne Stambaugh
On 01/27/2018 02:11 PM, jp charras wrote: Le 27/01/2018 à 20:00, Chris Pavlina a écrit : Nah, go on without me. Sorry. On Sat, Jan 27, 2018 at 02:07:48PM +, Wayne Stambaugh wrote: If we are, it has to happen soon. Once I branch v5, we cannot do this until the end of v6 development.