Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

2019-06-11 Thread Adam Wolf
I did not test it, but reading over it, it looks great. Thanks! Adam On Tue, Jun 11, 2019 at 1:41 PM Adam Wolf wrote: > > I will review today. > > Thanks for your help, Seppe! > > On Tue, Jun 11, 2019, 10:11 AM Wayne Stambaugh wrote: >> >> Seppe, >> >> Your patch looks good to me. Any MacOS

Re: [Kicad-developers] CMake KICAD_SCRIPTING Options Hierarchy

2019-06-11 Thread Anton Lazarev
Just want to chime in with my own report, as I ran into this earlier today as well. I was trying to run a quick build for the first time, and in the interest of decreasing compile time and avoiding installing too many libraries, I figured disabling a few features would help - since I didn't

Re: [Kicad-developers] Debuggers, boost and std::deque

2019-06-11 Thread Jeff Young
I also found a new experimental feature in CLion: Enable natvis renderers for LLDB. Doesn’t seem to help though. I wonder if I need to load natvis files somewhere? > On 11 Jun 2019, at 21:16, Bernhard Stegmaier wrote: > > I wouldn’t try this. > macOS switched to libc++ long time ago. > I

Re: [Kicad-developers] [PATCH] Crash Reporter

2019-06-11 Thread Nick Østergaard
Yes, that was the same commit I tested as mentioned earlier. Although somehow added a "not" in the original message :) On Tue, 11 Jun 2019 at 00:52, Wayne Stambaugh wrote: > > Did you test the latest commit 2745a95b6b02c3864d6594503cc21619691cdd94? > > On 6/10/19 6:02 PM, Nick Østergaard wrote:

Re: [Kicad-developers] Debuggers, boost and std::deque

2019-06-11 Thread Bernhard Stegmaier
I wouldn’t try this. macOS switched to libc++ long time ago. I don’t know how it is today but I had a really hard time with unpredictable results/crashes/linking errors back when I started with KiCad and (due to not knowing anything about it) had libraries compiled with libstdc++ and libc++

Re: [Kicad-developers] PATCH pcbnew half-rotate actions and shortcuts

2019-06-11 Thread Jon Evans
Just wanted to hop in and say that the features you describe for layer selections is something I'm already working on for V6 (natively, not via Python script), but that doesn't preclude making it possible to do similar things via scripting too! -Jon On Tue, Jun 11, 2019 at 3:34 PM John Beard

Re: [Kicad-developers] Debuggers, boost and std::deque

2019-06-11 Thread Jeff Young
I found this in a CLion blog: This feature works in GCC, and in the case of Clang it works for libstdc++ only. This requires the following setting to be added to CMakeLists.txt: set(CMAKE_CXX_FLAGS “${CMAKE_CXX_FLAGS} -stdlib=libstdc++”) I’m not sure what the alternative to libstdc++ is.

Re: [Kicad-developers] 5.1 Hotkey problems

2019-06-11 Thread Ian McInerney
Seth, I am not sure about if they would cause usability issues on other platforms (it could be that they don't, since there have been no reports about it), but I do see a downside/idiosyncrasy with having them duplicated. Currently, the 5.1 hotkey configuration tools have no idea which tool is

Re: [Kicad-developers] PATCH pcbnew half-rotate actions and shortcuts

2019-06-11 Thread John Beard
On 10/06/2019 23:35, Andrew Lutsenko wrote: If adding 2 new default shortcuts is not ideal maybe there is a way to have these as actions with no shortcuts and let the user choose if they want to use them and assign any shortcut they want.Is that technically supported with current hotkey

Re: [Kicad-developers] 5.1 Hotkey problems

2019-06-11 Thread Seth Hillbrand
Hi Ian- On 2019-06-11 12:56, Ian McInerney wrote: Somewhat in relation to the patch I just sent, 5.1 currently has some hotkey issues with the default hotkeys that are being shipped with it, namely with pcbnew where: Paste is a duplicate hotkey of Add Microvia (both have Ctrl-V) Add a similar

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

2019-06-11 Thread Adam Wolf
I will review today. Thanks for your help, Seppe! On Tue, Jun 11, 2019, 10:11 AM Wayne Stambaugh wrote: > Seppe, > > Your patch looks good to me. Any MacOS devs care to comment? > > Cheers, > > Wayne > > On 6/11/19 10:46 AM, Seppe Stas wrote: > > Hey Wayne > > > > I attached my patch

Re: [Kicad-developers] PATCH pcbnew half-rotate actions and shortcuts

2019-06-11 Thread John Beard
Hi Mark, On 11/06/2019 19:20, Mark Roszko wrote: Idea: quick tap of R just does 90. Long press R and it pops open a tiny dialog with focus to enter a rotation number and then you can hit enter and it just sets the rotation angle directly on the footprint properties. Ctrl+M will already do

Re: [Kicad-developers] Debuggers, boost and std::deque

2019-06-11 Thread Seth Hillbrand
On 2019-06-11 13:23, Jeff Young wrote: Do other folks debuggers have a hard time with these? Mine won’t show me the contents of an OPT item, and it consistently lies about the size() of a std::deque. Cheers, Jeff. Hi Jeff- I use this [1] in gdb for STL containers. Also, check out [2] for

Re: [Kicad-developers] PATCH pcbnew half-rotate actions and shortcuts

2019-06-11 Thread Mark Roszko
Idea: quick tap of R just does 90. Long press R and it pops open a tiny dialog with focus to enter a rotation number and then you can hit enter and it just sets the rotation angle directly on the footprint properties. This significantly reduces clicking and leaves it flexible for those that don't

Re: [Kicad-developers] Arc drawing: code vs comment

2019-06-11 Thread Seth Hillbrand
On 2019-06-11 14:00, Simon Richter wrote: Hi, I just stumbled across /* Please NOTE the different sign due to Y-axis flip */ start.x = centre.x + KiROUND( cosdecideg( radius, -StAngle ) ); start.y = centre.y + KiROUND( sindecideg( radius, -StAngle ) ); at

[Kicad-developers] Arc drawing: code vs comment

2019-06-11 Thread Simon Richter
Hi, I just stumbled across /* Please NOTE the different sign due to Y-axis flip */ start.x = centre.x + KiROUND( cosdecideg( radius, -StAngle ) ); start.y = centre.y + KiROUND( sindecideg( radius, -StAngle ) ); at common/plotters/plotter.cpp:164. Is that comment obsolete, or is

Re: [Kicad-developers] Debuggers, boost and std::deque

2019-06-11 Thread Wayne Stambaugh
Jeff, I wonder if your debugger isn't getting confused by the context switching? I see some pretty strange looking back traces after a context switch in gdb that can make debugging difficult. Wayne On 6/11/19 1:23 PM, Jeff Young wrote: > Do other folks debuggers have a hard time with these?

[Kicad-developers] Debuggers, boost and std::deque

2019-06-11 Thread Jeff Young
Do other folks debuggers have a hard time with these? Mine won’t show me the contents of an OPT item, and it consistently lies about the size() of a std::deque. Cheers, Jeff. ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

2019-06-11 Thread Jeff Young
CMake is black magic to me. I wouldn’t know if this were the best thing since sliced bread or the return of the plague. ;) Cheers, Jeff. > On 11 Jun 2019, at 16:11, Wayne Stambaugh wrote: > > Seppe, > > Your patch looks good to me. Any MacOS devs care to comment? > > Cheers, > > Wayne >

[Kicad-developers] 5.1 Hotkey problems

2019-06-11 Thread Ian McInerney
Somewhat in relation to the patch I just sent, 5.1 currently has some hotkey issues with the default hotkeys that are being shipped with it, namely with pcbnew where: Paste is a duplicate hotkey of Add Microvia (both have Ctrl-V) Add a similar zone has an invalid hotkey (it is currently

[Kicad-developers] [Patch] Hotkey validation/checking for 5.1

2019-06-11 Thread Ian McInerney
Attached is a patch that adds in hotkey validation/checking to the 5.1 branch. This will display error messages with the hotkeys when the user edits the hotkeys, and notifies the user that there are invalid hotkeys when viewing the list. It also checks imported files for their validity, and warns

Re: [Kicad-developers] Latest info on copper zones using solid polygons without outline thickness.

2019-06-11 Thread Tomasz Wlostowski
On 09/06/2019 20:51, jp charras wrote: > First, thanks Tom for your test. > > But are the drawing issues (calculation time and memory overflow) fixed > by this change? > They were the main reason of this change. Yes, the VBO out-of-memory issue is gone now. I haven't measured yet how much memory

Re: [Kicad-developers] CMake KICAD_SCRIPTING Options Hierarchy

2019-06-11 Thread Ian McInerney
Wayne, Thanks for the clarification. It just seemed somewhat odd to me to have them override scripting to on when all were on by default. Also, thanks for updating the dev docs to represent the changes. On a similar note, it appears that none of the other scripting defines have their dependency

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

2019-06-11 Thread Wayne Stambaugh
Seppe, Your patch looks good to me. Any MacOS devs care to comment? Cheers, Wayne On 6/11/19 10:46 AM, Seppe Stas wrote: > Hey Wayne > > I attached my patch (generated with `git format-patch --attach > origin/master`) to my last email as > per 

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

2019-06-11 Thread Seppe Stas
Hey Wayne I attached my patch (generated with `git format-patch --attach origin/master`) to my last email as per http://www.kicad-pcb.org/contribute/developers/#_submitting_patches. I have a feeling Gmail might not like the mail headers in the patch. I created a new patch without the --attach

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

2019-06-11 Thread Wayne Stambaugh
Seppe, I don't understand why your emails keep ending up on the moderated list but something strange is going on. I had to moderate this one as well. Please attach your patch (created using `git format-patch`) so it can be reviewed and commented on. Cheers, Wayne On 6/11/19 10:17 AM, Seppe

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

2019-06-11 Thread Seppe Stas
Hey I closed the merge request on Launchpad and re-attached the patch and before and after screenshots (the after being built from a dirty master branch) to this mail: Before: [image: Screenshot 2019-06-05 at 22.46.43.png] After: [image: Screenshot 2019-06-05 at 22.46.54.png] As you can see,

Re: [Kicad-developers] Build errors

2019-06-11 Thread John Beard
Hi Wayne, On 11/06/2019 14:15, Wayne Stambaugh wrote: As of the commit b9e07f2a706b719a5f86b6372c5a7cda2f6a7c55 I am getting the following build errors on linux using clang: I just fixed these in 1e4abac57 as they were blocking me. The first one, I bisected down to c13ef839c, though I do not

[Kicad-developers] Build errors

2019-06-11 Thread Wayne Stambaugh
As of the commit b9e07f2a706b719a5f86b6372c5a7cda2f6a7c55 I am getting the following build errors on linux using clang: /usr/bin/ld: ../common/libgal.a(view_overlay.cpp.o): in function `COMMAND_POLY_POLYGON': /home/wayne/src/kicad-trunk/common/view/view_overlay.cpp:177: undefined reference to

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

2019-06-11 Thread Seth Hillbrand
Hi Seppe- I see this e-mail. Perhaps it was a launchpad hiccup. I've added Adam to the code review at [1]. Would you mind re-sending the images to the list? Thanks- Seth [1] https://code.launchpad.net/~seppestas/kicad/+git/kicad/+merge/368644 On 2019-06-11 05:23, Seppe Stas wrote: Hey

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

2019-06-11 Thread Seppe Stas
Hey I'm not sure if this email got ignored or if it got rejected by some mailing system, but it does not seem to show up in the mailing list archive . Maybe now it works? Seppe On Wed, Jun 5, 2019 at 10:55 PM Seppe Stas wrote: > Hey