Re: [Kicad-developers] [PATCH] Change track width setting to dropbox

On 08/25/2017 04:44 PM, Wayne Stambaugh wrote: > Looks good to me. Orson, would you please merge this when you get a chance? Done. Matthias, thank you for your patch! Regards, Orson > On 8/25/2017 9:51 AM, Maciej Sumiński wrote: >> Hi Matthias, >> >> Your patch looks

[Kicad-developers] [RFC] Update Fields in eeschema

The attached patches add to eeschema possibility of updating fields for components already placed on schematics sheet using library values. It is useful for users maintaining additional fields in libraries to store information that may change over time (e.g. Obsolete, URL fields). Regards, Orson

Re: [Kicad-developers] [PATCH] Change track width setting to dropbox

Hi Matthias, Your patch looks good to me. I would love to see the same change done for via hole and diameter text controls. Regarding inch vs mil, IMHO mils are better suited for PCB design. Still, I would rather keep pcbnew consistent, so I suppose we should stay with inches for the time being.

Re: [Kicad-developers] [PATCH] PL Editor UI improvements

Hi Michael, Thank you for your contribution. I like the changes, but I would keep 'Append' rather than 'Import'. In my opinion it is a better description for the action. Regards, Orson On 08/27/2017 11:12 PM, Michael Kavanagh wrote: > Dear All, > I am a university EEE student looking to start

Re: [Kicad-developers] [PATCH] Select via sizes from design rules

Hi Mathias, I apologize for not replying to the width setting dropbox earlier, now it seems to be too late to change the idea. Your patch is a clever solution to the problem, so if there are no more ideas/patches for setting via sizes, I am going to apply your changes. Regards, Orson On

Re: [Kicad-developers] [PATCH] Move ZOOM_TOOL to common; add RMB-drag to zoom out

Hi Jon, Thank you for the patch, I have just committed it to the master branch. Making tools more generic is always a good change and the zoom out function works as advertised. Regards, Orson On 08/31/2017 04:35 AM, Jon Evans wrote: > Hi all, > > The attached patch refactors ZOOM_TOOL to

Re: [Kicad-developers] [PATCH] Fix incorrect (missing) initialisation of m_cur_grid in, symbols libraries table dialog box

Hi Jean-Samuel, Thank you very much for the patch, indeed it fixes the problem. I have just pushed it to the master branch. Reards, Orson On 08/30/2017 07:43 PM, Jean-Samuel Reynaud wrote: > Hi all, > > There is an incorrect initialisation of variable m_cur_grid in > DIALOG_SYMBOL_LIB_TABLE

Re: [Kicad-developers] [PATCH] Change track width setting to dropbox

Hi Mathias, On 08/25/2017 09:55 PM, Mathias Grimmberger wrote: > > Hi Maciej, > > Maciej Sumiński <maciej.sumin...@cern.ch> writes: > >> Hi Matthias, >> >> Your patch looks good to me. I would love to see the same change done >> for via hole

Re: [Kicad-developers] [PATCH] Eagle schematic and project import.

Hi Jean-Pierre, On 09/25/2017 04:10 PM, jp charras wrote: [snip] > I have 2 different issues. > > 1 - "Rounding" issues: > Attached a .sch from Eagle, and the same after conversion to eeschema file. > In the Eeschema file, many (most of?) wires are on the 1 mil grid (see for > instance lines

Re: [Kicad-developers] PCBNew / Footprint editor - "Special strings"

Hi Thomas, On 10/18/2017 11:19 AM, Thomas Langås wrote: > Disclaimer: I come from the world of Altium, and might have a biased workflow. > > Is the following possible in any way in KiCad, or is there a different > workflow that > supports what I want? > > Usually, when I make components, I have

Re: [Kicad-developers] [FEATURE] Add keepout areas in footprints

On 10/19/2017 11:31 AM, jp charras wrote: > Le 18/10/2017 à 16:57, Oliver Walters a écrit : >> JP, >> >> Fantastic, you have worked your magic! That works much better in pcbnew now, >> the undo/redo is >> working well. >> >> However, I still see that undo/redo for zone editing is broken in

Re: [Kicad-developers] [PATCH] Eagle schematic and project import.

On 10/18/2017 04:58 PM, jp charras wrote: > Hi Orson, > > I just tested this last code > > The schematic conversion looks good to me, but Pcbnew crashes when trying to > convert 2 of my test > boards (tested only on W7 32 bits) > > Attached these 2 boards. > > Regards, Jean-Pierre, Thank

Re: [Kicad-developers] [PATCH] Preserve color scheme when switching to legacy (Fixes lp:1670669)

Hi Jon, Thank you for the patch. It works as in the description, therefore I pushed it to the master branch. Regards, Orson On 11/28/2017 04:13 AM, Jon Evans wrote: > Hi all, > > This patch changes the color scheme behavior when switching between GAL and > legacy canvases. Previously, the

Re: [Kicad-developers] [PATCH] Allow changing LAYER_PADS color and visibility (Fixes lp:1672646)

Another good patch today, thank you! I have pushed it to the master branch. Regards, Orson On 11/28/2017 02:20 AM, Jon Evans wrote: > Hi all, > > This adds LAYER_PADS to the render settings that are accessible to the > user, meaning you can change the color or hide this layer now. > > Best, >

Re: [Kicad-developers] [PATCH] Reset tool transitions even when already active (Fixes lp:1733224)

Thank you Jon, I think your patch makes sense. I have just pushed it to the master branch. Regards, Orson On 11/27/2017 02:23 AM, Jon Evans wrote: > Tom, you might want to take a look at this one. > > I was looking into this bug and noticed some odd behavior and I'm not quite > sure what the

Re: [Kicad-developers] [PATCH] support "disable autopan" with gal canvas

Thank you Julius, I have just pushed your patch to the master branch. I added the 'Fixes:' line to the commit message. Regards, Orson On 11/23/2017 11:07 PM, Julius Schmidt wrote: > This patch adds support for the "disable autopan" feature to the gal > canvas. > > I'm not entirely sure this is

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

Thank you Michael, I have just updated the files and pushed to my branch. I am about to test the code on Windows and check for decimal separator character issues. Cheers, Orson On 11/24/2017 09:04 AM, Michael Geselbracht wrote: > Hi, > I have added some comments and examples to the code. The

Re: [Kicad-developers] [PATCH] Eeschema automatic manage junctions

Hi Seth, I tested the branch and I consider it a significant improvement to the way junctions are handled. I confirm it fixes the four bugs mentioned in patch 0011, apart from a single case when a parallel component is dragged out. In this case junctions are not still not auto deleted (see [1],

Re: [Kicad-developers] Getting kicad to work with wxPython Phoenix

Hi Miles, On 11/24/2017 10:19 AM, miles mccoo wrote: > in reply to Wayne's request to run the footprint wizard > > I run the footprint wizard; it seems to run fine. > when I press the 3D view button, I get a popup complaining about not > finding the wx gtk2 library > "10:14:11:

Re: [Kicad-developers] New feature notifications

To have a concrete text that we can discuss, I propose an update to the Contribute->Developers page with the attached patch. What do you think? Cheers, Orson On 11/22/2017 04:21 PM, Wayne Stambaugh wrote: > On 11/22/2017 10:16 AM, Maciej Sumiński wrote: >> On 11/22/2017 03:55 PM, Way

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

, Orson On 11/24/2017 10:35 AM, Maciej Sumiński wrote: > Thank you Michael, I have just updated the files and pushed to my > branch. I am about to test the code on Windows and check for decimal > separator character issues. > > Cheers, > Orson > > On 11/24/2017 09:04 AM, M

Re: [Kicad-developers] Library Editor refactor

let's >> have a look at the abandoned patches on the mailing list and the bug >> tracker.. >> >> Regards, >> Orson >> >> On 11/14/2017 05:37 PM, Maciej Sumiński wrote: >>> The long awaited refactor of the Symbol Library Editor is ready for >>

Re: [Kicad-developers] Recent eeschema changes

On 11/22/2017 01:56 PM, Wayne Stambaugh wrote: [snip] > No it didn't. You were just lucky. IMO, the symbol cache library has > always been a disaster waiting to happen and it masked a lot of issues > with broken and modified symbol libraries. Your desire to have a single > symbol footprint link

Re: [Kicad-developers] Library Editor refactor

ting library" > 2. Select a library from the file chooser > 3. On the dialog that says "Choose the library table to add the library", > press cancel or hit escape > > Cheers > > On Wed, Nov 15, 2017 at 3:37 AM, Maciej Sumiński <maciej.sumin...@cern.ch> &

Re: [Kicad-developers] Library Editor refactor

On 11/22/2017 02:28 PM, jp charras wrote: > Le 21/11/2017 à 23:49, Maciej Suminski a écrit : >> I have just managed to fix the last issue (disappearing buttons in 'Save >> Library' dialog) and pushed the code to the master branch. >> >> Thank you for testing and comments, I really appreciate it.

Re: [Kicad-developers] terms clarification

I wonder if there is a distinction in naming an instance and its model, like object vs class in C++. On 11/22/2017 02:31 PM, Oliver Walters wrote: > +1 for "symbol" and "footprint" > > On Thu, Nov 23, 2017 at 12:28 AM, Marco Ciampa wrote: > >> On Wed, Nov 22, 2017 at

Re: [Kicad-developers] [PATCH] Allow items to be moved from all anchor points

Hi Jose, Thank you for fixing the problem. I have just pushed your patch to the master branch. Regards, Orson On 11/20/2017 05:29 PM, José Ignacio wrote: > A change in commit 57310001350 caused kicad to stop allowing users > to move items like footprints, arcs and lines using anchors other >

Re: [Kicad-developers] [PATCH] Fix for 3D model offset

I think the master branch already has enough new features to make its output incompatible with v4. 'Offset' approach seems the easiest and cleanest solution IMHO. Cheers, Orson On 11/22/2017 11:16 PM, Oliver Walters wrote: > I understand this will break "forwards compatibility" if opening a v5

Re: [Kicad-developers] [PATCH] Fix aperture macro hit testing (Fixes lp:1730249)

For the record: an updated version of this patch has been already comitted. Thank you Jon! Regards, Orson On 11/11/2017 11:22 PM, Jon Evans wrote: > Hi all, > > This patch fixes a bug reported by Nick in GerbView GAL, where aperture > macro hit testing wasn't quite right. > >

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

We still do not have the feature freeze, so there is still a chance to shove it to the master branch. I feel a bit uneasy about exprtk (over 1 MB header file), but Michael's parser approach seems like a good solution to me. We can extend it later as the lemon format is not very complex. I took

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

ing which is probably > undesired (15.12356 -> 15.1236). > 2. The decimal separator is set to '.' the input language settings by the > user are not taken into account. > 3. I did not check for memory leaks or buffer overflows. > > - Michael > > > On Thu, Nov 23, 2017 at 2:3

Re: [Kicad-developers] New feature notifications

On 11/22/2017 04:01 PM, Marco Ciampa wrote: > On Wed, Nov 22, 2017 at 02:55:35PM +0100, Maciej Sumiński wrote: >> On 11/22/2017 02:48 PM, Marco Ciampa wrote: >> [snip] >>> Please please please, >>> >>> when some new feature is accepted (code merged in mast

Re: [Kicad-developers] New feature notifications (was: Library Editor refactor)

On 11/22/2017 02:48 PM, Marco Ciampa wrote: [snip] > Please please please, > > when some new feature is accepted (code merged in master branch), either > write it in the dev (master) branch of the documentation or somewhere to > enable doc writers to describe the new feature... (wiki? txt in the

Re: [Kicad-developers] New feature notifications

On 11/22/2017 03:55 PM, Wayne Stambaugh wrote: > On 11/22/2017 08:55 AM, Maciej Sumiński wrote: >> On 11/22/2017 02:48 PM, Marco Ciampa wrote: >> [snip] >>> Please please please, >>> >>> when some new feature is accepted (code merged in master branc

Re: [Kicad-developers] Getting kicad to work with wxPython Phoenix

Hi Miles, On 11/23/2017 04:17 PM, miles mccoo wrote: > In a recent thread > on this list, > it was mentioned that kicad may need to drop support for SWIG/Python due to > wx and wxPython limitations. > > Perhaps I misinterpreted what

Re: [Kicad-developers] [PATCH] Math expression support for pad editor.

Just to be clear, these patches are not critical for the feature freeze. If I manage to get them merged before the freeze is announced - cool, otherwise we will have a reward for our dedicated nightly build testers in v6. Regards, Orson On 11/23/2017 04:28 PM, Maciej Sumiński wrote: >

Re: [Kicad-developers] Questions on BOARD_COMMIT

Hi Miles, On 11/29/2017 03:53 PM, miles mccoo wrote: > Since BOARD_COMMIT was a requested item to be added to the Python > interface, since it's related to be previous questions about getting a > redraw on the GAL canvas, and since it could make a good entry to my kicad > python tutorials, I have

Re: [Kicad-developers] Questions on BOARD_COMMIT

Hi Wayne, On 11/29/2017 06:35 PM, Wayne Stambaugh wrote: [snip]>> KIGFX::VIEW* view = s_PcbEditFrame->GetGalCanvas()->GetView(); >> item->MethodThatModifiesTheItemState(); >> view->Update( item ); > > Is this safe? What happens when pcbnew is using the legacy canvas? This is safe as long as

Re: [Kicad-developers] [PATCH] Restore "Flip Board" checkbox state when switching canvases

Thank you Jon! I pushed your patch to the master branch. Regards, Orson On 11/30/2017 02:59 AM, Jon Evans wrote: > Another quick bug fix > > -Jon > > > > ___ > Mailing list: https://launchpad.net/~kicad-developers > Post to :

Re: [Kicad-developers] Potrace update (AGAIN)

I wonder why do we even keep potrace in the source tree. It is available in mingw, brew and major Linux distributions, so it does not need to be build manually. Regards, Orson On 11/27/2017 03:58 AM, Simon Wells wrote: > U I *think* its jp who does the potrace stuff but there has been

Re: [Kicad-developers] Python: time_t needs mapping; tentative patch

On 11/28/2017 09:02 AM, jp charras wrote: > Le 28/11/2017 à 00:27, Tomasz Wlostowski a écrit : >> On 27/11/17 21:18, Wayne Stambaugh wrote: >>> On 11/27/2017 2:56 PM, jp charras wrote: Le 27/11/2017 à 20:18, Tomasz Wlostowski a écrit : > On 27/11/17 17:05, Henner Zeller wrote: >> Yes,

Re: [Kicad-developers] Partial fix for Bug #1737132

Hi Jean-Pierre, On 12/12/2017 07:00 PM, jp charras wrote: > Hi Orson, > > Could you have a look into this patch. > > It fixes the Bug #1737132 (component tree widget cleared in lib editor after > any change in symbol), > but there is still a minor issue. > > The reason the component tree

Re: [Kicad-developers] macOS 3d-viewer improvements

Hi Bernhard, I tested your patches on Linux and Windows 7 and I have not noticed any problems, so I pushed them to the master branch. Thank you! Regards, Orson On 12/17/2017 10:55 PM, Bernhard Stegmaier wrote: > Hi Wayne, > > sorry, I obviously have copied a wx-3.1 only constructor. > Please

Re: [Kicad-developers] [PATCH] Fi build error on macOS

Hi Bernhard, Thank you for the patch, I have just pushed it to the master branch. Regards, Orson On 12/19/2017 01:33 PM, Bernhard Stegmaier wrote: > Hi, > > Attached patch fixes 2 build errors on macOS. > Just fixed the build error, no test of the plugin. > > > Regards, > Bernhard > > > >

Re: [Kicad-developers] All kinds of glitches because polygons don't have an origin. Also: Outline ?

Henner, Thank you for the message and your findings, I am sure they will be useful for fixing the problem. I turned this into a bug report, so it is not forgotten [1]. Cheers, Orson 1. https://bugs.launchpad.net/kicad/+bug/1738032 On 11/21/2017 06:26 AM, Henner Zeller wrote: > Hi, > I am

Re: [Kicad-developers] [PATCH] bugfix: OPENGL_GAL::DrawPolygon did not close closed polygons

Thank you Andreas, I have just pushed your patch to the master branch. Cheers, Orson On 12/10/2017 11:01 PM, Andreas Buhr wrote: > Dear Kicad developers, > > The polygon drawing routing in the OpenGL-GAL did > not plot polygons which are "closed", i.e. have a segment > from their last point to

Re: [Kicad-developers] [PATCH] Reduction of Polygon Complexity

Hi Andreas, I tested the patch with many boards and I confirm it reduces the polygon complexity, without introducing any DRC violations. I would love to merge it, but it is difficult for me to assess the risk of adding new bugs, which are particularly not wanted during the feature freeze. If

[Kicad-developers] Library Editor refactor

The long awaited refactor of the Symbol Library Editor is ready for testing! Changes (yes, it will be included in the commit message): - Component Tree widget as a user-friendly part selector - Multiple editor contexts, allowing the user to easily switch between modified parts -

Re: [Kicad-developers] [PATCH] fix MANDATORY_FIELDS comparisons

Thank you Julius, I have just merged your patch. Regards, Orson On 11/18/2017 01:32 PM, Julius Schmidt wrote: > Apologies for the delay, but here's the patch as an attachment. > > On Thu, 9 Nov 2017, Wayne Stambaugh wrote: > >> Julius, >> >> I cannot git am this patch.  Apparently, the extra

Re: [Kicad-developers] Library Editor refactor

On 11/20/2017 11:16 PM, Nick Østergaard wrote: > Hello Maciej, Hi Nick, > I have some comments: > > First of all, it looks quite neat. I am glad to hear that. Thank you for the test ride! > Secondly I noticed a small thing. When I open the symbol library editor and > it open in a small window

Re: [Kicad-developers] Library Editor refactor

reason of delay. If things go smooth, copy/paste will be >>>>> included in v5, otherwise - v6. >>>>> >>>>> Regards, >>>>> Orson >>>>> >>>>> On 17/11/2017 11:03 PM, Maciej Suminski wrote: >>>>>

Re: [Kicad-developers] Library Editor refactor

On 11/21/2017 05:06 PM, Nick Østergaard wrote: > 2017-11-21 10:22 GMT+01:00 Nick Østergaard <oe.n...@gmail.com>: > >> 2017-11-21 <20%2017%2011%2021> 9:43 GMT+01:00 Maciej Sumiński < >> maciej.sumin...@cern.ch>: >> >>> On 11/20/2017 11:16 PM, N

Re: [Kicad-developers] KiCad Library Download Page

On 11/03/2017 01:31 AM, Oliver Walters wrote: > Hi all, > > Stage 2 of ? of the library update project is underway. > > Idea: A downloads page for the libraries that presents individual libraries > for download, and users can preview the data available in the libraries. > > This is auto-built

Re: [Kicad-developers] [PATCH 00/12] Minor cleanups and improvements

On 11/03/2017 01:38 PM, Carsten Schoenert wrote: > Hello Marvin, > > Am 02.11.2017 um 21:58 schrieb Marvin Schmidt: >> Just a set of small code cleanups to fix a bunch of warnings >> and remove dead code. >> Other than that the 'build:' commits avoid/remove/fix the >> installation of certain

Re: [Kicad-developers] Update of KiCad documentation?

On 11/03/2017 11:30 AM, Kristoffer Ödmark wrote: > I think starting small would be best in this case. The least needed > would be a "News" File, that is always refering to kicad stable. > > I propose the same way that patches with policy errors are rejected, > patches that introduces new

Re: [Kicad-developers] [PATCH] Replace .wrl files with .step on export (fixes lp:1710796)

Hi Oliver, If I may suggest one thing, then I would turn: +if( ext == "wrl" || ext == "WRL" || ext == "Wrl" ) +return FMT_WRL; into: +if( ext.Lower() == "wrl" ) +return FMT_WRL; Apart from that, the patch seems fine just by reading the contents. No need to send another

Re: [Kicad-developers] Update of KiCad documentation? (when to release kicad-5.0)

On 11/01/2017 09:40 AM, Carsten Schoenert wrote: > Hello Wayne, > > Am 31.10.2017 um 13:06 schrieb Wayne Stambaugh: >> We are very close to a feature freeze and creating a 5 stable branch. >> Once that is done, it typically takes a few months to make sure there >> are no critical or major bugs

Re: [Kicad-developers] [PATCH 00/12] Minor cleanups and improvements

On 11/07/2017 01:24 AM, Wayne Stambaugh wrote: > On 11/3/2017 9:08 AM, Maciej Sumiński wrote: >> On 11/03/2017 01:38 PM, Carsten Schoenert wrote: >>> Hello Marvin, >>> >>> Am 02.11.2017 um 21:58 schrieb Marvin Schmidt: >>>> Just a set o

Re: [Kicad-developers] [PATCH] wxWidgets macOS 10.13 Patch

Hi Adam, Thank you for the (meta)patch. Would you give some more details about the required CPPFLAG? Perhaps we could do something on our side? I would rather avoid adding one more requirement to the way wxWidgets building process, unless there is really no other method. Regards, Orson On

Re: [Kicad-developers] Update of KiCad documentation?

ommit message policy is >>> set. I for one love reading changelogs when upgrading, and I think >>> the users are expecting this as well, and it probably will be useful >>> in the FOSDEM presentation :) >>> >>> >>> On 11/04/20

Re: [Kicad-developers] Simulator towards 5.0

05:18 PM, Nick Østergaard wrote: > Isn't it good enough to mention it under the KiCad Build Configuration > Options in the devdocs as it is already? > > > 2017-12-05 16:56 GMT+01:00 Maciej Sumiński <maciej.sumin...@cern.ch>: > >> If everyone agrees that Spice

Re: [Kicad-developers] Fwd: Questions on BOARD_COMMIT

Hi Miles, On 12/04/2017 09:23 AM, miles mccoo wrote: >> Is there a document the explains Board commit? An email thread about it > >>> perhaps? >> >> There are some comments in include/commit.h. Perhaps it should be extended. >> >> > Yes, I think so. A small description of how this class is

Re: [Kicad-developers] UTF8 class and wchar_t issues fix

Cheers, > > Wayne > > On 12/08/2017 08:38 AM, Maciej Sumiński wrote: >> Hi Jean-Pierre, >> >> Thank you for the fix, I think you are right. I applied the patch to the >> master branch. >> >> Regards, >> Orson >> >> On 12/08/2017 01

Re: [Kicad-developers] UTF8 class and wchar_t issues fix

Hi Jean-Pierre, Thank you for the fix, I think you are right. I applied the patch to the master branch. Regards, Orson On 12/08/2017 01:53 PM, jp charras wrote: > Hi Orson > > Could you have a look into this patch. > > I am thinking it is also a fix for bug 1737143. > > Currently our UTF8

Re: [Kicad-developers] [PATCH] fix double free and memory leak in SHAPE_POLY_SET

Hi Andreas, Thank you for the patch. The proposed changes are reasonable, therefore I merged your patch to the master branch. Cheers, Orson On 12/08/2017 12:37 PM, Andreas Buhr wrote: > Dear Kicad developers, > > the attached patch fixes two bugs in SHAPE_POLY_SET. > > There were two problems

Re: [Kicad-developers] UTF8 class and wchar_t issues fix

https://bugs.launchpad.net/kicad/+bug/1736083 as fix committed. > > On 12/08/2017 08:50 AM, Maciej Sumiński wrote: >> Hi Wayne, >> >> I have tested it and indeed it fixes the problem with Eagle import as well. >> >> Cheers, >> Orson >> >&

Re: [Kicad-developers] [PATCH] BuildConnectivity and re-DisplayBoard in python Refresh

I think this patch solves one of the problems the scripting interface users face now. Are there any objections to merging the patch? Does any Python developer care to comment whether it is a requested change? Regards, Orson On 12/03/2017 11:54 AM, miles mccoo wrote: > Refresh is used in the

Re: [Kicad-developers] Signal integrity simulation within Kicad

Hi Andreas, I am sorry for late response, I must have lost your e-mail. Still, the answers may help you in the future. On 12/05/2017 03:42 PM, Andreas Buhr wrote: > Dear Kicad developers, > > I am browsing the Kicad source code to get an idea how to integrate a > simulation tool. > > I'd like

Re: [Kicad-developers] [PATCH] Prevent multiple item delete when routing (fixes lp:1715158)

Hi Seth, Thank you very much for the fix. I have just pushed your patch to the master branch. Regards, Orson On 12/07/2017 05:13 AM, Seth Hillbrand wrote: > ​The attached patch corrects https://bugs.launchpad.net/kicad/+bug/1715158 > where pressing delete in pcbnew GAL canvas will delete _both_

Re: [Kicad-developers] Simulator towards 5.0

Oops, fixed version attached. Thank you for checking. Regards, Orson On 12/07/2017 11:35 AM, Clemens Koller wrote: > Hi! > > FYI: Your patch also touches OPENGL_GAL::BitmapText()... > > Regards, > Clemens > > On 2017-12-07 09:27, Maciej Sumiński wrote: >> Th

Re: [Kicad-developers] Simulator towards 5.0

The attached patch lists options that have "KICAD" in their name when calling CMake: -- Build configuration: -- KICAD_BIN=bin -- KICAD_BRANCH_NAME= -- KICAD_DATA=share/kicad -- KICAD_DEMOS=share/kicad/demos -- KICAD_DOCS=share/doc/kicad -- KICAD_INSTALL_DEMOS=ON --

Re: [Kicad-developers] Listing CMake build options (was: Simulator towards 5.0)

es defined in cmake options() or > if they get lumped in with all of the other variables. > > Cheers, > > Wayne > > On 12/7/2017 5:38 AM, Maciej Sumiński wrote: >> Oops, fixed version attached. Thank you for checking. >> >> Regards, >> Orson >> >>

Re: [Kicad-developers] [PATCH] Use explicit shift in hotkeys instead of mixed-case characters

For the record, the patch has been already pushed. Thank you Jon! Regards, Orson On 12/09/2017 07:37 PM, Jon Evans wrote: > A minor fix due to how wxWidgets parses menu items. > > Fixes: https://bugs.launchpad.net/kicad/+bug/1737303 > > -Jon > > > >

Re: [Kicad-developers] [PATCH] Fix AlignLeft / AlignRight when using Flip Board view

Hi Jon, Thank you for the patch, I have pushed it to the master branch. Regards, Orson On 12/09/2017 08:18 PM, Jon Evans wrote: > Hi all, > > This is a "band-aid" patch for this bug: > https://bugs.launchpad.net/kicad/+bug/1734377 > > When flip board view is active, item bounding boxes are

Re: [Kicad-developers] [PATCH] Add double-click handling to disambiguation menu

I tested the patch on Linux and it works as advertised. Well done, we need the same thing for GAL too. Cheers, Orson On 12/06/2017 07:05 PM, Seth Hillbrand wrote: > ​The attached patch fixes https://bugs.launchpad.net/kicad/+bug/1154020 > > The current double-click handler in draw_panel​ gets

Re: [Kicad-developers] [PATCH] bugfix: OPENGL_GAL::drawPolygon did not respect fill settings

, but perhaps you may find useful either uncrustify or clang-format - we provide configuration files for both (uncrustify.cfg and _clang-format in the root directory). Cheers, Orson On 12/11/2017 10:20 AM, Andreas Buhr wrote: > On 12/11/2017 10:11 AM, Maciej Sumiński wrote: >> >> There

Re: [Kicad-developers] [PATCH] Bugfix: EDA_RECT to BOX2I generated wrong boxes

Hi Andreas, Good catch, it must have been like this since the GAL origin. I have applied your patch to the master branch. Thank you! Cheers, Orson On 12/10/2017 11:08 PM, Andreas Buhr wrote: > Dear Kicad developers, > > The "operator BOX2I() const" of EDA_RECT produced wrong boxes, usually >

Re: [Kicad-developers] [PATCH] bugfix: OPENGL_GAL::drawPolygon did not respect fill settings

Andreas, There is a minor code formatting violation, that I will fix. I suppose that unfilled polygons have not been used so far, therefore the issue could not be observed. If you use them, can you confirm the behavior is coherent with the cairo backend? Cheers, Orson On 12/08/2017 12:53 PM,

Re: [Kicad-developers] macOS & New Zone Filling?

I applied this workaround for OSX builds. It is better not to have a progress dialog rather than freeze on zone refill. It is a temporary change until we get the hardware where we can debug the problem properly. Regards, Orson On 12/09/2017 03:56 AM, Tomasz Wlostowski wrote: > On 09/12/17 01:33,

Re: [Kicad-developers] Zone filling

Hi Heikki, Your branch contains a lot of code that is not in the official repository and should not be merged (different connectivity algorithm, alternative way for via stitching interleaved with numerous #ifdef). There is no easy way to apply your changes to the master branch, as they have

Re: [Kicad-developers] Simulator towards 5.0

The subtle difference is your resolve wx dependency with 'apt-get install libwxgtk' and to get libngspice you need to cast a few spells when there is no package. On 12/05/2017 06:02 PM, Nick Østergaard wrote: > But it would also fail to build if you did not install wx. > > Den 5. dec. 2017 5.21

Re: [Kicad-developers] Zone filling

and those are only excuses. > > Regards > > Heikki > > > On Wed, Dec 6, 2017 at 12:12 PM, Maciej Sumiński <maciej.sumin...@cern.ch> > wrote: > >> Hi Heikki, >> >> Your branch contains a lot of code that is not in the official >> rep

Re: [Kicad-developers] Simulator towards 5.0

If everyone agrees that Spice simulator should be enabled by default, then please display a note saying it is optional and might be disabled for cases when it is not found by CMake. Regards, Orson On 12/05/2017 03:47 PM, Nick Østergaard wrote: > If they are not available for some reason the

Re: [Kicad-developers] Strange behavior of draw panel gal focus.

Hi Jean-Pierre, Everything works as expected on Linux, with or without the patch. I recall having some other focus problems in the past, so there are more workarounds in common/draw_panel_gal.cpp. Perhaps there is a way to simplify the code related to focus handling or the event handlers setup

Re: [Kicad-developers] [PATCH] Add live footprint filtering in modview window

Hi Oliver, This is a really useful improvement and works as advertised, I vote for merging! Cheers, Orson On 10/29/2017 02:37 PM, Oliver Walters wrote: > In the footprint viewer window it is often hard to find the exact footprint > you want across multiple libraries > > The attached patch set

Re: [Kicad-developers] [PATCH] Gerbview: Zoom to selection tool duplication

GMT+03:00 Wayne Stambaugh <stambau...@gmail.com>: > >> Nor would I. >> >> On 10/2/2017 3:30 AM, Maciej Sumiński wrote: >>> Hi Konstantin, >>> >>> I would rather not remove the cursor tool from the legacy canvas. Once >>> you select zoo

Re: [Kicad-developers] GenCAD exporter fixes

Hi Seth, Thank you for your feedback, there are some answers below. On 10/17/2017 10:03 PM, Seth Hillbrand wrote: > Hi Orson- > > First, thank you for digging into this. Let me know if you would like a > copy of the GenCAD specification doc. Thank you for the offer, I am looking at GenCAD 1.4

Re: [Kicad-developers] Strange behavior of draw panel gal focus.

/md_Documentation_development_compiling.html [Building KiCad on Windows] 2. http://www.mingw.org/wiki/Workaround_for_GDB_Ctrl_C_Interrupt On 10/31/2017 01:44 AM, Bang He wrote: > how to debug on win7 > > On Mon, Oct 30, 2017 at 9:40 PM, Maciej Sumiński <maciej.sumin...@cern.ch> > wrote: > >> Hi Je

Re: [Kicad-developers] [RFC] Eeschema bus upgrades and new connectivity algorithm

Hi Kristoffer, No offence, but is there any added value in using a configurable separator character or is it just your preference? It seems to me that adding such feature will complicate the code a lot for a small benefit, but I may not see the full picture. Perhaps it is just a convention that

Re: [Kicad-developers] [PATCH] Reduction of Polygon Complexity

> with merging this. Otherwise, we should hold off until the version 6 > development. > > Cheers, > > Wayne > > On 12/20/2017 4:53 AM, Maciej Sumiński wrote: >> Hi Andreas, >> >> I tested the patch with many boards and I confirm it reduces the polygon >> c

Re: [Kicad-developers] SELECTION_TOOL::guessSelectionCandidates()

Hi Jeff, I applied a different patch, but it should be fine now (more explanations in the bug report). Cheers, Orson On 12/20/2017 05:59 PM, Jeff Young wrote: > Hi Maciej, > > Could you have a look at bug https://bugs.launchpad.net/bugs/1739425 > ? >

Re: [Kicad-developers] help with redraw

Hi Andreas, You might be missing VIEW::Update() [1] call to invalidate a VIEW_ITEM after it has been modified. If it does not help, I will have a look at the code. Cheers, orson 1.

[Kicad-developers] Indeterministic netlist export for multiunit components

Hi, Recently I have found out that the netlist exporter uses an algorithm that for multiunit components uses non empty field values from the last processed unit [1]. The problem is that the processing order depends on the order of the units in the item list, so completely random. Instead, I

Re: [Kicad-developers] Another dialog preview

Nice, this is how a modern settings dialog should look like! Cheers, Orson On 05/17/2018 04:41 PM, Jeff Young wrote: > Just thought I’d share something from my 6.0 tree: > > > > > > > > > ___ > Mailing list:

Re: [Kicad-developers] partially untranslated strings in simulation dialog

Hi Marco, It should be fixed now, apologies for missing these strings until now. Cheers, Orson On 05/25/2018 11:15 AM, Marco Ciampa wrote: > Hi dev, > I am sorry for boring you all (as usual) with trivial (i18n) things. > Launching the Spice Simulator dialog I just noted a few untranslated >

Re: [Kicad-developers] Footprint Library Wizard removal

24/05/2018 à 10:19, Maciej Sumiński a écrit : >>> Attached a revised patch set, as the previous one looked ugly on Windows >>> (and fine on Linux). >> >> Thanks Orson. >> >> The look of this dialog is much better now. >> >> Just two remarks about t

Re: [Kicad-developers] 5.0 RC2 / release status

Hi Jon, Welcome back! There was one very serious issue [1] blocking RC2, but fortunately it was fixed yesterday. Looking at the to-do list for v5 [2], there are three minor issues and two more serious bugs that may need some extra data from the reporters. It would be great to have the former two

Re: [Kicad-developers] Indeterministic netlist export for multiunit components

(or perhaps even try and group units by matching >> their fields). But that carries enough risk to relegate it to 6.0 along >> with the undo stuff. >> >> Cheers, >> Jeff. >> >> >>> On 18 May 2018, at 12:16, Sergey A. Borshch <sb...@users.sour

Re: [Kicad-developers] More default fields in schematic

One more field that could become predefined and receive a special meaning is 'Mounted' or similar. This will come handy when we decide to support assembly variants and will let us add a visual distinction between mounted and not mounted components if we want it. The remaining fields is a matter

Re: [Kicad-developers] [PATCH] Fix -Wparentheses warning in track_cleaner.cpp

Hi John, Thank you for the patch, I have just pushed it to the master branch. Cheers, Orson On 06/12/2018 12:16 PM, John Beard wrote: > Hi, > > This is a very simple patch to address a -Wparentheses warning in > pcbnew/track_cleaner.cpp. > > It was "wxBusyCursor( dummy );", it is now

<    2   3   4   5   6   7   8   9   >