[Kicad-developers] [RFC]: Make hotkey editor polished

2014-10-04 Thread Mark Roszko
://code.launchpad.net/~mark-roszko/kicad/kicad -- Mark ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help : https://help.launchpad.net

Re: [Kicad-developers] [RFC]: Make hotkey editor polished

2014-10-05 Thread Mark Roszko
press your keyboard keys sounds a bit clunky. Maybe press a new key combination? Yea it was awkward. Changed to your suggestion. Duplicate keys are not detected for keys given by a select from the right mouse button popup menu. Ah, I completely forgot about the right click. Duplicate keys are

Re: [Kicad-developers] [RFC]: Make hotkey editor polished

2014-10-05 Thread Mark Roszko
Please respect the users system font choices for controls bold or otherwise. I know there are lots of UI folks who would disagree with me but when I set my system fonts, I do it for because that's the way I like them and I don't want them changed. Otherwise I would make them bold, italicized,

Re: [Kicad-developers] [RFC]: Make hotkey editor polished

2014-10-05 Thread Mark Roszko
Woops, just noticed the quotation. I wanted to bold the section to make them stand out because they aren't hotkeys and they do split the list. A separate consideration was I was pondering splitting the single grid into a tabbed interface with grids per section. This way the sections are more

Re: [Kicad-developers] [RFC]: Make hotkey editor polished

2014-10-06 Thread Mark Roszko
New changes pushed to branch (https://code.launchpad.net/~mark-roszko/kicad/kicad), the interface has been revised a bit more heavily. Sections are now split into tabs!. This helps immensely bringing attention to different set of keys easily rather than a large list. The selection logic has been

Re: [Kicad-developers] [RFC]: Make hotkey editor polished

2014-10-07 Thread Mark Roszko
Roszko mark.ros...@gmail.com wrote: New changes pushed to branch (https://code.launchpad.net/~mark-roszko/kicad/kicad), the interface has been revised a bit more heavily. Sections are now split into tabs!. This helps immensely bringing attention to different set of keys easily rather than a large

[Kicad-developers] [RFC] Eeschema dialog tweaks

2014-10-07 Thread Mark Roszko
I submitted this as a merge request but it may be best to discuss it on the mailing list. I started to hit up the other Eeschema dialogs while I was working on the hotkey editor. https://code.launchpad.net/~mark-roszko/kicad/eeschema-dialog-tweaks Changes: = -Use the verb Generate

Re: [Kicad-developers] [RFC] Eeschema dialog tweaks

2014-10-07 Thread Mark Roszko
Also fixes ERC Dialog not counting errors at all. For some reason SetLabel was used on wxTextCtrl isntead of SetValue. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] [RFC]: Make hotkey editor polished

2014-10-07 Thread Mark Roszko
would drop the [] around the tab names, use capitalization for the tab names, and change libedit to Library Editor (or something other than an abbreviation). If you find more of these abbreviations, please fix them to something sensible. Fixed that in the latest branch commit. I would like

Re: [Kicad-developers] [RFC] Eeschema dialog tweaks

2014-10-07 Thread Mark Roszko
I was thinking it could be Total issues, Warnings, Errors, having the word count repeat 3 times seems...redundant. Total errors is also wrong since its warnings + errors. ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

[Kicad-developers] [PATCH] Rename instances of module to footprint for consistency

2014-10-08 Thread Mark Roszko
it right. launchpad branch also available. https://code.launchpad.net/~mark-roszko/kicad/module_rename diff --git a/pcbnew/class_module.cpp b/pcbnew/class_module.cpp index 6c9d860..7bf8af1 100644 --- a/pcbnew/class_module.cpp +++ b/pcbnew/class_module.cpp @@ -602,7 +602,7 @@ void MODULE

Re: [Kicad-developers] [PATCH] Rename instances of module to footprint for consistency

2014-10-08 Thread Mark Roszko
Hehe, well, I guess everything can be renamed in the opposite direction. But consistency is needed. On Wed, Oct 8, 2014 at 2:45 AM, Lorenzo Marcantonio l.marcanto...@logossrl.com wrote: On Wed, Oct 08, 2014 at 02:37:40AM -0400, Mark Roszko wrote: So from what I remember, Kicad used to call alot

Re: [Kicad-developers] [PATCH] Rename instances of module to footprint for consistency

2014-10-08 Thread Mark Roszko
Hehe, look at that, its still a disputed name. Well we got to fix it. I went with footprint because it seemed like alot of newer features with with that name, the module editor was called the footprint editor originally in the launcher as well which is what caused me to really want to fix it(you

Re: [Kicad-developers] [RFC] Eeschema dialog tweaks

2014-10-08 Thread Mark Roszko
Thanks for your work, I've not had a chance to look at the merge request. No problem. I'm currently working on the eeschema options dialog to improve the template field names editor so please don't change that at the moment, Ok, personally I haven't found much issue with the Options dialog.

Re: [Kicad-developers] Fwd: [Merge] lp:~mark-roszko/kicad/eeschema-dialog-tweaks into lp:kicad

2014-10-08 Thread Mark Roszko
Sorry my bad, I accidently deleted the branch at one point when messing around with the git-bzr bridge which broke down for me :( I submitted a new merge request. ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] Fwd: [Merge] lp:~mark-roszko/kicad/eeschema-dialog-tweaks into lp:kicad

2014-10-08 Thread Mark Roszko
Missing from this pull request is changing Total issues to just Total like you suggested in the other email thread. On Wed, Oct 8, 2014 at 2:30 PM, Mark Roszko mark.ros...@gmail.com wrote: Sorry my bad, I accidently deleted the branch at one point when messing around with the git-bzr bridge

Re: [Kicad-developers] [PATCH] Rename instances of module to footprint for consistency

2014-10-08 Thread Mark Roszko
8, 2014 at 1:40 PM, Andy Peters de...@latke.net wrote: On Oct 8, 2014, at 5:08 AM, Mark Roszko mark.ros...@gmail.com wrote: I use footprint myself. Though footprint seems to imply what a PCB must have in order to accommodate a part, eg, pads, silk. Are the 3d models part

Re: [Kicad-developers] [PATCH] Rename instances of module to footprint for consistency

2014-10-08 Thread Mark Roszko
, Benoît Roehr benoit.roehr...@gmail.com wrote: Le 08/10/2014 19:40, Andy Peters a écrit : On Oct 8, 2014, at 5:08 AM, Mark Roszko mark.ros...@gmail.com wrote: I use footprint myself. Though footprint seems to imply what a PCB must have in order to accommodate a part, eg, pads, silk

Re: [Kicad-developers] Fwd: [Merge] lp:~mark-roszko/kicad/eeschema-dialog-tweaks into lp:kicad

2014-10-08 Thread Mark Roszko
The branch and merge request are now up to date with the Total text instead. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help :

Re: [Kicad-developers] [PATCH] fix additional usage of modules name in pcbnew netlist dialog

2014-10-10 Thread Mark Roszko
: Mark Roszko mark.ros...@gmail.com Date: Fri, 10 Oct 2014 00:54:10 -0400 Subject: [PATCH] Fix further references to modules in various dialogs in pcbnew. --- pcbnew/dialogs/dialog_block_options_base.cpp | 6 +- pcbnew/dialogs/dialog_block_options_base.fbp | 10 +- pcbnew/dialogs

[Kicad-developers] [PATCH] eeschema: add Select button for footprints in single component field edits

2014-10-10 Thread Mark Roszko
. + Doxygenization of the class. This also works in the library editor when you click on the footprint text and go to edit it. Patches attached and a bazr branch submitted for merge. https://code.launchpad.net/~mark-roszko/kicad/eeschema_footprint_pick From 9433680797d5b1dcc7f115ea6ace5e8452077bd0

Re: [Kicad-developers] bzr 5173 build broken

2014-10-11 Thread Mark Roszko
The build compiles fine for me, did you run cmake configure properly? Cmake generates shader_src.h which shader.cpp includes and has all the missing variables you see the errors complaining about. ___ Mailing list:

Re: [Kicad-developers] Website update help.

2014-10-11 Thread Mark Roszko
The reason I would like to do this is in the not too distant future, I am going to convert all of our compiling documents and the coding policy into markdown Any interest in doing this via Jekyll? It's basically meant to do markdown to HTML and one of the benefits is you can then get an

Re: [Kicad-developers] [RFC]: Make hotkey editor polished

2014-10-12 Thread Mark Roszko
Ok, I purged the wxGrid implementation and moved to a wxListCtrl which is superior. Now all the special keys are properly caught. The right click menu has been eliminated because wxListCtrl gets all the onCharEvents that wxGrid did not pass. The key conflict logic now checks between other

Re: [Kicad-developers] kicad-install.sh needs some moe error handling

2014-10-12 Thread Mark Roszko
He wasn't commenting about the wxWidgets version in particular. He was saying that Ubuntu does not have the python libraries for 3.0x and the install script blindly uses a grouped package install command which will fail if any of the packages are missing even though the python is rather optional

[Kicad-developers] Library Editor naming consistency

2014-10-12 Thread Mark Roszko
Very minor but the main KiCAD window calls it Schematic Library Editor, eeschema calls it Library Editor and the window itself is Parts Library Editor. Can the name be standardized? It might be better to just call it Component Library Editor because that's what the schematic symbols are called

Re: [Kicad-developers] Library Editor naming consistency

2014-10-14 Thread Mark Roszko
The manual uses component throughout and indeed Component name in the UI Component properties dialog. All the screenshots show Component too. If eeschema has changed these, they should be changed back An manual should never define the software, it should explain the software. Or else we'll never

Re: [Kicad-developers] Library Editor naming consistency

2014-10-14 Thread Mark Roszko
Be it just semantics but for me Documentation != Manual != Specifications A specification defines the feature, behaviors, etc. This is written ahead of time. A manual is for end users in a descriptive and easy to read form to follow. Documentation is for developers to understand what is going on

Re: [Kicad-developers] [RFC]: Make hotkey editor polished

2014-10-14 Thread Mark Roszko
FYI, latest code is sitting in merge proposal https://code.launchpad.net/~mark-roszko/kicad/hotkey/+merge/238225 ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https

Re: [Kicad-developers] Library Editor naming consistency

2014-10-14 Thread Mark Roszko
I'm leaning towards one of the markdown formats myself. I vote for markdown :D In fact, here, I ran a quick convert of ODT to markdown and imported it into a gitbook setup. Here's chapter 1 and 2 being served from markdown and combined with Gitbook and then being served from a git repo via

Re: [Kicad-developers] Possible 4.6 gerber issue?

2014-10-16 Thread Mark Roszko
Interesting, I found an online viewer that for some reason also cannot handle the circles in the gerber. Screenshot: http://i.imgur.com/me93vzA.png Viewer: http://mayhewlabs.com/webGerber/ I used the gebers that were originally attached by Jon. ___

Re: [Kicad-developers] Possible 4.6 gerber issue?

2014-10-16 Thread Mark Roszko
I just tested Nick's simple 1 circle test board he attached earlier. It has the same bug. Here are the gerbers from it and a screenshot. http://i.imgur.com/ZhTSoyV.png On Thu, Oct 16, 2014 at 11:43 PM, Mitch Davis mjd+launchpad@afork.com wrote: Hi, On Fri, Oct 17, 2014 at 2:38 PM, Mark

Re: [Kicad-developers] Possible 4.6 gerber issue?

2014-10-16 Thread Mark Roszko
https://mega.co.nz/#!AdVllbTa!w5qXHlZ03FNk_erZFqX_1Yram0bev1wZ02JFu42jFQk Link to gerbers from test case in case anyone other than Mitch needs it to receive attachments. ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] Possible 4.6 gerber issue?

2014-10-17 Thread Mark Roszko
I used two online viewers. http://circuitpeople.com/ViewPackage.aspx and http://mayhewlabs.com/3dpcb there was a desktop viewer but I don't have access to the computer now to lookup its name. I found the bug with mayhewlabs (I debugged their javascript), they compute the startAngle as 0 and

[Kicad-developers] [RFC] proposal of adjusted netlist dialog

2014-10-21 Thread Mark Roszko
Hello, So I've been going through the UI to make it nicer. The netlist dialog right now is a bit odd. These marked up images show why, basically the functionality is grouped oddly on the dialog. http://i.imgur.com/0JK0d3g.png http://i.imgur.com/OrfrH14.png My proposal is this new arrangement:

Re: [Kicad-developers] [RFC] proposal of adjusted netlist dialog

2014-10-22 Thread Mark Roszko
Actually I planned to do this: Rename the netlist dialog to Netlist Options Add a Generate Netlist menu option which does the immediate netlisting with saved settings unless its the first time and theres no saved settings. The plan was also to add a menu option for Annotation, a Silent Forward

Re: [Kicad-developers] Incremental build speeds.

2014-10-22 Thread Mark Roszko
I might also try porting to QBS (Qt's new build system) which is much faster than make in my experience. I hope you to plan to provide Debian, Windows, OSX, CentOS, etc binary packages and maintain them! The last thing any project needs is to provide more binaries themselves when they don't

Re: [Kicad-developers] Hotkeys menu error dialog

2014-11-07 Thread Mark Roszko
When I worked on the new hotkeys editor I didn't get this bug on Windows or Linux Mint. Otherwise, wxWidgets isn't as perfectly cross platform as you may believe, don't even get me started about the inconsistencies due to just one window manager ignoring settings that the other does (windows

Re: [Kicad-developers] emacs switches to Git

2014-11-12 Thread Mark Roszko
git-bzr is buggy What happened with the svn to git migration that was horrible out of curiosity? The only thing I could see is issue tracking? The codebase is already migrated because of the git mirror. What is less clear is the hosting sight. I'm am less than thrilled with using github

Re: [Kicad-developers] emacs switches to Git

2014-11-12 Thread Mark Roszko
and my company has recently migrated from VSS (!?@!*$) to SVN. That move seems to be working well for us, since we have no need for distributed development. A stone tablet is an improvement over VSS hehe.SVN works just fine when you are inhouse, are all company employees and don't care about

Re: [Kicad-developers] Will the opening of Eagle xml based pcb files ever be possible again?

2014-11-24 Thread Mark Roszko
EAGLE 7 made changes to their XML specification. Schematics can now be broken up into modules which are basically blocks ala hierarchical designs in other CAD software. I don't think the parser for KiCAD can handle circuits being nested into a module right now. Sigh, the code is going to be

Re: [Kicad-developers] broken code in pcbnew/dragsegm.cpp

2015-01-19 Thread Mark Roszko
I see your changes but aren't they incomplete still? The temp flag that gets set is either 0x01 and 0x02. The start and end points #defines are 1 9 and 110 which it compares against later. You could probably simplify it to wrapper.m_TempFlags = flag (STARTPOINT | ENDPOINT);

[Kicad-developers] [PATCHES] misc minor fixes

2015-01-17 Thread Mark Roszko
if bytes available limit). From 40386fb70d46a982fbcd11b9c5b517c4291bac48 Mon Sep 17 00:00:00 2001 From: Mark Roszko mark.ros...@gmail.com Date: Sat, 17 Jan 2015 12:28:10 -0500 Subject: [PATCH 1/4] fgetc does not gurantee a char return type, especially for EOF which can be the full 32-bit type -1

Re: [Kicad-developers] [PATCHES] misc minor fixes

2015-01-17 Thread Mark Roszko
1 more patch to the set. vrml_v1 and _v2 model parsers were comparing allocated arrays agains't 0 which can never happen. Also kills gcc warnings. From 77b84479e8342e4b6c1bda3d4c02a6dba686314f Mon Sep 17 00:00:00 2001 From: Mark Roszko mark.ros...@gmail.com Date: Sat, 17 Jan 2015 15:45:10 -0500

Re: [Kicad-developers] eeschema freeze BZR5378

2015-01-18 Thread Mark Roszko
I also noticed freezing on Windows Linux Mint when changing certain fields. Not sure what is causing it but it goes back at least a week ago. But for me its random, most of the time its fine and suddenly a lockup for a brief moment. ___ Mailing list:

[Kicad-developers] [PATCH] two minor fixes

2015-01-15 Thread Mark Roszko
for strncpy to actually copy null if size of bytes to read == buffer size passed. We need to set the last byte of line to NULL after strncpy as insurance. From 794636c7ff10ea98edd55b98457988196b66b3c6 Mon Sep 17 00:00:00 2001 From: Mark Roszko mark.ros...@gmail.com Date: Fri, 16 Jan 2015 00:43:11

[Kicad-developers] broken code in pcbnew/dragsegm.cpp

2015-01-18 Thread Mark Roszko
I am going through static analyzer results. http://puu.sh/eHuN9/7eebd45887.png m_Flag is a bool.(I double checked the class defintion of the vector g_DragSegmentList which DRAG_SEGM_PICKER) The masking doesn't make sense at all. The same problem is visible in the function AddSegmentToDragList

Re: [Kicad-developers] [PATCH] vrml_v2_modelparser coverity fix + check

2015-02-17 Thread Mark Roszko
Hah, noticed I forgot to subtract a byte for the first byte read by default. Use attached patches instead. From 410c30db3a435c023fa93e9e9e38166263fd8287 Mon Sep 17 00:00:00 2001 From: Mark Roszko mark.ros...@gmail.com Date: Tue, 17 Feb 2015 20:33:01 -0500 Subject: [PATCH 1/2] Fix

[Kicad-developers] [PATCH] vrml_v2_modelparser coverity fix + check

2015-02-17 Thread Mark Roszko
are passing as argument From 410c30db3a435c023fa93e9e9e38166263fd8287 Mon Sep 17 00:00:00 2001 From: Mark Roszko mark.ros...@gmail.com Date: Tue, 17 Feb 2015 20:33:01 -0500 Subject: [PATCH 1/2] Fix vrml_v2_modelparser.cpp array comparisons --- 3d-viewer/vrml_v2_modelparser.cpp | 12

Re: [Kicad-developers] [PATCH] IDF code: fixing problems reported by coverity

2015-02-16 Thread Mark Roszko
I marked them as Fix Submitted and Intentional (similar to False positives but those weren't quite false). I'll have a build submitted later tonight to coverity. ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] 3D Viewer crushes whole KiCAD with this file

2015-02-18 Thread Mark Roszko
The optimized_out is for the function argument. @LordBlick, could you compile with -DCMAKE_BUILD_TYPE=Debug and do the backtrace after it fails with that build. ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] [PATCH] IDF code: fixing problems reported by coverity

2015-02-16 Thread Mark Roszko
Coverity reports #102373 was not fixed. If while( aLibFile.good() ) is not true, it'll end up exiting the function with pout not freed. Also this is a good example of why you should mark issues you fix or ignore in Coverity. It's easier to check later if it got fixed.

Re: [Kicad-developers] Coverity scan.

2015-02-16 Thread Mark Roszko
Should coverity send emails to the mailing list when defects are picked up? the mailing list can be added to it. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe :

Re: [Kicad-developers] 3D Viewer crushes whole KiCAD with this file

2015-02-18 Thread Mark Roszko
When the segment fault causes gdb to stop (beofre you typed continue) Can you use the command backtrace? That will print more useful information on the path it took to crash. ___ Mailing list: https://launchpad.net/~kicad-developers Post to :

Re: [Kicad-developers] Coverity scan.

2015-02-15 Thread Mark Roszko
Just some notes 1. Coverity isn't perfect, there will be false positives and also some interesting cases where it flags issues due toassumptions made in code 2. Some of the statistics it displays on the project page are funky and don't seem to update properly so don't worry about them too much

Re: [Kicad-developers] 3D Viewer crushes whole KiCAD with this file

2015-02-18 Thread Mark Roszko
The root defect is the vrml has ~15 coordIndex tags that exceeds 128 bytes total. The parser being pretty bad uses a fixed 128 byte buffer to read tags into. The parser in GetNextTag did not have bound checking and thus would happily corrupt memory reading in that tag. My patch prevented

Re: [Kicad-developers] 3D Viewer crushes whole KiCAD with this file

2015-02-18 Thread Mark Roszko
overrun. On Wed, Feb 18, 2015 at 3:17 PM, LordBlick lordbl...@gmail.com wrote: In response to a message written on 18.02.2015, 19:24, from Mark Roszko: The optimized_out is for the function argument. @LordBlick, could you compile with -DCMAKE_BUILD_TYPE=Debug and do the backtrace after it fails

Re: [Kicad-developers] 3D Viewer crushes whole KiCAD with this file

2015-02-19 Thread Mark Roszko
written on 19.02.2015, 23:22, from Mark Roszko: I've been considering implementing OpenVRML for giggles which uses Boost::spirit for parsing. It's basically templating on steroids kind of C++ but can parse both standards fully. Except its GPLv3 so I don't know about license compatibility horseshit

Re: [Kicad-developers] Coverity scan.

2015-03-19 Thread Mark Roszko
The coverity defect viewer should be back to normal. The next build in a day or two will fix the statistics. On Fri, Mar 13, 2015 at 11:02 PM, Mark Roszko mark.ros...@gmail.com wrote: Don't get excited about the latest coverity result folks. My build script broke down and incorrectly performed

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Mark Roszko
A+++ Always hated the environment variables because your typical electrical engineer/non power user would not know wtf they are. Anyone developing kicad is already above average. File extension idea is good too. I suggest keeping the separate file filters in addition to an all filter if you go

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Mark Roszko
The concern is that if you select from KiCad github and its say the official Kicad group, then that's alot of libraries to download and install. Nothing wrong with doing that but perhaps instead just the Next should be disabled until at least one library is selected.

Re: [Kicad-developers] [RFC] Footprint wizard

2015-03-09 Thread Mark Roszko
Be very careful with relative paths on windows and in general. There should be a test to make sure the relative paths don't cross drive boundaries on windows. I would argue on Windows that relative paths that cross drive boundaries should be made absolute to that drive automatically. i.e. I may

[Kicad-developers] [PATCH] fix 2x memory leak and misc field warnings in PNS stuff

2015-03-09 Thread Mark Roszko
Fixes 1 leak in pns_line_placer and 1 leak in pns_node. Assorted field intialization. Based on coverity. From 987e65fdcf962f925fc1678b425d13173ae4b3a8 Mon Sep 17 00:00:00 2001 From: Mark Roszko mark.ros...@gmail.com Date: Mon, 9 Mar 2015 23:21:07 -0400 Subject: [PATCH] Fix memory leak in pns_node

Re: [Kicad-developers] [PATCH] coverity /common/ fixes

2015-03-06 Thread Mark Roszko
Woops, here. diff --git CMakeModules/TokenList2DsnLexer.cmake CMakeModules/TokenList2DsnLexer.cmake index df2ea8a..80044aa 100644 --- CMakeModules/TokenList2DsnLexer.cmake +++ CMakeModules/TokenList2DsnLexer.cmake @@ -374,14 +374,10 @@ const char* ${LEXERCLASS}::TokenName( T aTok ) { const

Re: [Kicad-developers] [PATCH] coverity /common/ fixes

2015-03-06 Thread Mark Roszko
And noticed I removed a space between a cast and variable btw that's not documented in the coding style policy on what to do there. On Fri, Mar 6, 2015 at 7:47 AM, Mark Roszko mark.ros...@gmail.com wrote: Woops, here. -- Mark diff --git CMakeModules/TokenList2DsnLexer.cmake CMakeModules

Re: [Kicad-developers] Coverity scan.

2015-03-13 Thread Mark Roszko
Don't get excited about the latest coverity result folks. My build script broke down and incorrectly performed a delta build and so it forgot most of the things...Next build on Tuesday will fix it. On Thu, Mar 5, 2015 at 9:45 PM, Mark Roszko mark.ros...@gmail.com wrote: Well submitting builds

Re: [Kicad-developers] [PATCH] fix 2x memory leak and misc field warnings in PNS stuff

2015-03-10 Thread Mark Roszko
O well not a big deal. Still that other patch waiting to be applied. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help :

Re: [Kicad-developers] Diff Pairs Length tuning in the product branch

2015-03-05 Thread Mark Roszko
As a FYI, Coverity has generated defects related to the new features that seem like they can generate unexpected behavior from what I see: #106428 (variable not initialized, considered high impact) #106367 (null dereference) #106366 (logically dead code) there's a bunch of other defects but

Re: [Kicad-developers] Diff Pairs Length tuning in the product branch

2015-03-05 Thread Mark Roszko
FYI, while compiling 5481 for a coverity scan In file included from /home/mroszko/kicad/include/geometry/shape.h:28:0, from /home/mroszko/kicad/pcbnew/router/pns_diff_pair.cpp:27: /home/mroszko/kicad/include/math/vector2d.h: In member function ‘void

Re: [Kicad-developers] What happened to the dxf plotter???

2015-02-26 Thread Mark Roszko
I wonder if theres a bug. It literally takes 5 minutes to run a DXF plot of the pic programmer demo kicad has. Gebers are instant. On Thu, Feb 26, 2015 at 9:15 AM, Lorenzo Marcantonio l.marcanto...@logossrl.com wrote: Tried to plot a mechanical layout and it spit out the *outline* of all the

Re: [Kicad-developers] Coverity scan.

2015-03-03 Thread Mark Roszko
So I was experimenting with automating the build submission using Travis-CI and I managed to link the coverity project in a way that it also renamed it to my github repo.working on getting that fixed. ___ Mailing list:

Re: [Kicad-developers] Coverity scan.

2015-02-28 Thread Mark Roszko
FYI, I just learned coverity has quotas https://scan.coverity.com/faq#frequency So there won't be any build submitted for a few days... Build Submission Temporarily UnavailableThe build submission quota for this project has been reached. Next submission permitted on or after 2015-Mar-05 12:34 PM

[Kicad-developers] [PATCH] correct some snprintf usage

2015-02-21 Thread Mark Roszko
a very stupid filesystem. Would be best if there was error handling if it exceeds ( snprintf will return greater than sizeof(buf) ) but I have no clue how that section needs cleanup. From aa1ed81a627cb16727ecf66473e1009723b8f934 Mon Sep 17 00:00:00 2001 From: Mark Roszko mark.ros...@gmail.com Date

Re: [Kicad-developers] [PATCH] correct some snprintf usage

2015-02-23 Thread Mark Roszko
You would think that would be the default behavior for a compiler used for cross compilation to avoid opening security holes without realizing. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net

[Kicad-developers] [PATCH] two eeschema cleanups

2015-02-20 Thread Mark Roszko
with netlisting were including netlist.h for the classes. In fact, netlist.cpp never used sch_reference! still compiles fine. From a7dd2320896c62507e3ded31881005e9cd287c2e Mon Sep 17 00:00:00 2001 From: Mark Roszko mark.ros...@gmail.com Date: Fri, 20 Feb 2015 23:18:14 -0500 Subject: [PATCH 1/2] eeschema

Re: [Kicad-developers] Coverity scan.

2015-02-20 Thread Mark Roszko
Yet more defects again introduced with the latest commits, we are so unlucky. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help

Re: [Kicad-developers] [PATCH] correct some snprintf usage

2015-02-22 Thread Mark Roszko
Stambaugh wrote: Mark, I committed your patch in the product branch version r5447. Thank you for your contribution. On 2/21/2015 10:00 PM, Mark Roszko wrote: Fixes some cases where n-1 bytes was used as a size but snprintf protects against that internally. Also some hardcoded constant sizes

Re: [Kicad-developers] thoughts on dependency on SISL library

2015-03-26 Thread Mark Roszko
https://www.gnu.org/licenses/why-affero-gpl.html GNU's own explanation. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help :

Re: [Kicad-developers] [PATCH 5/5] Add virtual keyword to implicitly virtual functions

2015-03-05 Thread Mark Roszko
I really don't agree with this patch with marking all the subclasses as virtual just because if the base class parameters ever change for a method the subclasses end up making entirely new functions. And you won't get any errors because it'll just call the base method no problem. If we did C++11

Re: [Kicad-developers] Coverity scan.

2015-03-05 Thread Mark Roszko
to. It seems Chrome ends up in an infinite redirect loop preventing whitelisting but Firefox works fine if you add an exception. On Wed, Mar 4, 2015 at 12:34 AM, Mark Roszko mark.ros...@gmail.com wrote: So I was experimenting with automating the build submission using Travis-CI and I managed to link

Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer

2015-04-13 Thread Mark Roszko
So perhaps some one can summarize this changes need There's hundreds of ways and reasons why Coverity could have thrown the use after free error that Brian is fixing. There is no one size fits all solution. ___ Mailing list:

Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer

2015-04-13 Thread Mark Roszko
was thinking something more easy and general like you should initialize your vars. In that case where can we have a look in the Coverity documentation? Is that something I can run / test myself? Regards, Mario Luzeiro On 14 Apr 2015 00:32, Mark Roszko mark.ros...@gmail.com wrote: So

Re: [Kicad-developers] [PATCH] S3D Mesh Smart Pointer

2015-04-13 Thread Mark Roszko
In that case where can we have a look in the Coverity documentation? They do not provide a list or documentation on what they may throw. Perhaps in they do in commercial version but not in the open source version. Is that something I can run / test myself? No, we are only allowed 2

Re: [Kicad-developers] [PATCH 00/27] My current patch stack

2015-04-12 Thread Mark Roszko
You could have probably squished a few of these patches into one to avoid spamming the bzr lovers with git emails hehehe ;) Because they'll end up squishing the commits to bzr anyway : ___ Mailing list: https://launchpad.net/~kicad-developers Post

Re: [Kicad-developers] Questionable code

2015-06-19 Thread Mark Roszko
So I haven't been active for the last few months but I have been running coverity weekly at least ;) I noticed this one three months ago 4bool PNS_DIFF_PAIR_PLACER::tryWalkDp( PNS_NODE* aNode, PNS_DIFF_PAIR aPair, bool aSolidsOnly ) 245{ 246PNS_DIFF_PAIR best; 247double bestScore =

Re: [Kicad-developers] [Patch] Add gitlab support to github plugin

2015-08-17 Thread Mark Roszko
The github API is used to get the list of all repositories on the KiCad group on github. git alone cannot do that. However the zips from github are requested instead of checking out the repo via cloning. Theres definitely arguments for cloning vs not. One of the annoyances I see is some repos can

Re: [Kicad-developers] Helping out with Kicad

2015-08-19 Thread Mark Roszko
Good news we are generating the new site as static html. Shouldn't have any load issues then assuming you run it under nginx or lighttpd. ^^ ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net

Re: [Kicad-developers] Helping out with Kicad

2015-08-21 Thread Mark Roszko
Currently everything is on github https://github.com/nickoe/kicad-website Yea there are spelling errors. Anyone can feel free to do the corrections and submit a pull request. Github lets anyone do text file changes via the web interface where it automates it all (branching, editing and pull

Re: [Kicad-developers] Helping out with Kicad

2015-08-21 Thread Mark Roszko
I think the news section should have the most visibility and get updated often Because someone would have to update it often. If someone wants to step up and commit to update it like every 2 weeks, then fine. Most of LibreOffice news are just events and the fact they have hundreds of devs working

Re: [Kicad-developers] Website repo update.

2015-08-24 Thread Mark Roszko
The biggest thing we need right now is for proof reading, corrections, and improvements of the pages we have now. Anyone can do this easily through github's web UI which lets you edit the file and submit a pull request without ever having to so much as clone the repository. In fact, github can

Re: [Kicad-developers] Helping out with Kicad

2015-08-20 Thread Mark Roszko
Actually, the 3d viewer image has been sorted out now. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help :

Re: [Kicad-developers] Helping out with Kicad

2015-08-20 Thread Mark Roszko
If you move to google analytics, then, EU laws force you to send a cookie You don't have to use cookies with Google Analytics. (You can feed it your own tracking ID) This script: https://github.com/Foture/cookieless-google-analytics which creates a browser fingerprint based on IP + other read

Re: [Kicad-developers] Release candidate - using common code base?

2015-07-28 Thread Mark Roszko
We are only allowed 2 coverity submissions per week FYI. ___ Mailing list: https://launchpad.net/~kicad-developers Post to : kicad-developers@lists.launchpad.net Unsubscribe : https://launchpad.net/~kicad-developers More help :

Re: [Kicad-developers] Release candidate - using common code base?

2015-07-28 Thread Mark Roszko
I don't understand what you are trying to convey. Coverity requires running a complete build from a clean state via gcc or clang or even msvc(command line only) and uploading the 500MB+ resulting data from their tool. Each build is a separate submission . It isn't like cppcheck where it just runs

Re: [Kicad-developers] Release candidate - using common code base?

2015-07-29 Thread Mark Roszko
just have it building on an EC2 c4.xlarge instance every week for coverity with all the options turned on. On Wed, Jul 29, 2015 at 1:12 AM, Simon Richter simon.rich...@hogyros.de wrote: Hi, Am 29.07.2015 um 06:44 schrieb Mark Roszko: I don't understand what you are trying to convey. Coverity

[Kicad-developers] [PATCH] fix coverity reported strcat/strcpy potential overflows

2015-08-09 Thread Mark Roszko
This should eliminate three of the low coverity defects where strcat or strcpy can overflow the destination buffer if left as is. From dbb86a6ed3c694944b91f3230983c1106e142bd8 Mon Sep 17 00:00:00 2001 From: Mark Roszko mark.ros...@gmail.com Date: Sun, 9 Aug 2015 18:00:20 -0400 Subject: [PATCH 1/1

Re: [Kicad-developers] [PATCH 2/3] Include iso646.h for not, and and or keywords

2015-07-27 Thread Mark Roszko
What? Those keywords are part of the C++ standard from 2003(at least). Its only MSVC that is backwards and broken in this regard. They are not part of the C standards and thats why iso646.h exists for those hipsters with non-qwerty keyboards (I joke)

Re: [Kicad-developers] official web page

2015-07-13 Thread Mark Roszko
Me and Nick were dicking about using Hugo the static site generator that supports asciidoc and other formats to make a mainstream kicad website. Of course leveraging things like bootstrap, etc to make the site but with the ability to also beautifully include the asciidoc kicad documentation and

Re: [Kicad-developers] official web page

2015-07-13 Thread Mark Roszko
themes which utilise the bootstrap framework for the template when I look around. 2015-07-13 16:30 GMT+02:00 Mark Roszko mark.ros...@gmail.com: Me and Nick were dicking about using Hugo the static site generator that supports asciidoc and other formats to make a mainstream kicad website

Re: [Kicad-developers] Boost 1.59 and MinGW build errors.

2015-10-23 Thread Mark Roszko
, Wayne Stambaugh <stambau...@gmail.com> wrote: > On 10/20/2015 11:57 AM, Mark Roszko wrote: >> Horrible news! In June, they decided to add "mingw" support to >> boost::context. Wait what >> does that even mean if we were compiling with it before hand? Hah who >>

  1   2   3   4   5   >