Re: [Kicad-developers] [PATCH 1/2] Last argument before ellipsis may not be reference

2015-09-13 Thread Simon Richter
Hi, On 13.09.2015 17:55, Lorenzo Marcantonio wrote: > I suppose that is talking about the implementation of va_start: address > of last+sizeof of last gives the starting point of the va_list (in the > 'correct' stack direction, obviously); am I correct? Indeed. The standard is written so va_* ca

Re: [Kicad-developers] [PATCH] Fixed a False BZR Version Number Built From Local Branch of GIT-Source-Mirror

2015-09-13 Thread Simon Richter
Hi, > Looks ok to me, except that the naming of the _git_LONG_HASH_ORIGIN > variable does not match what it is, it should have been > _git_LONG_HASH_LOCAL instead. This completely fails to compile for me: | [ 11%] Generating version string header | -- Using Git to determine build version string.

Re: [Kicad-developers] [PATCH] Fixed a False BZR Version Number Built From Local Branch of GIT-Source-Mirror

2015-09-13 Thread Simon Richter
Hi, On 13.09.2015 20:29, Simon Richter wrote: > This completely fails to compile for me: Okay, when I wipe my local repository and repeat the checkout, it works. Having a fallback to origin/master and/or more graceful handling of a missing origin/HEAD reference would be great though. Si

Re: [Kicad-developers] [PATCH] Fixed a False BZR Version Number Built From Local Branch of GIT-Source-Mirror

2015-09-14 Thread Simon Richter
Hi, On 14.09.2015 04:28, Mark Roszko wrote: > Now anyone using the newer git-remote-bzr is in for fun as well > because there is no such thing as "origin/HEAD". origin/HEAD is automatically created with git-remote-bzr, but not restored if lost. You can recreate it via echo "ref: refs/remotes/o

[Kicad-developers] BOX2::SetMaximum()

2015-09-14 Thread Simon Richter
Hi, while investigating an internal compiler error[1] in MSVC, I ran across this function. My feeling is that it is broken: For int: top_left = std::numeric_limits::min() / 2 + std::numeric_limits::epsilon(); size = std::numeric_limits::max() - st

Re: [Kicad-developers] BOX2::SetMaximum()

2015-09-14 Thread Simon Richter
Hi, On 14.09.2015 19:10, Mark Roszko wrote: > Weird, its supposed to be 0 for ints. > http://en.cppreference.com/w/cpp/types/numeric_limits/epsilon I was referring to the bit where it says "It is only meaningful if std::numeric_limits::is_integer == false". I think it's not a big problem for in

Re: [Kicad-developers] Version 4 stable branch rc1 released.

2015-09-14 Thread Simon Richter
Hi, Am 14.09.2015 um 23:58 schrieb Adam Wolf: [.deb packages] > Isn't that what's in the reynauld PPA? No, that's for Ubuntu -- they happen to use the same package format, but packages are generally not expected to be compatible. Simon signature.asc Description: OpenPGP digital signatur

Re: [Kicad-developers] Supported platforms / compiler / standard library versions

2015-09-22 Thread Simon Richter
Hi, On 19.09.2015 23:05, Wayne Stambaugh wrote: > No such document but basically gcc on linux and windows and clang on > osx. The official policy on MS VS is that we will not support it. VS 2015 is broken to the extent that it fails to compile some of the template code in VECTOR2<> and BOX<>, g

[Kicad-developers] [PATCH] Update copyright year in template

2015-10-09 Thread Simon Richter
Hi, this should get us over the next three months. Simon --- copyright.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/copyright.h b/copyright.h index 79a50ec..4110151 100644 --- a/copyright.h +++ b/copyright.h @@ -12,8 +12,8 @@ may choose to document this correspon

Re: [Kicad-developers] About collaboration, simulation, documentation, organisation, usability and documentation

2015-11-17 Thread Simon Richter
Hi, Am 05.11.2015 um 03:45 schrieb Mark Roszko: >> I have repeatedly asked that devs do incremental changes so I can >> easily review them. > It's hard to do refactoring when your one commit has to throw out the > kitchen sink. However, it is often possible to submit multiple commits of the for

[Kicad-developers] [PATCH 3/4] Allow OpenMP with non-gcc compilers

2015-11-30 Thread Simon Richter
This simply moves the OpenMP handling code out of the gcc specific block with no code changes. This is safe because OpenMP detection is portable. --- CMakeLists.txt | 33 +++-- 1 file changed, 19 insertions(+), 14 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.

[Kicad-developers] [PATCH 1/4] Use CMake high-level facility for visibility

2015-11-30 Thread Simon Richter
CMake 3.0 defines two new variables, * CMAKE_CXX_VISIBILITY_PRESET and * CMAKE_VISIBILITY_INLINES_HIDDEN to control whether symbols not explicitly tagged for export are implicitly exported. Because only version 3.3 and following also applies that to static libraries when in 3.3 mode, compatibi

[Kicad-developers] [PATCH 2/4] Use CMake function for position independent code

2015-11-30 Thread Simon Richter
CMake provides a simple declarative statement to enable PIC, so no compiler dependent handling is required. There is also no need to tell Boost to build with -fPIC, their build system is smart enough. --- CMakeLists.txt| 13 - CMakeModules/download_boost.cmake | 2

Re: [Kicad-developers] Not Print Debian 8.2 Kicad BZR 4027 Printer HP Laserjet P1102w

2015-11-30 Thread Simon Richter
Hi, On 01.12.2015 07:52, Ike Shields wrote: > I am having trouble printing the last part (print to copper. it is the > printed to photo paper then laminated onto Copper) when I print all I > get is the small drill holes and solder pads no tracks. Could it be that some of the "Layer" or "Render

Re: [Kicad-developers] Not Print Debian 8.2 Kicad BZR 4027 Printer HP Laserjet P1102w

2015-11-30 Thread Simon Richter
Hi, On 01.12.2015 07:52, Ike Shields wrote: > I did an update and it back that I was up to date? Also, I just noticed. The bzr 4027 version is ancient. The 4.0.0 version is not contained in Debian stable, and will not be included there either, as Debian never updates stable releases. I believe

[Kicad-developers] [PATCH 4/4] Drop gcc optimizer bug workaround

2015-11-30 Thread Simon Richter
As boost::polygon is gone, we can drop the workaround for older gcc. --- CMakeLists.txt | 15 --- 1 file changed, 15 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index ec89978..cd3e1bc 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -171,21 +171,6 @@ if( CMAKE_COMPIL

Re: [Kicad-developers] [PATCH 4/4] Drop gcc optimizer bug workaround

2015-12-01 Thread Simon Richter
Hi, On 01.12.2015 09:07, jp charras wrote: >> As boost::polygon is gone, we can drop the workaround for older gcc. > boost::polygon is gone, not the gcc bug. > This is likely a gcc bug, not a boost::polygon bug. Indeed, but the code that triggered the bug is gone, so it shouldn't affect us any

Re: [Kicad-developers] [PATCH] Copper layers selected by default in plot dialog

2015-12-03 Thread Simon Richter
Hi, Am 03.12.2015 um 20:11 schrieb Jon Neal: > With this patch when you add new layers in pcbnew they will be selected > by default for plotting. that is LP#1507822. -- https://bugs.launchpad.net/kicad/+bug/1507822 Simon signature.asc Description: OpenPGP digital signature ___

Re: [Kicad-developers] Printer HP laserjet P1102w OS debian 8.2 Kicad BZR 4027 not printing tracks only solder marks.

2015-12-04 Thread Simon Richter
Hi, Am 04.12.2015 um 06:46 schrieb Ike Shields: > In the print screen on R/H side; > > Under Copper layers Tick is on “B.cu” In the main window, on the right hand side, there are two tabs, "Layers" and "Render". The former is overridden by the layer selection in the print dialog, but the latter

[Kicad-developers] Debian packages

2015-12-05 Thread Simon Richter
Hi, I've made a backport of RC1 to Debian jessie -- release backports will happen once the release has hit unstable. The same packages have been uploaded to Debian, so if you have jessie-backports configured in your sources.list, your system should silently switch over to the release package after

Re: [Kicad-developers] [PATCH 2/4] Use CMake function for position independent code

2015-12-08 Thread Simon Richter
Hi, On 08.12.2015 22:52, Wayne Stambaugh wrote: > I asked Simon if he could figure out how to make it less noisy. I > haven't heard back from him yet. >>> CMake Warning (dev) at utils/idftools/CMakeLists.txt:17 (add_executable): >>> Policy CMP0063 is not set: Honor visibility properties for a

Re: [Kicad-developers] [PATCH 2/4] Use CMake function for position independent code

2015-12-10 Thread Simon Richter
Hi, > - set( BOOST_CFLAGS "cflags=${PIC_FLAG}" ) > - set( BOOST_CXXFLAGS "cxxflags=${PIC_FLAG}" ) > because cmake will only set -fpic in CFLAGS but the entire cmake file > uses BOOST_CFLAGS and never passes the plain CFLAGS The Boost build knows on its own that it needs -fPIC -- except if you li

[Kicad-developers] On pin/unit swapping

2015-12-10 Thread Simon Richter
Hi, I'm thinking about adding some support for pin and unit swapping. To make it maximally useful, I'd like to generate a list of alternative mappings inside the netlist, and add the actual swap functionality inside pcbnew -- so if it turns out that the layout becomes easier if two pins are swappe

Re: [Kicad-developers] On pin/unit swapping

2015-12-11 Thread Simon Richter
Hi Wayne, On 11.12.2015 20:23, Wayne Stambaugh wrote: > Not until after the new schematic and symbol library file formats are > implemented. Support for pin and unit swapping will be built in to the > new symbol library file format. That would be fairly orthogonal to what I'm suggesting -- I'd

Re: [Kicad-developers] [PATCH 4/4] Drop gcc optimizer bug workaround

2015-12-14 Thread Simon Richter
Hi, Am 14.12.2015 um 16:01 schrieb Mark Roszko: > Stupid question, doesn't this change remove -O2 entirely for all gcc > builds? Previously it defaulted to -O2 if the bug wasn't present. Now > it never optimizes as -O0 is the default. The default depends on the build type -- if your source tree

Re: [Kicad-developers] FOSDEM 2016

2015-12-18 Thread Simon Richter
Hi, > Just a quick heads up. I just made my travel arrangements for FOSDEM > 2016. That always makes it feel official to me. Please try to attend > if you can manage it. I would like to meet as many of the KiCad > developers as possible. I can tell you that EDA dev room dinner > Saturday even

Re: [Kicad-developers] [rfc] actual sexpression parsing

2015-12-20 Thread Simon Richter
Hi, On 21.12.2015 08:35, Lorenzo Marcantonio wrote: > After this I'm *not* advocating a binary format, there would be no > advantage for it in pcbnew. There are no performance restraints in > either speed or space for kicad files so just use whatever is easier for > you to manage (i.e. structured

[Kicad-developers] [PATCH 5/5] Compress consecutive numbers in pin summary.

2015-12-27 Thread Simon Richter
For pin numbers ending in digits, consecutive numbers are collapsed to ranges for a better overview. --- eeschema/pin_number.cpp | 49 +++-- 1 file changed, 39 insertions(+), 10 deletions(-) diff --git a/eeschema/pin_number.cpp b/eeschema/pin_number.cp

[Kicad-developers] [PATCH 0/5] Pin summary for pin table

2015-12-27 Thread Simon Richter
Hi, this patch set implements a summary line for the pin table, listing the currently defined pins, to quickly check whether any pins have been forgotten. If pins 1,2,3,4,5,6,8,9,10,11,12 are defined, the status bar then reads "1-6,8-12". Simon Simon Richter (5): Split off

[Kicad-developers] [PATCH 1/5] Split off pin number comparison

2015-12-27 Thread Simon Richter
s = PinNumbers::Compare( str1, str2 ); if( res == 0 ) res = ( aItem1.GetID() < aItem2.GetID() ) ? -1 : 1; diff --git a/eeschema/pin_number.cpp b/eeschema/pin_number.cpp new file mode 100644 index 000..9f5f9ea --- /dev/null +++ b/eeschema/pin_number.cpp @@ -0,0 +1,134 @@ +/* + *

[Kicad-developers] [PATCH 4/5] Add pin number summary

2015-12-27 Thread Simon Richter
Below the pin table, display which pins are currently defined, in order to find gaps. --- eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 27 +++ eeschema/dialogs/dialog_lib_edit_pin_table.h | 2 + .../dialogs/dialog_lib_edit_pin_table_base.cpp | 3 + .../dialogs/dialog_lib_e

[Kicad-developers] [PATCH 2/5] Move comparison helper class to generic header

2015-12-27 Thread Simon Richter
This class wraps the comparison function in a way that is compatible with std::map and std::set. This, too is generally useful, so it should be moved to the generic header. At the same time, the criterium for less-than is changed from "equal to -1" to "smaller than 0", because technically the com

[Kicad-developers] [PATCH 3/5] Move container functionality

2015-12-27 Thread Simon Richter
The "set of pin numbers" functionality is also useful outside the pin table dialog, so create a wrapper class that exposes the relevant interfaces. --- eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 2 +- eeschema/pin_number.h | 21 + 2 files change

[Kicad-developers] [PATCH] Remove remaining references to KICAD_SKIP_BOOST

2016-01-03 Thread Simon Richter
Hi, this removes two leftover references to KICAD_SKIP_BOOST. Simon --- CMakeModules/download_avhttp.cmake | 9 + Documentation/development/compiling.md | 8 2 files changed, 1 insertion(+), 16 deletions(-) diff --git a/CMakeModules/download_avhttp.cmake b/CMakeModules/

Re: [Kicad-developers] [PATCH] Remove remaining references to KICAD_SKIP_BOOST

2016-01-03 Thread Simon Richter
Hi Wayne, On 04.01.2016 00:50, Wayne Stambaugh wrote: > I forgot to delete download_avhttp.cmake and the avhttp source zip file > so this patch wont be necessary. There is still a paragraph on KICAD_SKIP_BOOST in the documentation. Simon signature.asc Description: OpenPGP digital signatu

Re: [Kicad-developers] Changing the CMAKE_BUILD_TYPE flag

2016-01-04 Thread Simon Richter
Hi, On 04.01.2016 04:50, Jon Neal wrote: > Is there any chance that the CMAKE_BUILD_TYPE flag could be changed from > Product to Debug by default? It is the only flag I have to include when > I run cmake now and I often forget to set it. The goal is to make it easy for the people who want to ins

[Kicad-developers] [PATCH] portability: synchronize FindwxWidgets.cmake with CMake project

2016-01-12 Thread Simon Richter
Hi, this brings our copy of FindwxWidgets.cmake in sync with the version in the CMake repository. Since last September, CMake includes our changes (version check, wx 3.1, support for webview component), and these have been released with CMake 3.4. The change to drop the -isystem special handling

[Kicad-developers] [PATCH 0/2] Two small pin table improvements

2016-01-12 Thread Simon Richter
Hi, these are two small pin table improvements: a direct string access avoiding the wxVariant wrapping/unwrapping for internal functions (major speedup in sorting), and a way to undo the grouping in the pin table in order to get a flat table. Simon Simon Richter (2): pin table: Add

[Kicad-developers] [PATCH 2/2] pin table: Support flat table

2016-01-12 Thread Simon Richter
--- eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/eeschema/dialogs/dialog_lib_edit_pin_table.cpp b/eeschema/dialogs/dialog_lib_edit_pin_table.cpp index 63d8226..52c399f 100644 --- a/eeschema/dialogs/dialog_lib_edit_pin_tabl

[Kicad-developers] [PATCH 1/2] pin table: Add GetString() to retrieve string value for column

2016-01-12 Thread Simon Richter
This is in anticipation of the introduction of icons -- retrieving all the icons and throwing them away during sorting takes ages. --- eeschema/dialogs/dialog_lib_edit_pin_table.cpp | 88 ++ 1 file changed, 47 insertions(+), 41 deletions(-) diff --git a/eeschema/dialogs/d

Re: [Kicad-developers] [PATCH 0/2] Two small pin table improvements

2016-01-13 Thread Simon Richter
Hi Nick, Am 13.01.2016 um 09:03 schrieb Nick Østergaard: > There is no attached patch. Yes, if there are multiple patches I occasionally write a cover letter marked [0/x] that contains the blurb that shouldn't go into the commit log -- so "git am" can import my commit messages directly. This is

Re: [Kicad-developers] [PATCH 1/2] pin table: Add GetString() to retrieve string value for column

2016-01-13 Thread Simon Richter
Hi Chris, Am 13.01.2016 um 02:23 schrieb Chris Pavlina: > This patch doesn't apply to the latest revision for me, at very least > the line numbers are off. Might have to rebase. Ah yes, that is on top of the other stack of patches I sent, where I split out the comparison function into a new fil

Re: [Kicad-developers] [PATCH 3/5] Move container functionality

2016-01-13 Thread Simon Richter
Hi, On 13.01.2016 20:13, Chris Pavlina wrote: > Patch 4 has a small UI problem: with a lot of pins, the text field > listing defined pins overflows: https://misc.c4757p.com/overflow.png > Could you please correct this, perhaps by allowing the field to wrap, > before I apply the next two? A fif

Re: [Kicad-developers] GCC and C++14

2016-01-14 Thread Simon Richter
Hi, > No one suggested to choose C++14, it is still a draft AFIK, but just > that we probably need to set a standard, and we should probably > consider the feasibility of choosing C++11. I am sure a lot of > developers would like to see that happen, but we need a good accept > for that from the pr

[Kicad-developers] [PATCH] Separate ElectricPinType and TypeSheetLabel

2016-01-14 Thread Simon Richter
These enums are silently treated as equivalent in the ERC, because the values are casted to integers. This works for the most part, because the values are similar, but this is in no way enforced, and there is a small inconsistency (NET_UNSPECIFIED vs PIN_PASSIVE). This turns the storage into a di

Re: [Kicad-developers] GCC and C++14

2016-01-14 Thread Simon Richter
Hi, On 14.01.2016 16:51, Chris Pavlina wrote: > It seems Ubuntu is the only one left, and the new LTS is coming out soon. In addition, the current Ubuntu LTS is also lacking wxPython, so scripting does not work there. Simon signature.asc Description: OpenPGP digital signature ___

[Kicad-developers] [PATCH 1/2] Fix double class name

2016-01-14 Thread Simon Richter
Mostly cosmetic change, although there are compilers that choke on this. The C++ standard specifies that classes contain themselves as members, probably so they shadow any other definition of the same name for their own member functions, but there is really no reason why the class name should be

[Kicad-developers] [PATCH 2/2] Fix preprocessor logic

2016-01-14 Thread Simon Richter
The C++ preprocessor is actually not required to process "true" and "false" correctly. This works in C if is included, because these are then macros themselves, and resolved correctly, but C++ requires them to be keywords, so no such macros exist, and the preprocessor can treat both as undefined/

[Kicad-developers] [PATCH] Remove superfluous include in the middle of source file

2016-01-15 Thread Simon Richter
--- pcbnew/autorouter/rect_placement/rect_placement.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/pcbnew/autorouter/rect_placement/rect_placement.cpp b/pcbnew/autorouter/rect_placement/rect_placement.cpp index da53097..3c7f562 100644 --- a/pcbnew/autorouter/rect_placement/rect_placement.c

[Kicad-developers] [PATCH] Clean up truncation of constant

2016-01-15 Thread Simon Richter
In the autorouter code, the value 0x80 is assigned to MATRIX_CELL, which is an overflow for a signed 8-bit type. As this type is used as a bit mask, there is no point in having a sign bit anyway. --- pcbnew/autorouter/autorout.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Kicad-developers] [PATCH] Clean up truncation of constant

2016-01-15 Thread Simon Richter
In the autorouter code, the value 0x80 is assigned to MATRIX_CELL, which is an overflow for a signed 8-bit type. As this type is used as a bit mask, there is no point in having a sign bit anyway. --- pcbnew/autorouter/autorout.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/

[Kicad-developers] [PATCH 00/11] Portability series

2016-01-15 Thread Simon Richter
st constant integers, which the compiler is allowed to inline the same way as an enum, so this smells like a micro-optimization. Simon Simon Richter (11): Avoid comparing filepos with integers Drop some debug output Clarify atan2 overloads Avoid cast from const_iterator to iterator Corr

[Kicad-developers] [PATCH 01/11] Avoid comparing filepos with integers

2016-01-15 Thread Simon Richter
The filepos type is not necessarily an integer type, because it also needs to save the multibyte character state in case we're reading from a stream with shift states. The convention of using -1 as a special value is from Unix ftell(), and not portable. Instead, the stream's failbit needs to be e

[Kicad-developers] [PATCH 05/11] Correct import/export of KIFACE_GETTER.

2016-01-15 Thread Simon Richter
This function is passed through a DLL interface, so users need to be aware that they need to generate import stubs on Windows. Implicit generation of stubs for undefined functions is an extension of the GNU toolchain. --- include/kiway.h | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions

[Kicad-developers] [PATCH 03/11] Clarify atan2 overloads

2016-01-15 Thread Simon Richter
In the C++ standard, this function is only defined for floating point types, and integers cannot be implicitly converted. Using explicit conversions avoids a GCC specific extension to the standard library. --- common/trigo.cpp| 2 +- gerbview/gerbview_frame.cpp | 2 +-

[Kicad-developers] [PATCH 04/11] Avoid cast from const_iterator to iterator

2016-01-15 Thread Simon Richter
The standard library requires iterators passed to functions that modify the container to be mutable iterators, but GCC's implementation accepts const_iterator in some places where these are only used to mark a place, but the actual modification happens through a different parameter. As this break

[Kicad-developers] [PATCH 02/11] Drop some debug output

2016-01-15 Thread Simon Richter
This was apparently left in from debugging earlier, and should no longer be needed. Since it uses a GCC extension, it makes compilation on others fail. --- pcbnew/tools/pcbnew_control.cpp | 4 1 file changed, 4 deletions(-) diff --git a/pcbnew/tools/pcbnew_control.cpp b/pcbnew/tools/pcbnew_

[Kicad-developers] [PATCH 09/11] Use const int instead of anonymous enum type

2016-01-15 Thread Simon Richter
These values are used in a context where the implicit conversion to integer is necessary, but creates ambiguous template resolutions that MSVC 9 cannot resolve. As these constants are not actually an enumerated type, simply declaring them as static members avoids the problem. --- include/geometry

[Kicad-developers] [PATCH 07/11] Open namespace around definitions

2016-01-15 Thread Simon Richter
While defining functions in another namespace is technically allowed as long as the definition can be matched to a declaration, this can lead to ambiguous resolutions, such as here. --- pcbnew/ratsnest_viewitem.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pcbnew/rats

[Kicad-developers] [PATCH 11/11] Replace GCC-specific __func__ with portable __FUNCTION__

2016-01-15 Thread Simon Richter
This macro is GCC-specific and should be avoided in portable code. --- include/common.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/include/common.h b/include/common.h index b881444..5eeea09 100644 --- a/include/common.h +++ b/include/common.h @@ -98,6 +98,12 @@ enum pseudokeys { #

[Kicad-developers] [PATCH 10/11] Avoid conflicting declaration for Pgm()

2016-01-15 Thread Simon Richter
This function has two conflicting definitions in the "kicad" executable and the other wrapper programs. As the kifaces can be loaded from either, this silently assumes compatible data layout for the PGM_KICAD and PGM_BASE types when passed by reference, which is valid only when the compiler is awa

Re: [Kicad-developers] [PATCH 01/11] Avoid comparing filepos with integers

2016-01-15 Thread Simon Richter
Hi, On 16.01.2016 04:41, Simon Richter wrote: > The convention of using -1 as a special value is from Unix ftell(), and not > portable. Instead, the stream's failbit needs to be examined after the call > to tellg(). Wait, that patch got damaged in a rebase apparently. The test s

[Kicad-developers] [PATCH 06/11] Add missing C++ stdlib headers

2016-01-15 Thread Simon Richter
The GCC standard library headers often include other headers as an implementation detail. As this is not guaranteed by the standard, it is non-portable. --- common/gal/graphics_abstraction_layer.cpp | 2 ++ common/grid_tricks.cpp | 2 ++ common/selcolor.cpp

[Kicad-developers] [PATCH 08/11] Use numeric_limits for NaN constant

2016-01-15 Thread Simon Richter
The NAN macro is not necessarily defined in math.h, so use std::numeric_limits to look up an appropriate value. --- common/gal/color4d.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/common/gal/color4d.cpp b/common/gal/color4d.cpp index 3b509d3..3a19dc5 100644 --- a/com

Re: [Kicad-developers] [PATCH 11/11] Replace GCC-specific __func__ with portable __FUNCTION__

2016-01-15 Thread Simon Richter
On 16.01.2016 04:41, Simon Richter wrote: > > This macro is GCC-specific and should be avoided in portable code. > --- > include/common.h | 6 ++ > 1 file changed, 6 insertions(+) > Meh, that shouldn't have been in the portability branch, but only the msvc branch.

[Kicad-developers] [PATCH v2] Avoid comparing filepos with integers

2016-01-15 Thread Simon Richter
The filepos type is not necessarily an integer type, because it also needs to save the multibyte character state in case we're reading from a stream with shift states. The convention of using -1 as a special value is from Unix ftell(), and not portable. Instead, the stream's failbit needs to be e

[Kicad-developers] [PATCH] Genericize Windows import/export

2016-01-15 Thread Simon Richter
Windows-style dllimport/dllexport should be used whenever targetting Windows directly, not just for MINGW. --- include/import_export.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/import_export.h b/include/import_export.h index c31729e..672709f 100644 --- a/include

Re: [Kicad-developers] [PATCH] Genericize Windows import/export

2016-01-16 Thread Simon Richter
Hi Wayne, On 16.01.2016 21:40, Wayne Stambaugh wrote: > Huh? > > +// MSVC doesn't have __func__ > +#ifdef _MSC_VER > +#define __func__ __FUNCTION__ > +#endif > + Yes, I wrote yesterday that this patch was included by accident and should be ignored. Simon signature.asc Description: OpenP

Re: [Kicad-developers] Request/Question

2016-01-16 Thread Simon Richter
Hi, On 16.01.2016 21:32, Wayne Stambaugh wrote: > I believe that if you truly wanted to contribute > to KiCad, you would take a few minutes of time to learn bzr and > launchpad. git-remote-bzr works fine for me. Still haven't learned bzr. Simon signature.asc Description: OpenPGP digital s

Re: [Kicad-developers] Request/Question

2016-01-16 Thread Simon Richter
Hi Wayne, On 16.01.2016 22:05, Wayne Stambaugh wrote: >> git-remote-bzr works fine for me. Still haven't learned bzr. > How long did it take you to learn how to use this? I'll bet it was not > very long at all was it? Not really -- LP just appears as another remote server to me, and I can pull

Re: [Kicad-developers] [RFC PATCH] No more boost::context

2016-01-21 Thread Simon Richter
Hi, Am 21.01.2016 um 14:42 schrieb Tomasz Wlostowski: > I've tested the new context switching code on Linux, OSX (El Capitan) & > Windows (all OS 32-bit and 64-bit Intel). Supported compilers are GCC > and Clang. Wouldn't that kill all non-Intel platforms? IIRC there are a number of people runni

[Kicad-developers] [PATCH] Fix Windows resources.

2016-01-22 Thread Simon Richter
The resource setting for bitmap2component is too late in the CMakeLists.txt, and is being ignored, so bitmap2component does not have an icon resource on Windows. Moving the entire section helps. The other programs only have the mingw special case listed, not the generic declaration for the resour

Re: [Kicad-developers] [RFC PATCH] No more boost::context

2016-01-22 Thread Simon Richter
Hi Tom, On 21.01.2016 20:00, Tomasz Wlostowski wrote: > Currently Kicad supports only Intel-based platforms and the patch is > intended to make them build reliably. Well, in Debian we ship a few more[1]. > What happens if Boost devs > decide to change the ABI of the context library once again,

Re: [Kicad-developers] FOSDEM

2016-01-25 Thread Simon Richter
Hi Wayne, On 25.01.2016 01:46, Wayne Stambaugh wrote: > Just a heads up. I will be arriving in Brussels at 2:25PM local time > assuming my flights are on time. I should get to my hotel by no later > than 4PM. If any one else is getting in early enough on Friday and is > interested in grabbing

[Kicad-developers] [PATCH] Add CURL include dirs in github plugin

2016-01-27 Thread Simon Richter
The github plugin includes the CURL headers indirectly, so these headers need to be on the include search path. --- pcbnew/github/CMakeLists.txt | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pcbnew/github/CMakeLists.txt b/pcbnew/github/CMakeLists.txt index 780d1af..bb18428 100644 --- a/pc

Re: [Kicad-developers] KiCad Twitter

2016-02-06 Thread Simon Richter
Hi, Am 04.02.2016 um 23:07 schrieb Chris Gammell: > I was wondering if I could help out with the @kicad_pcb twitter account. > I keep an eye on all things KiCad on Tweetdeck and noticed that the > official twitter is rather dormant. Speaking of social media: I've created a "KiCad" Facebook page

Re: [Kicad-developers] Which wxFormBuilder?

2016-02-08 Thread Simon Richter
Hi, On 06.02.2016 20:01, Bernhard Stegmaier wrote: > I also tried in my Debian VM, but there seem to be no packages available… I have a few Debian packages of a 3.5 prerelease at http://www.simonrichter.eu/debian/ -- these are also what I use. Simon signature.asc Description: OpenPGP dig

Re: [Kicad-developers] KiCad PPA: version number for daily builds

2016-02-09 Thread Simon Richter
Hi, Am 09.02.2016 um 09:32 schrieb Jean-Samuel Reynaud: > As suggested by Wayne, is there any objection if version on daily build > PPA become 5.0-alpha-{repo version} or 4.99-alpha-{repo version} ? > It will allow daily build to have a higher version number than 4.0.XX > version available on dis

Re: [Kicad-developers] KiCad PPA: version number for daily builds

2016-02-09 Thread Simon Richter
Hi, Am 09.02.2016 um 10:15 schrieb Nick Østergaard: > I would personally prefer to include the VCS version in the version string. Hm, "+bzr12345" sorts before "+dfsg". But if someone fixes the licence for the two images (find_replace.svg and find.svg are CC-BY licenced, which is not DFSG free),

Re: [Kicad-developers] Discussion: Hidden Pins, Net labels

2016-02-11 Thread Simon Richter
Hi, On 09.02.2016 14:48, Wayne Stambaugh wrote: > Now that we've discussed this, we need to put together a task list that > can be added to the road map so they don't get lost in the noise. I > propose adding an ERC improvement section to the Eeschema section of the > version 5 road map. As of

Re: [Kicad-developers] Discussion: Hidden Pins, Net labels

2016-02-11 Thread Simon Richter
Hi, > On the other hand I would think you still need bypass capacitors on each > pin and therefore you still need to draw wires for those. I usually place these on a separate sheet anyway. For bypass caps, I'd like to have a way to map pins and capacitors to each other, which would change the ru

[Kicad-developers] [PATCH 00/19] FindwxWidgets.cmake updates

2016-02-13 Thread Simon Richter
ct in turn. Simon Simon Richter (19): FindwxWidgets.cmake: Remove arguments from else() and end*() FindwxWidgets.cmake: remove a few dbg_msg() invocations FindwxWidgets.cmake: Use uppercase for DBG_MSG macro FindwxWidgets.cmake: Show line number in debug output FindwxWidgets.cmake

[Kicad-developers] [PATCH 03/19] FindwxWidgets.cmake: Use uppercase for DBG_MSG macro

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 92 1 file changed, 46 insertions(+), 46 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index eed7166..99c07b6 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeMo

[Kicad-developers] [PATCH 09/19] FindwxWidgets.cmake: documentation for variables

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index a48a315..0e7eb7a 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -463,7 +

[Kicad-developers] [PATCH 10/19] FindwxWidgets.cmake: Expect directory layout for MSVC 64 bit

2016-02-13 Thread Simon Richter
On 64 bit MSVC, the DLLs and import libraries are placed in a directory called vc_x64, to allow parallel installation of 32 and 64 bit wxWidgets. --- CMakeModules/FindwxWidgets.cmake | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidget

[Kicad-developers] [PATCH 12/19] FindwxWidgets.cmake: Improve regex for version number matches

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index eca3466..8c6c333 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -867,11

[Kicad-developers] [PATCH 07/19] FindwxWidgets.cmake: Fix indentation

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index d4b21d7..e2b46db 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -261,7 +261,7

[Kicad-developers] [PATCH 02/19] FindwxWidgets.cmake: remove a few dbg_msg() invocations

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 29 - 1 file changed, 4 insertions(+), 25 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 55e057d..eed7166 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/Findwx

[Kicad-developers] [PATCH 01/19] FindwxWidgets.cmake: Remove arguments from else() and end*()

2016-02-13 Thread Simon Richter
To reduce differences with upstream FindwxWidgets.cmake, use their style of ending blocks. --- CMakeModules/FindwxWidgets.cmake | 204 +++ 1 file changed, 101 insertions(+), 103 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWi

[Kicad-developers] [PATCH 13/19] FindwxWidgets.cmake: Determine version even when not asked to

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 8c6c333..2711ca7 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -857,7 +857,7

[Kicad-developers] [PATCH 11/19] FindwxWidgets.cmake: Simplify MATCHES

2016-02-13 Thread Simon Richter
Arbitrary characters at beginning and end of the line are implicitly allowed anyway --- CMakeModules/FindwxWidgets.cmake | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 8ac93f3..eca3466 100644 --- a

[Kicad-developers] [PATCH 08/19] FindwxWidgets.cmake: Look for versioned wx-config scripts

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index e2b46db..a48a315 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -707,7 +707,

[Kicad-developers] [PATCH 14/19] FindwxWidgets.cmake: Drop nonsensical assignment

2016-02-13 Thread Simon Richter
No idea where that came from, but it is almost certainly an error. --- CMakeModules/FindwxWidgets.cmake | 2 -- 1 file changed, 2 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 2711ca7..254621c 100644 --- a/CMakeModules/FindwxWidgets.cmake +++

[Kicad-developers] [PATCH 16/19] FindwxWidgets.cmake: Reformat documentation

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 147 ++- 1 file changed, 85 insertions(+), 62 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 7f57d8a..7d8007c 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeMo

[Kicad-developers] [PATCH 17/19] FindwxWidgets.cmake: Use ENV foo rather than ENV{foo}

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 7d8007c..f6ff9ab 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -445,12

[Kicad-developers] [PATCH 18/19] FindwxWidgets.cmake: Report failure of wx-config when looking for components

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 1 + 1 file changed, 1 insertion(+) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index f6ff9ab..31c9ae3 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -834,6 +834,7 @@ else()

[Kicad-developers] [PATCH 19/19] FindwxWidgets.cmake: Remove extra newline

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 1 - 1 file changed, 1 deletion(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 31c9ae3..cf6d450 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -902,7 +902,6 @@ if(wxWidgets_F

[Kicad-developers] [PATCH 06/19] FindwxWidgets.cmake: Use lowercase for CMake builtins

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 8c9471e..d4b21d7 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -561,7 +

[Kicad-developers] [PATCH 15/19] FindwxWidgets.cmake: Do not explicitly declare FOUND_VAR, unnecessary

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 1 - 1 file changed, 1 deletion(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 254621c..7f57d8a 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -897,7 +897,6 @@ DBG_MSG("wxWid

[Kicad-developers] [PATCH 04/19] FindwxWidgets.cmake: Show line number in debug output

2016-02-13 Thread Simon Richter
--- CMakeModules/FindwxWidgets.cmake | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/CMakeModules/FindwxWidgets.cmake b/CMakeModules/FindwxWidgets.cmake index 99c07b6..471996c 100644 --- a/CMakeModules/FindwxWidgets.cmake +++ b/CMakeModules/FindwxWidgets.cmake @@ -150,10

<    1   2   3   4   5   6   7   8   9   10   >