Since the outline is drawn as well, we need to draw the circle also if only
the outline touches the canvas.
---
common/gr_basic.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common/gr_basic.cpp b/common/gr_basic.cpp
index 13733d612..c142cf80f 100644
--- a/common/gr_basic
This is almost the same code, so these can be merged.
---
common/gr_basic.cpp | 42 --
1 file changed, 16 insertions(+), 26 deletions(-)
diff --git a/common/gr_basic.cpp b/common/gr_basic.cpp
index 7558ca70e..13733d612 100644
--- a/common/gr_basic.cpp
+++
Hi,
On 28.10.2017 02:09, Seth Hillbrand wrote:
> Quick ping on this. Master has moved on, so I've re-based the patch set
> to the current master, in case anyone is up for looking at it. I also
> split out the largest patch into a couple of logical blocks, in hopes of
> making it easier to revie
Hi Tom,
On 01.11.2017 23:58, Tomasz Wlostowski wrote:
> Here's a patch set [1] that refactors some internal PCBnew stuff (mostly
> GAL & tool framework related), focusing on testability. The goal is to
> be able to use the BOARD class, GAL view and tools without the
> GUI-related code for the pur
Hi,
On 02.11.2017 17:32, Clemens Koller wrote:
>> [1] http://kiwi.hogyros.de:8080/job/windows-kicad-msys2-patch/15/console
> from [1]:
> [...]
> 17:08:24 error: git apply: bad git-diff - inconsistent old filename on line
> 305
> 17:08:24 + RES=128
> 17:08:24 + echo ' Patch exit: 128'
> 17:
Hi,
On 02.11.2017 17:20, Simon Richter wrote:
> I've tried an msys2 build[1], and the qa project failed due to a missing
> config.h. Did you forget to check it in, or is there a dependency
> missing (I've built with -j40)?
FWIW, same error on Linux with -j8.
Sim
Hi Tom,
On 02.11.2017 18:16, Tomasz Wlostowski wrote:
> Thanks for testing. Could you try applying the attached patch?
Works if scripting is disabled. What is the sanest way to run all tests
(so this can be integrated into the nightly and patch builds)?
Simon
signature.asc
Description: Op
Hi Tom,
On 03.11.2017 09:57, Tomasz Wlostowski wrote:
> The goal of this patch is to limit the inclusion of boost headers, which
> cause a huge slowdown in compilation time.
Would it make sense to build a precompiled header will all of Boost and
wx that we use?
Simon
signature.asc
Descrip
Hi,
On 08.11.2017 08:02, Oliver Walters wrote:
> For v5 release, can the default library install path be set to a user
> directory rather than program directory that may require administrator
> rights?
On Windows, there is a provision in the MSI standard for installing
software for the user only
Hi,
there is a build error[1] on Windows:
cp: cannot create directory
'/c/Jenkins/workspace/windows-kicad-msys2/pkg/mingw-w64-x86_64-kicad-git/mingw64/share/doc/kicad/':
No such file or directory
I suspect that kicad-winbuilder needs to be adapted to the changes in
the installation handling from
Hi,
On 14.11.2017 17:37, Maciej Sumiński wrote:
> 1. https://code.launchpad.net/~orsonmmz/kicad/+git/kicad/+ref/libedit
Also known as
http://downloads.kicad-pcb.org/windows/testing/patched/kicad-patched-18-10de79260-x86_64.exe
Simon
signature.asc
Description: OpenPGP digital signature
__
Hi,
On 18.11.2017 21:35, Marco Ciampa wrote:
> the "Prefereces->3D shapes downloader" the "Back" and "Next" dialog
> window buttons are always untranslated...
Probably not trivial, because this uses a standard Wizard class from wx,
so this might need to be fixed inside wx. Which platform are you
Hi,
On 28.11.2017 19:30, Greg Smith wrote:
> I REALLY appreciate the windows nightly builds. It seems the last
> available is Nov 25. Any estimate when the next one might be available?
The code signing certificate expired, and we're scrambling to find a
replacement. We have unsigned packages in
Hi,
we don't seem to have a consistent convention on quoting in messages
shown to the user, and thus we have all three of
'%s'
"%s"
<%s>
in format strings when referring to names (files, nets, netclasses, …).
For the untranslated strings, I'd prefer either double or single quotes,
w
Hi Bernhard,
On 05.12.2017 14:02, Bernhard Stegmaier wrote:
> attached patch fixes initial sizing of “Fields” table columns of component
> table view.
Unrelated to your patch: does it make sense to perhaps share some of the
grouping code between this and the component pin table?
Simon
si
Hi,
On 05.12.2017 15:17, Wayne Stambaugh wrote:
> One less pop up window is a good thing. I like the status bar idea but
> unless you can get it done quickly I would prefer to make this part of
> version 6. We should be focusing on bug fixing for the stable 5 release.
If the status bar is part
Hi,
On 05.12.2017 17:30, Maciej Sumiński wrote:
> When you build a program, do you always go through its build manual or
> do you start with 'cmake .. && make'? I think there is no point
> enforcing an optional dependency. Another good solution would be to
> autodetect libngspice and enable the s
---
common/geometry/shape_poly_set.cpp | 4 ++--
qa/polygon_triangulation/test_polygon_triangulation.cpp | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/common/geometry/shape_poly_set.cpp b/common/geometry/shape_poly_set.cpp
index 7c0d2f38f..ff2ad874
Simon Richter (6):
Add missing include
Avoid nonstandard variable length array
Avoid initialization from non-constexpr
Avoid C-style array member init (illegal in C++)
Link pcb_test_window with /SUBSYSTEM:WINDOWS
Pass -DBOOST_TEST_DYN_LINK to all parts of test
common
In-class initializers for "static const" class members must be constexpr,
however std::string is only "static const" itself and cannot be used
without compiler extensions.
---
include/utf8.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/utf8.h b/include/utf8.h
ind
This is required for wx apps.
---
qa/pcb_test_window/CMakeLists.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qa/pcb_test_window/CMakeLists.txt b/qa/pcb_test_window/CMakeLists.txt
index c312ce62d..f3a83bc47 100644
--- a/qa/pcb_test_window/CMakeLists.txt
+++ b/qa/pcb_test
This is not part of the C++ language, and only supported in some compilers.
---
common/common_plotDXF_functions.cpp | 26 ++
eeschema/sch_line.cpp | 21 ++---
include/class_plotter.h | 1 -
3 files changed, 28 insertions(+), 20 de
---
eeschema/qa/CMakeLists.txt | 3 +++
eeschema/qa/test_module.cpp | 1 -
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/eeschema/qa/CMakeLists.txt b/eeschema/qa/CMakeLists.txt
index f11329f35..fb99b8613 100644
--- a/eeschema/qa/CMakeLists.txt
+++ b/eeschema/qa/CMakeLists.txt
@@ -
---
common/geometry/shape_poly_set.cpp | 1 +
1 file changed, 1 insertion(+)
diff --git a/common/geometry/shape_poly_set.cpp b/common/geometry/shape_poly_set.cpp
index c11cf047c..7c0d2f38f 100644
--- a/common/geometry/shape_poly_set.cpp
+++ b/common/geometry/shape_poly_set.cpp
@@ -33,6 +33,7 @@
Hi,
On 06.12.2017 11:12, Kristoffer Ödmark wrote:
> I do not see why anyone is even objecting to this? Where is the logic at
> having a default build that does not correspond to any of the official
> packages?!
That usually happens because the nightly builds enable all the
experimental features
Hi,
On 07.12.2017 19:08, Wayne Stambaugh wrote:
> Yes, that is exactly what I'm saying. it is possible kicad could have
> different feature sets depending on the availability of dependencies on
> the target platform. The kicad project has no control over this. If a
> platform doesn't have depe
Hi,
On 01.12.2017 04:44, Simon Richter wrote:
> This replaces all single and angle bracket quotes in UI messages with
> double quotes, for consistency.
Any opinions on this patch?
Simon
signature.asc
Description: OpenPGP digital sig
Hi Wayne,
On 12.12.2017 22:07, Wayne Stambaugh wrote:
> I replied that the patch did not apply cleanly. Did you not receive it?
No, didn't get that one.
> I am fine with the double quotes. I don't have time to dig through all
> of the places where it doesn't apply cleanly. If you rebase it,
Hi,
>> This replaces all single and angle bracket quotes in UI messages with
>> double quotes, for consistency.
>> Sorry to all translators.
> I merged your patch.
If anyone feels like helping the translators out here: there are a
number of translations that are now "fuzzy" because the original
---
common/page_layout/page_layout_reader.cpp | 2 +-
pcb_calculator/pcb_calculator_frame.cpp | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/common/page_layout/page_layout_reader.cpp b/common/page_layout/page_layout_reader.cpp
index c7ce07a22..c96a775b7 100644
--- a/commo
Hi,
we have quite a few strings that are pluralized with "(s)". IMO, that
looks ugly.
A few of them can be resolved by using
wxPLURAL( "%d item", "%d items", num )
to get the appropriate string. In the C locale, this resolves to
( ( num == 1 ) ? "%d item" : "%d items" )
while other la
Hi,
On 23.12.2017 21:00, Dominik B. wrote:
> it seems there are some issues with signing the windows nightly builds.
> At least for me windows warns me about an unknown publisher.
Yes, rules for code signing certificates have changed, and it is
difficult to get a cert that is usable for nightly
---
common/CMakeLists.txt | 150 +--
eeschema/CMakeLists.txt | 76 +++---
pcbnew/CMakeLists.txt | 164
3 files changed, 196 insertions(+), 194 deletions(-)
diff --git a/common/CMakeLists.
Hi,
On 18.01.2018 06:25, Lachlan Audas wrote:
> and getting the following undefined reference,
[...]
A few others have seen that, that is a bug in how libngspice was linked
(it was compiled against libfftw, but not linked against it).
Simon
signature.asc
Description: OpenPGP digital sign
Hi Augusto,
On 30.01.2018 16:01, Augusto Fraga Giachero wrote:
> I've been designing schematics with some stm32 parts using the standard
> Kicad libraries, and a lot of these microcontrollers has 10+ functions
> multiplexed in each I/O pin. In the standard library the symbols
> displays all possi
---
common/CMakeLists.txt | 5 -
1 file changed, 5 deletions(-)
diff --git a/common/CMakeLists.txt b/common/CMakeLists.txt
index c31178986..9a4c2300c 100644
--- a/common/CMakeLists.txt
+++ b/common/CMakeLists.txt
@@ -432,11 +432,6 @@ set( PCB_COMMON_SRCS
widgets/widget_net_selector.cpp
Hi Wayne,
On 23.02.2018 18:00, Wayne Stambaugh wrote:
> Are our nightly windows builds built with debugging information? I was
> just curious. The file sizes would indicate that they may be but given
> the current size of the libraries it's hard to tell.
Yes, the CMAKE_BUILD_TYPE is set to Rel
Hi Wayne,
On 23.02.2018 19:10, Wayne Stambaugh wrote:
> Thanks. I've never used a RelWithDebInfo build. What kind of debugging
> info would this give me if I ran it gdb? Would it be good enough for
> someone to do produce useful debugging information performing a
> backtrace on a segfault?
So
Hi,
On 25.02.2018 22:52, Andrey Kuznetsov wrote:
> The unchecked components in the image below cannot be checked.
Yes, these are no longer in the nightly installer, because they are
600MB compressed, and most nightly users maintain their libraries
themselves.
Simon
signature.asc
Descripti
901 - 939 of 939 matches
Mail list logo
