Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

Yes. Should be done now. -S On 2019-06-12 16:30, Seppe Stas wrote: Awesome, thanks. Could you release it for KiCAD 5 so I can use it for the upcoming KiCAD 5 to 6 migration? Seppe On Wed, 12 Jun 2019 at 13:43, Seth Hillbrand wrote: Hi Seppe- I gave it a quick run and looks good. I

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

Awesome, thanks. Could you release it for KiCAD 5 so I can use it for the upcoming KiCAD 5 to 6 migration? Seppe On Wed, 12 Jun 2019 at 13:43, Seth Hillbrand wrote: > Hi Seppe- > > I gave it a quick run and looks good. I pushed your patch with the > addition of @KICAD_VERSION_FULL@ to the

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

Hi Seppe- I gave it a quick run and looks good. I pushed your patch with the addition of @KICAD_VERSION_FULL@ to the CFBundleVersion extended version string. Thank you for your contribution to KiCad! -Seth On 2019-06-11 21:50, Adam Wolf wrote: I did not test it, but reading over it, it

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

I did not test it, but reading over it, it looks great. Thanks! Adam On Tue, Jun 11, 2019 at 1:41 PM Adam Wolf wrote: > > I will review today. > > Thanks for your help, Seppe! > > On Tue, Jun 11, 2019, 10:11 AM Wayne Stambaugh wrote: >> >> Seppe, >> >> Your patch looks good to me. Any MacOS

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

I will review today. Thanks for your help, Seppe! On Tue, Jun 11, 2019, 10:11 AM Wayne Stambaugh wrote: > Seppe, > > Your patch looks good to me. Any MacOS devs care to comment? > > Cheers, > > Wayne > > On 6/11/19 10:46 AM, Seppe Stas wrote: > > Hey Wayne > > > > I attached my patch

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

CMake is black magic to me. I wouldn’t know if this were the best thing since sliced bread or the return of the plague. ;) Cheers, Jeff. > On 11 Jun 2019, at 16:11, Wayne Stambaugh wrote: > > Seppe, > > Your patch looks good to me. Any MacOS devs care to comment? > > Cheers, > > Wayne >

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

Seppe, Your patch looks good to me. Any MacOS devs care to comment? Cheers, Wayne On 6/11/19 10:46 AM, Seppe Stas wrote: > Hey Wayne > > I attached my patch (generated with `git format-patch --attach > origin/master`) to my last email as > per 

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

Hey Wayne I attached my patch (generated with `git format-patch --attach origin/master`) to my last email as per http://www.kicad-pcb.org/contribute/developers/#_submitting_patches. I have a feeling Gmail might not like the mail headers in the patch. I created a new patch without the --attach

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

Seppe, I don't understand why your emails keep ending up on the moderated list but something strange is going on. I had to moderate this one as well. Please attach your patch (created using `git format-patch`) so it can be reviewed and commented on. Cheers, Wayne On 6/11/19 10:17 AM, Seppe

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

Hey I closed the merge request on Launchpad and re-attached the patch and before and after screenshots (the after being built from a dirty master branch) to this mail: Before: [image: Screenshot 2019-06-05 at 22.46.43.png] After: [image: Screenshot 2019-06-05 at 22.46.54.png] As you can see,

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

Hi Seppe- I see this e-mail. Perhaps it was a launchpad hiccup. I've added Adam to the code review at [1]. Would you mind re-sending the images to the list? Thanks- Seth [1] https://code.launchpad.net/~seppestas/kicad/+git/kicad/+merge/368644 On 2019-06-11 05:23, Seppe Stas wrote: Hey

Re: [Kicad-developers] [PATCH] Set KiCad version in MacOS apps

Hey I'm not sure if this email got ignored or if it got rejected by some mailing system, but it does not seem to show up in the mailing list archive . Maybe now it works? Seppe On Wed, Jun 5, 2019 at 10:55 PM Seppe Stas wrote: > Hey