Sylwester,
Please bear with us for a little, since the move to GitLab has been at the
foreground for the last few weeks the lead developers haven't had time to
sit down and review patches as often. Once we have completed the migration
to GitLab for the code repository, you can submit this as a
Hi,
Evan's patch was merged, but mine with code change for those sources is
not included in master currently. Can I kindly ask for update, is there
something wrong with my code?
https://drive.google.com/file/d/1x_YDsIw6FhgJFEsDgteEl5L5PGwSsCiz/view?usp=sharing
Best regards,
Sylwester
On
Hi Evan,
I think keeping the included project symbol library is the safest bet in
case the global library changes. We had to continually update demos in
the past so this is the path of least resistance.
Cheers,
Wayne
On 11/13/19 4:24 PM, Evan Shultz wrote:
> Hi Wayne,
>
> Thanks!
>
> Yes it
Hi Wayne,
Thanks!
Yes it is! It was merged in the GH PR I sent above, and is currently at
https://github.com/KiCad/kicad-symbols and mirrored at
http://kicad-pcb.org/libraries/download/ from the main KiCad website. So
you can merge to 5.1.
Would it be accepted if I updated the existing demo
Hi Evan,
I merged your patch into the master branch. Thank you for your
contribution to KiCad. Just out of curiosity, is the Simulation_SPICE
library shipped with the 5.1 build? If so, I can merger this demo into
the 5.1 branch. Users might find it useful to demo the sources provided
by this
Hi Even,
I was cleaning my inbox and I noticed I hadn't commented on your
request. If you have a demo project that utilizes the spice library
changes you made, I would be more than happy to include it in master.
Please send a patch with demo project and I will merge it after I've
tested it and
Hi,
Apologies for the slight tangent...
When I submitted symbols for all V and I sources supported by ngspice at
https://github.com/KiCad/kicad-symbols/pull/1473, I created a
simulation schematic to show off their output waveforms. Some of them can
use the source control features here. I thought
On 20/10/2019 20:53, Seth Hillbrand wrote:
On 2019-10-20 08:36, Sylwester Kocjan wrote:
Hi,
Here is a patch with three additional source models implemented: SFFM,
AM and Random.
I hope this looks ok, cause I had troubles with configuring
clang-format on Windows. If no, I can correct.
Best
On 2019-10-20 08:36, Sylwester Kocjan wrote:
Hi,
Here is a patch with three additional source models implemented: SFFM,
AM and Random.
I hope this looks ok, cause I had troubles with configuring
clang-format on Windows. If no, I can correct.
Best regards,
Sylwester
Hi,
Here is a patch with three additional source models implemented: SFFM,
AM and Random.
I hope this looks ok, cause I had troubles with configuring clang-format
on Windows. If no, I can correct.
Best regards,
Sylwester
From 5eb344844c7c246e973b312d0e4413afadbb8977 Mon Sep 17 00:00:00
10 matches
Mail list logo
