Sounds good, no problem.
Adam Wolf
On Jun 12, 2015 6:51 AM, Wayne Stambaugh stambau...@gmail.com wrote:
After the stable release, I am ripping out all of the old OSX cmake
build configuration code along with the dependency build code. This
should significantly simplify our cmake code.
After the stable release, I am ripping out all of the old OSX cmake
build configuration code along with the dependency build code. This
should significantly simplify our cmake code. Please don't make any
changes to the legacy OSX build configuration code.
On 6/11/2015 9:08 PM, Bernhard
Thanks Garth. I committed your patch in the product branch r5731.
Hopefully this will get the OSX users back up and running.
Cheers,
Wayne
On 6/11/2015 4:16 AM, Garth Corral wrote:
Looks like the OS X install is trying to copy the nonexistant cvpcb.app into
the main bundle, killing the
This fixes everything I know about. I'm using a build made with these changes.
Garth
On Jun 11, 2015, at 1:01 PM, Wayne Stambaugh stambau...@gmail.com wrote:
I've already fixed all of this in my branch. Does this resolve all of
the cvpcb osx app bundle issues? If so I will commit the
I just committed the changes. Lets see if this gets Adam's nightly OSX
builds back up. Please let me know if there are any other lingering
issues and I will commit them asap.
On 6/11/2015 4:38 PM, Garth Corral wrote:
This fixes everything I know about. I'm using a build made with these
osx_fixbundles.sh was the script that did the library bundling before I changed
it to using builtin CMake functions for it.
Maybe it is still referenced here and there in some old CMake code, but IMHO it
can just be deleted with every reference to it.
Regards,
Bernhard
On 11 Jun 2015, at
Ah, makes sense. Thanks, Bernhard.
Garth
On Jun 11, 2015, at 6:08 PM, Bernhard Stegmaier stegma...@sw-systems.de
wrote:
osx_fixbundles.sh was the script that did the library bundling before I
changed it to using builtin CMake functions for it.
Maybe it is still referenced here and
Sorry sometimes I respond with the wrong email address...
On Jun 11, 2015 8:33 PM, Adam Wolf adamww...@gmail.com wrote:
There is also other Mac packaging stuff from a few years ago that can be
removed safely. If no one objects. I can prepare a patch for those as well.
Adam Wolf
On Jun 11,
Looks like the OS X install is trying to copy the nonexistant cvpcb.app into
the main bundle, killing the build.
Patch attached
kicad_CMakeLists.txt.patch
Description: Binary data
smime.p7s
Description: S/MIME cryptographic signature
___
Yep. That should be removed too. I get to it as soon as possible. Any
other places that this might be lurking in the code?
On 6/11/2015 11:44 AM, Adam Wolf wrote:
Builds resumed on the build cluster.
I need to understand the bundling a bit more--for instance, should we
still be adding
Adam,
There is also this line (521) in CMakeList.txt:
add_custom_target( osx_fix_bundles ALL DEPENDS
cvpcb eeschema gerbview kicad pcbnew bitmap2component
pcb_calculator pl_editor)
I'm guessing cvpcb can be removed from the list.
Wayne
On 6/11/2015 11:44 AM, Adam Wolf wrote:
I bet it can be.
I will put checking that on the top of my KiCad list.
Adam Wolf
On Thu, Jun 11, 2015 at 12:42 PM, Wayne Stambaugh stambau...@gmail.com
wrote:
Adam,
There is also this line (521) in CMakeList.txt:
add_custom_target( osx_fix_bundles ALL DEPENDS
cvpcb eeschema
Thanks Adam. As soon as you let me know, I will commit the changes.
On 6/11/2015 1:48 PM, Adam Wolf wrote:
I bet it can be.
I will put checking that on the top of my KiCad list.
Adam Wolf
On Thu, Jun 11, 2015 at 12:42 PM, Wayne Stambaugh stambau...@gmail.com
I think that can go. Though it looks like there’s some code in osx_fixbundles.sh that ostensibly migrates kiface modules inside the bundle, that code looks out of date and inert. Perhaps Bernhard has some insight into what that’s supposed to be doing.There are a couple of other references to
I've already fixed all of this in my branch. Does this resolve all of
the cvpcb osx app bundle issues? If so I will commit the changes.
On 6/11/2015 3:24 PM, Garth Corral wrote:
I think that can go. Though it looks like there’s some code in
osx_fixbundles.sh that ostensibly migrates kiface
15 matches
Mail list logo
