[Kmymoney-devel] [Bug 274021] Transaction attachments

2012-10-21 Thread Vlad K
https://bugs.kde.org/show_bug.cgi?id=274021 Vlad K changed: What|Removed |Added CC||vlad@gmail.com --- Comment #2 from Vlad K --- I w

Re: [Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

2012-10-21 Thread Thomas Baumgart
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106846/#review20647 --- Just a few things I noticed while looking at the patch. I will

Re: [Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

2012-10-21 Thread Alessandro Russo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106846/ --- (Updated Oct. 21, 2012, 10:52 p.m.) Review request for KMymoney. Changes

Re: [Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

2012-10-21 Thread Fernando Vilas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106846/#review20638 --- kmymoney/mymoney/storage/mymoneydbdef.cpp

Re: [Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

2012-10-21 Thread Alessandro Russo
> On Oct. 17, 2012, 1:29 p.m., Thomas Baumgart wrote: > > kmymoney/mymoney/storage/mymoneystoragesql.cpp, line 647 > > > > > > Fernando can can answer here. > > Fernando Vilas wrote: > Yes, there should be an u

Re: [Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

2012-10-21 Thread Alessandro Russo
> On Oct. 17, 2012, 1:29 p.m., Thomas Baumgart wrote: > > kmymoney/mymoney/storage/mymoneystoragesql.cpp, line 647 > > > > > > Fernando can can answer here. > > Fernando Vilas wrote: > Yes, there should be an u

[Kmymoney-devel] [Bug 308732] CSV Plugin - End Line skip box improvement

2012-10-21 Thread allan
https://bugs.kde.org/show_bug.cgi?id=308732 allan changed: What|Removed |Added Status|NEW |RESOLVED Resolution|---

Re: [Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

2012-10-21 Thread Fernando Vilas
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106846/#review20635 --- The patch is improving. For the test cases, an easy way to star

Re: [Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

2012-10-21 Thread Fernando Vilas
> On Oct. 17, 2012, 1:29 p.m., Thomas Baumgart wrote: > > kmymoney/mymoney/storage/mymoneystoragesql.cpp, line 647 > > > > > > Fernando can can answer here. Yes, there should be an upgradeToV7() added. The table de

Re: [Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

2012-10-21 Thread Alessandro Russo
> On Oct. 21, 2012, 1:09 p.m., Allan Anderson wrote: > > Might it be an idea to add a reference in Bug 207761 to this review in case > > those with an interest are unaware of the developments? > > > > Sorry, my previous comment was not intended to be aimed at Alvaro. Done, thanks. - Alessand

Re: [Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

2012-10-21 Thread Alessandro Russo
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106846/ --- (Updated Oct. 21, 2012, 1:19 p.m.) Review request for KMymoney. Changes

Re: [Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

2012-10-21 Thread Allan Anderson
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106846/#review20629 --- Might it be an idea to add a reference in Bug 207761 to this re

Re: [Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

2012-10-21 Thread Allan Anderson
> On Oct. 21, 2012, 12:34 p.m., Alvaro Soliverez wrote: > > I will get to this, just not today as it's Mother's Day here. > > > > About the reports, it's similar to what happens with the order by Category. > > The way it's done now, the first category gets the transaction, so it's not > > much

Re: [Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

2012-10-21 Thread Alessandro Russo
> On Oct. 21, 2012, 12:34 p.m., Alvaro Soliverez wrote: > > I will get to this, just not today as it's Mother's Day here. > > > > About the reports, it's similar to what happens with the order by Category. > > The way it's done now, the first category gets the transaction, so it's not > > much

Re: [Kmymoney-devel] Review Request: Adding Tags to Kmymoney - first draft

2012-10-21 Thread Alvaro Soliverez
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/106846/#review20625 --- I will get to this, just not today as it's Mother's Day here.

[Kmymoney-devel] [Bug 296518] Crash after attempting to change the ledger sort order.

2012-10-21 Thread Jean-Pierre ROBERT
https://bugs.kde.org/show_bug.cgi?id=296518 --- Comment #1 from Jean-Pierre ROBERT --- Created attachment 74697 --> https://bugs.kde.org/attachment.cgi?id=74697&action=edit New crash information added by DrKonqi kmymoney (4.6.1) on KDE Platform 4.8.5 (4.8.5) using Qt 4.8.1 - What I was doing