Re: [Kmymoney-devel] Review Request: When KWallet is opened synchronously do it in a safe way.

2012-12-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107507/#review24007 --- This review has been submitted with commit b0fc54586ba21048fb3

Re: [Kmymoney-devel] Review Request: When KWallet is opened synchronously do it in a safe way.

2012-12-26 Thread Commit Hook
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107507/#review24006 --- This review has been submitted with commit 6c88ffd84de50af557c

Re: [Kmymoney-devel] Review Request: When KWallet is opened synchronously do it in a safe way.

2012-12-26 Thread Thomas Baumgart
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107507/#review24004 --- Ship it! Looks good to me. Maybe at a later time, we can move

Re: [Kmymoney-devel] Review Request: When KWallet is opened synchronously do it in a safe way.

2012-11-29 Thread Cristian Oneț
În ziua de Joi 29 Noi 2012, la 11:45:34, Martin Preuss a scris: > At least there should be room to implement that later, i.e. I believe > this should be located in a more generic class, so that other modules > can use the wallet consistently... I agree with you on that but since I couldn't find a

Re: [Kmymoney-devel] Review Request: When KWallet is opened synchronously do it in a safe way.

2012-11-29 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107507/ --- (Updated Nov. 29, 2012, 3:54 p.m.) Review request for KMymoney. Changes

Re: [Kmymoney-devel] Review Request: When KWallet is opened synchronously do it in a safe way.

2012-11-29 Thread Martin Preuss
Hi, the password stuff is inside the OFX plugin, because it is only used by the OFX plugin. But we do have another potential use for such a mechanism: German users might want to store their passwords for HBCI as well. At least there should be room to implement that later, i.e. I believe this shou

Re: [Kmymoney-devel] Review Request: When KWallet is opened synchronously do it in a safe way.

2012-11-28 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107507/ --- (Updated Nov. 28, 2012, 8:19 p.m.) Review request for KMymoney. Changes

[Kmymoney-devel] Review Request: When KWallet is opened synchronously do it in a safe way.

2012-11-28 Thread Cristian Oneț
--- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/107507/ --- Review request for KMymoney. Description --- KWallet API is pretty cu