Re: [Kmymoney-devel] Reviewboard workflow

2013-10-04 Thread mk-lists
Hi Cristian, actually, I want to suggest removing two lines from .reviewboardrc. While "GUESS_FIELDS = True" is nice for creating a new review it ALSO affects the updating of reviews!! In my case it overwrites the already existing description, which I don't want to see changed every time I upda

Re: [Kmymoney-devel] Reviewboard workflow

2013-09-29 Thread Cristian Oneț
În ziua de Dum 29 Sep 2013, la 14:45:04, Thomas Baumgart a scris: > What do we need to do when we want to update an existing review? I read > something about a '-r' option to post-review. Can you elaborate on this? According to the documentation [1] git post-review -r REVIEW_ID will update an ex

Re: [Kmymoney-devel] Reviewboard workflow

2013-09-29 Thread Thomas Baumgart
Hi, I just want to add my 0.02 of git knowledge inline below on Sunday 29 September 2013 Cristian Oneț wrote: > Hi, > > I would like to share the following workflow which makes posting review > request easier (I posted the full workflow considering that I work on > 'improve_something'): > >

[Kmymoney-devel] Reviewboard workflow

2013-09-29 Thread Cristian Oneț
Hi, I would like to share the following workflow which makes posting review request easier (I posted the full workflow considering that I work on 'improve_something'): 1. (master) $git up 2. (master) $git branch improve_something 3. git co improve_something 4. Change code/build/test 5. (improve

Re: [Kmymoney-devel] Reviewboard

2013-03-19 Thread aga
On Tue, 19 Mar 2013 21:33:12 +0100 Alvaro Soliverez wrote: > On Tue, Mar 19, 2013 at 9:04 PM, aga wrote: > > > I have a couple of Reviewboard requests that are outstanding - that > > is, in limbo rather than excellent: > > > > https://git.reviewboard.kde.org/r/107714/ from December 14th, > > >

Re: [Kmymoney-devel] Reviewboard

2013-03-19 Thread aga
On Tue, 19 Mar 2013 21:33:12 +0100 Alvaro Soliverez wrote: > On Tue, Mar 19, 2013 at 9:04 PM, aga wrote: > > > I have a couple of Reviewboard requests that are outstanding - that > > is, in limbo rather than excellent: > > > > https://git.reviewboard.kde.org/r/107714/ from December 14th, > > >

Re: [Kmymoney-devel] Reviewboard

2013-03-19 Thread Alvaro Soliverez
On Tue, Mar 19, 2013 at 9:04 PM, aga wrote: > I have a couple of Reviewboard requests that are outstanding - that is, > in limbo rather than excellent: > > https://git.reviewboard.kde.org/r/107714/ from December 14th, > This one has a Ship it! on it. Was there a last-minute problem? > https:/

[Kmymoney-devel] Reviewboard

2013-03-19 Thread aga
I have a couple of Reviewboard requests that are outstanding - that is, in limbo rather than excellent: https://git.reviewboard.kde.org/r/107714/ from December 14th, https://git.reviewboard.kde.org/r/109043/ from Feb 19th. In addition, I am getting close to submitting another request, for a CSV E

Re: [Kmymoney-devel] Reviewboard and Git

2011-11-15 Thread Alvaro Soliverez
On Tue, Nov 15, 2011 at 9:45 AM, Alvaro Soliverez wrote: > About the KMM group for Git Reviewboard, I've already requested it as part > of the git migration, and it's going to be done soon. > > The Git Reviewboard group has been created at our request. Regards, Alvaro

Re: [Kmymoney-devel] Reviewboard and Git

2011-11-15 Thread Cristian Oneț
2011/11/15 Allan : > On 15/11/11 11:58, Cristian Oneț wrote: >> >> 2011/11/15 Allan: >>> >>> On 15/11/11 00:20, Allan wrote: On 14/11/11 22:16, Cristian Oneț wrote: > > On Monday 14 November 2011 22:11:32 you wrote: >> >> Just finishing adding all the new files, etc. Then,

Re: [Kmymoney-devel] Reviewboard and Git

2011-11-15 Thread Alvaro Soliverez
Hello Allan, To create a patch, you can simply run: git format-patch -n <--- n is the number of commits you want to output as patches. So, if you want the last 3 commits in patch format, just run: git format-patch -3 About the KMM group for Git Reviewboard, I've already requested it as part

Re: [Kmymoney-devel] Reviewboard and Git

2011-11-15 Thread Allan
On 15/11/11 11:58, Cristian Oneț wrote: 2011/11/15 Allan: On 15/11/11 00:20, Allan wrote: On 14/11/11 22:16, Cristian Oneț wrote: On Monday 14 November 2011 22:11:32 you wrote: Just finishing adding all the new files, etc. Then, see where I'm up to in this new world. What am I to do with t

Re: [Kmymoney-devel] Reviewboard and Git

2011-11-15 Thread Cristian Oneț
2011/11/15 Allan : > On 15/11/11 00:20, Allan wrote: >> >> On 14/11/11 22:16, Cristian Oneț wrote: >>> >>> On Monday 14 November 2011 22:11:32 you wrote: Just finishing adding all the new files, etc. Then, see where I'm up to in this new world. What am I to do with the new patches? I

Re: [Kmymoney-devel] Reviewboard and Git

2011-11-15 Thread Allan
On 15/11/11 00:20, Allan wrote: On 14/11/11 22:16, Cristian Oneț wrote: On Monday 14 November 2011 22:11:32 you wrote: Just finishing adding all the new files, etc. Then, see where I'm up to in this new world. What am I to do with the new patches? Is it a case of resubmitting under git? You c

Re: [Kmymoney-devel] Reviewboard and Git

2011-11-14 Thread Allan
On 14/11/11 22:16, Cristian Oneț wrote: On Monday 14 November 2011 22:11:32 you wrote: Just finishing adding all the new files, etc. Then, see where I'm up to in this new world. What am I to do with the new patches? Is it a case of resubmitting under git? You can commit them to a local bran

Re: [Kmymoney-devel] Reviewboard and Git

2011-11-14 Thread Cristian Oneț
On Monday 14 November 2011 22:11:32 you wrote: > Just finishing adding all the new files, etc. Then, see where I'm up to > in this new world. What am I to do with the new patches? Is it a case > of resubmitting under git? You can commit them to a local branch in your repository and after testin

Re: [Kmymoney-devel] Reviewboard and Git

2011-11-14 Thread Allan
On 14/11/11 21:31, Cristian Oneț wrote: On Monday 14 November 2011 20:22:16 Allan wrote: I have a couple of outstanding items on Reviewboard, and am wondering about how to proceed? I totally forgot about the CSV plugin wizard style re-write. Sory about that. The Git Reviewboard doesn't seem

Re: [Kmymoney-devel] Reviewboard and Git

2011-11-14 Thread Allan
On 14/11/11 21:31, Cristian Oneț wrote: On Monday 14 November 2011 20:22:16 Allan wrote: I have a couple of outstanding items on Reviewboard, and am wondering about how to proceed? I totally forgot about the CSV plugin wizard style re-write. Sory about that. The Git Reviewboard doesn't seem

Re: [Kmymoney-devel] Reviewboard and Git

2011-11-14 Thread Cristian Oneț
On Monday 14 November 2011 20:22:16 Allan wrote: > I have a couple of outstanding items on Reviewboard, and am wondering > about how to proceed? I totally forgot about the CSV plugin wizard style re-write. Sory about that. > The Git Reviewboard doesn't seem to recognise > KMyMoney. Did you recre

[Kmymoney-devel] Reviewboard and Git

2011-11-14 Thread Allan
I have a couple of outstanding items on Reviewboard, and am wondering about how to proceed? The Git Reviewboard doesn't seem to recognise KMyMoney. ___ KMyMoney-devel mailing list KMyMoney-devel@kde.org https://mail.kde.org/mailman/listinfo/kmymoney-