Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-12-30 Thread Łukasz Wojniłowicz
> On Gru 25, 2016, 1:37 po południu, Łukasz Wojniłowicz wrote: > > After this change, CSV Importer plugin isn't displayed in File->Import > > menu, even after steps suggested in following post > > http://kmymoney-devel.kde.narkive.com/hSaamIlT/plugins-path-in-master-branch > > So please add maki

Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-12-29 Thread Christian David
> On Dez. 25, 2016, 1:37 nachm., Łukasz Wojniłowicz wrote: > > After this change, CSV Importer plugin isn't displayed in File->Import > > menu, even after steps suggested in following post > > http://kmymoney-devel.kde.narkive.com/hSaamIlT/plugins-path-in-master-branch > > So please add making t

Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-12-29 Thread aga
On Sun, 25 Dec 2016 12:37:54 - Łukasz Wojniłowicz wrote: > --- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/129393/#review101572 > -

Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-12-25 Thread Łukasz Wojniłowicz
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129393/#review101572 --- After this change, CSV Importer plugin isn't displayed in Fi

Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-11-26 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129393/ --- (Updated Nov. 26, 2016, 3:12 p.m.) Status -- This change has been ma

Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-11-18 Thread Christian David
> On Nov. 17, 2016, 9:09 a.m., Thomas Baumgart wrote: > > CMakeLists.txt, line 199 > > > > > > Where did this go? We need it for LIBOFX, don't we? Hi Thomas, I moved it into ```kmymoney/plugins/ofximport/CMakeL

Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-11-17 Thread Thomas Baumgart
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129393/#review100896 --- CMakeLists.txt

Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-11-14 Thread Marko Käning
> On Nov. 14, 2016, 7:17 a.m., Marko Käning wrote: > > Why do you migrate away from KService to something Qt'ish? > > Christian David wrote: > Because there is no use of KService for us. Also this is way simpler. The > new system is recommended by the Frameworks developers (if KService is n

Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-11-14 Thread Christian David
> On Nov. 14, 2016, 7:17 a.m., Marko Käning wrote: > > Why do you migrate away from KService to something Qt'ish? Because there is no use of KService for us. Also this is way simpler. The new system is recommended by the Frameworks developers (if KService is not needed). The on demand plugins

Re: Review Request 129393: Use Qt's plugin system instead of KService

2016-11-13 Thread Marko Käning
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129393/#review100826 --- Why do you migrate away from KService to something Qt'ish?

Review Request 129393: Use Qt's plugin system instead of KService

2016-11-13 Thread Christian David
--- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/129393/ --- Review request for KMymoney. Repository: kmymoney Description ---