[Koha-bugs] [Bug 25149] The Zebra language option for Greek should be 'el', not 'gr'

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25149 Andreas Roussos changed: What|Removed |Added Text to go in the||Please note that the

[Koha-bugs] [Bug 9525] group floating rules

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #100741|0 |1 is obsolete|

[Koha-bugs] [Bug 9525] group floating rules

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #32 from Emmi Takkinen --- Created attachment 103829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103829&action=edit Bug 9525: Schema changes - DO NOT PUSH -- You are receiving this mail because: You

[Koha-bugs] [Bug 9525] group floating rules

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #100742|0 |1 is obsolete|

[Koha-bugs] [Bug 9525] group floating rules

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #100743|0 |1 is obsolete|

[Koha-bugs] [Bug 9525] group floating rules

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are re

[Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Frédéric Demians changed: What|Removed |Added Status|NEW |In Discussion

[Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 Frédéric Demians changed: What|Removed |Added CC||fanny.mion-mou...@bulac.f

[Koha-bugs] [Bug 25107] Remove double passing of $server variable to maybe_add in C4::SIP::Sip::MsgType

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25107 Frédéric Demians changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are r

[Koha-bugs] [Bug 25107] Remove double passing of $server variable to maybe_add in C4::SIP::Sip::MsgType

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25107 Frédéric Demians changed: What|Removed |Added Attachment #102699|0 |1 is obsolete|

[Koha-bugs] [Bug 25292] L1 cache too long in Z3950 server (z3950-responder)

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25292 --- Comment #3 from Jonathan Druart --- Of course there will be a difference, but you will hit L2 (memcached) anyway. It won't be worst than other search (UI). I am not expecting a huge difference here but I have not compared. --

[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 --- Comment #9 from Jonathan Druart --- Owen that seems to fix the problem instead. But I am wondering why, for instance, it works for koha-tmpl/intranet-tmpl/prog/en/modules/plugins/plugins-home.tt We have other occurrences of ''

[Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Jonathan Druart changed: What|Removed |Added Status|Failed QA |ASSIGNED Assign

[Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #19 from Jonathan Druart --- Created attachment 103835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103835&action=edit Bug 17355: DBIC changes - boolean flag -- You are receiving this mail because:

[Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 Jonathan Druart changed: What|Removed |Added Attachment #66022|0 |1 is obsolete|

[Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #20 from Jonathan Druart --- Created attachment 103836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103836&action=edit Bug 17355: Override delete methods -- You are receiving this mail because: You

[Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #18 from Jonathan Druart --- Created attachment 103834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103834&action=edit Bug 17355: DBIC changes -- You are receiving this mail because: You are watchi

[Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #21 from Jonathan Druart --- Created attachment 103837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103837&action=edit Bug 17355: DB changes - set is_system for categories -- You are receiving this

[Koha-bugs] [Bug 17355] Authorised value categories cannot be deleted

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17355 --- Comment #22 from Jonathan Druart --- Created attachment 103838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103838&action=edit Bug 17355: Add the ability to remove authorised value categories This new patch

[Koha-bugs] [Bug 24201] Attach desk to intranet session

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Attachment #101883|0 |1 is obsolete|

[Koha-bugs] [Bug 24201] Attach desk to intranet session

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 --- Comment #36 from Nicolas Legrand --- Created attachment 103840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103840&action=edit Bug 24201: (follow-up) add desk choice with library choice You should be able to

[Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002 Frédéric Demians changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are r

[Koha-bugs] [Bug 25002] JS Includes should be wrapped with template comments

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25002 Frédéric Demians changed: What|Removed |Added Attachment #103374|0 |1 is obsolete|

[Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #79

[Koha-bugs] [Bug 25301] Category code is blank when renewing or editing expired/expiring patron

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25301 Jonathan Druart changed: What|Removed |Added Keywords||Academy C

[Koha-bugs] [Bug 25290] Permissions

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25290 --- Comment #2 from Ruth --- Thanks. I used the "IndependentBranches" system preference -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___

[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 --- Comment #10 from Owen Leonard --- (In reply to Jonathan Druart from comment #9) > We have other occurrences of ''. Should we not remove > them all, even if not problematic? I didn't deliberately exclude any instances, I simply m

[Koha-bugs] [Bug 25302] New: The indentations should be in accordance with the Coding guidelines.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Bug ID: 25302 Summary: The indentations should be in accordance with the Coding guidelines. Change sponsored?: --- Product: Koha Version: master Hardware: All

[Koha-bugs] [Bug 25302] The indentations should be in accordance with the Coding guidelines.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25302 Timothy Alexis Vass changed: What|Removed |Added Patch complexity|--- |Small patch

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Jonathan Druart changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #82 from Jonathan Druart --- Created attachment 103843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103843&action=edit Bug 22844: (QA follow-up) Add pref PatronQuickAddFields too Description slightl

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Jonathan Druart changed: What|Removed |Added Attachment #101617|0 |1 is obsolete|

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #85 from Jonathan Druart --- Created attachment 103846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103846&action=edit Bug 22844: Make the attribute mandatory when editing a patron Note: I am not co

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #86 from Jonathan Druart --- Created attachment 103847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103847&action=edit Bug 22844: (QA follow-up) Build items.json for UniqueItemFields Adding items.js

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #83 from Jonathan Druart --- Created attachment 103844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103844&action=edit Bug 22844: Add the new DB column borrower_attribute_types.mandatory Signed-off-

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #84 from Jonathan Druart --- Created attachment 103845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103845&action=edit Bug 22844: Add the new entry to the patron attr types form Will conflict with b

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #88 from Jonathan Druart --- Created attachment 103849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103849&action=edit Bug 22844: Add is_boolean flag for new 'mandatory' column Signed-off-by: Kyle M

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #87 from Jonathan Druart --- Created attachment 103848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103848&action=edit Bug 22844: DBIC Schema changes Signed-off-by: Kyle M Hall -- You are receivi

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #89 from Jonathan Druart --- Created attachment 103850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103850&action=edit Bug 22844: Make the patron's attribute mandatory at the OPAC Test plan: - Set 1

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #90 from Jonathan Druart --- Could this whole patch set be retested? The last patch should fix the OPAC behaviours (self-reg and modification) -- You are receiving this mail because: You are watching all bug changes. _

[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 --- Comment #5 from Tomás Cohen Arazi --- (In reply to Frédéric Demians from comment #4) > Coming back from bug 25297, I have a question: Is it necessary to explicitly > call: > > Koha::Objects->new->empty; > > When you assign a

[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 --- Comment #11 from Owen Leonard --- Created attachment 103851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103851&action=edit Bug 25282: (follow-up) More corrections This patch adds more corrections missed in

[Koha-bugs] [Bug 5161] Patron attributes clearing if duplicate warning

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161 Jonathan Druart changed: What|Removed |Added Keywords|rel_20_05_candidate,| |RM_pri

[Koha-bugs] [Bug 24201] Attach desk to intranet session

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24201 Nicolas Legrand changed: What|Removed |Added Status|Failed QA |In Discussion -- You are

[Koha-bugs] [Bug 20846] Suppressed Records Still Appear in Public Lists

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20846 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun

[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Passed QA -- You are rec

[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 Jonathan Druart changed: What|Removed |Added Attachment #103816|0 |1 is obsolete|

[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 --- Comment #13 from Jonathan Druart --- Created attachment 103853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103853&action=edit Bug 25282: (follow-up) More corrections This patch adds more corrections missed

[Koha-bugs] [Bug 25282] Menu for Action menubutton in dataTables like MARC frameworks page separated from the button

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25282 --- Comment #14 from Jonathan Druart --- From IRC: < Joubu> oleonard: there are 2 more .dropdown in opac-detail-sidebar.inc < oleonard> Joubu: I limited my search to the staff client since that's where the problematic combination

[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 --- Comment #6 from Tomás Cohen Arazi --- My conversation with one of the DBIx::Class authors: [17:56:51] weird question: if I know a query is going to return and empty resultset in advance, is there a way/helper to avoid performi

[Koha-bugs] [Bug 25030] IncludeSeeFromInSearches not honoured

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25030 --- Comment #2 from Tomás Cohen Arazi --- (In reply to Frédéric Demians from comment #1) > This is an very annoying regression when using ES. You're right to point the > facet building process. I don't think filtering facets is a goo

[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are re

[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 --- Comment #2 from Nick Clemens --- Created attachment 103854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103854&action=edit Bug 25273: Make match-heading rely on authority type configuration The match-heading

[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 Nick Clemens changed: What|Removed |Added Attachment #103801|0 |1 is obsolete|

[Koha-bugs] [Bug 25273] Elasticsearch Authority matching is returning too many results

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25273 Nick Clemens changed: What|Removed |Added CC||ere.maij...@helsinki.fi,

[Koha-bugs] [Bug 25303] New: Koha::Objects->delete should not skip overriden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Bug ID: 25303 Summary: Koha::Objects->delete should not skip overriden object class ->delete Change sponsored?: --- Product: Koha Version: unspecified Hardwar

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Summary|Koha::Objects->delete |Koha::Objects->delete

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store'

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #1 from Jonathan Druart --- Created attachment 103855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103855&action=edit Bug 25303: Make Koha::Objects->delete loop on the object set If we call Koha::Li

[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #1 from Martin Renvoize --- Created attachment 103856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103856&action=edit Bug 25261: Add system preference -- You are receiving this mail because: You are

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 --- Comment #2 from Martin Renvoize --- Created attachment 103857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103857&action=edit Bug 25261: Require confirmation of multiple parts items Test plan 1/ Catalogue an

[Koha-bugs] [Bug 25261] Multiple parts handling - confirmation alert

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25261 Martin Renvoize changed: What|Removed |Added Status|NEW |Needs Signoff -- You are

[Koha-bugs] [Bug 25288] Make the libraries list use the API

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25288 Tomás Cohen Arazi changed: What|Removed |Added See Also|https://bugs.koha-community | |.or

[Koha-bugs] [Bug 25287] Add columns_settings support to API datatables wrapper

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25287 Tomás Cohen Arazi changed: What|Removed |Added See Also|https://bugs.koha-community | |.or

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #91 from David Nind --- Just a couple of things from running through the testing again: 0) The mandatorty fields for self registration and editing worked for me! 1) The image attached to the bug shows the human readable

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #17 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #15) > > Why do you warn $_ ? > > Following prior art. It makes sense to warn like this for such errors. I > have however added a Koha::Logger based

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #18 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #17) > (In reply to Martin Renvoize from comment #15) > > > Why do you warn $_ ? > > > > Following prior art. It makes sense to warn like this for s

[Koha-bugs] [Bug 24631] Plugin metadata should be outside the main class

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24631 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #32

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #92 from Jonathan Druart --- (In reply to David Nind from comment #91) > Just a couple of things from running through the testing again: > > 0) The mandatorty fields for self registration and editing worked for me! The

[Koha-bugs] [Bug 25245] Add a plugin hook to allow running code on a nightly basis

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25245 --- Comment #19 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #18) > (In reply to Marcel de Rooy from comment #17) > > (In reply to Martin Renvoize from comment #15) > > > > Why do you warn $_ ? > > > > > > Fol

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #2 from Martin Renvoize --- This is more similar to bug 23185 than bug 21761. For performance reasons I'm not so sure about always forcing a loop rather than allowing a fast path.. I think I would rather see checks for t

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #6 from Martin Renvoize --- More and more I feel like this needs to be caught at the QA level.. whenever we see the 'store' method being changed/created in a Koha::Thing class we should warn the QA person via the qa scrip

[Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 --- Comment #93 from Jonathan Druart --- David, reading the last comments I noticed it may not be obvious: This patch set has been delayed because of the patron's attributes. In current master there is a hidden feature: you can ins

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 --- Comment #3 from Tomás Cohen Arazi --- It all comes down to the DB triggers discussion... I agree we could enforce people overriding Koha::Thing->delete to take care of implementing and overriden Koha::Things->delete that is confo

[Koha-bugs] [Bug 25189] Make AutoCreateAuthorities less of a footgun with LinkerModule: Default

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25189 --- Comment #3 from Nick Clemens --- Created attachment 103858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103858&action=edit Bug 25189: Unit tests -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Martin Renvoize changed: What|Removed |Added Attachment #103855|0 |1 is obsolete|

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #5

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Jonathan Druart changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Jonathan Druart changed: What|Removed |Added Blocks||23185 Referenced Bugs:

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Jonathan Druart changed: What|Removed |Added Depends on||25303 Referenced Bugs:

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #7 from Martin Renvoize --- Agreed with Jonathan that we should default Koha::Objects->update to loop through the resultset and call Koha::Object->store.. However, we should also allow for a direct_update option either b

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Jonathan Druart changed: What|Removed |Added Blocks||23070 Referenced Bugs:

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Jonathan Druart changed: What|Removed |Added Depends on||23185 Status|

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #8 from Marcel de Rooy --- Is adding direct_update not adding the side step that you wanted to catch ? -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. __

[Koha-bugs] [Bug 21472] Links in Additional Formats section of bib details do not work

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21472 Abbey Holt changed: What|Removed |Added CC||ah...@dubuque.lib.ia.us -- Yo

[Koha-bugs] [Bug 25303] Koha::Objects->delete should not skip overridden object class ->delete

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25303 Tomás Cohen Arazi changed: What|Removed |Added Version|unspecified |master QA Conta

[Koha-bugs] [Bug 20783] Cannot embed some YouTube videos due to 403 errors

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20783 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.co

[Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store'

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 --- Comment #9 from Martin Renvoize --- (In reply to Marcel de Rooy from comment #8) > Is adding direct_update not adding the sidestep that you wanted to catch ? It's making the side step very explicit.. there are certainly times wh

[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Martin Renvoize changed: What|Removed |Added Attachment #103811|0 |1 is obsolete|

[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Martin Renvoize changed: What|Removed |Added Attachment #103812|0 |1 is obsolete|

[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #9

[Koha-bugs] [Bug 25296] Add a way to force an empty Koha::Objects resultset

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25296 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate,

[Koha-bugs] [Bug 23070] Use Koha::Hold in C4::Reserves::RevertWaitingStatus

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23070 Martin Renvoize changed: What|Removed |Added Keywords||rel_20_05_candidate,

[Koha-bugs] [Bug 25293] Don't call escapeHtml on null

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25293 --- Comment #1 from didier --- Created attachment 103862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103862&action=edit Bug 25293: Don't call escapeHtml on null Test Plan: 1) Create two Checkouts 2) v

  1   2   3   >