[Koha-bugs] [Bug 29008] Warning when checking Koha version in plugins

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 Fridolin Somers changed: What|Removed |Added Summary|Avoid warning when checking |Warning when checking Koha

[Koha-bugs] [Bug 29008] Avoid warning when checking Koha version in plugins

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 Fridolin Somers changed: What|Removed |Added Summary|Avoid warning when checking |Avoid warning when checkin

[Koha-bugs] [Bug 28990] Allow changes for a configurable subset of systempreferences by superlibrarian only

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990 --- Comment #12 from Jonathan Druart --- Bug 28998 is introducing Koha::Encryption. I'd like to use it for sysprefs that shouldn't be stored in plain text (credentials in mind). -- You are receiving this mail because: You are the a

[Koha-bugs] [Bug 25790] [OMNIBUS] warnings removal

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790 Fridolin Somers changed: What|Removed |Added Depends on||29008 Referenced Bugs:

[Koha-bugs] [Bug 29008] Avoid warning when checking Koha plugin version

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 Fridolin Somers changed: What|Removed |Added Blocks||25790 Referenced Bugs:

[Koha-bugs] [Bug 29008] New: Avoid warning when checking Koha plugin version

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29008 Bug ID: 29008 Summary: Avoid warning when checking Koha plugin version Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Stat

[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Hayley Pelham changed: What|Removed |Added Attachment #124830|0 |1 is obsolete|

[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Hayley Pelham changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are rece

[Koha-bugs] [Bug 27432] Add report run to action logs

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #26 from David Cook --- (In reply to Fridolin Somers from comment #25) > We need a unit test. > Maybe in t/db_dependent/Log.t. > > Actually there are no test for other reports actions right ? That's what I was wondering

[Koha-bugs] [Bug 29000] Create a display of patrons with permissions

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000 --- Comment #5 from David Cook --- (In reply to Fridolin Somers from comment #4) > (In reply to David Cook from comment #3) > > I have it in the Tools module with the label "User Audit", but I suppose it > > should be in the "Patrons

[Koha-bugs] [Bug 28990] Allow changes for a configurable subset of systempreferences by superlibrarian only

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990 --- Comment #11 from David Cook --- (In reply to Fridolin Somers from comment #10) > In my opinion storing security settings inside database is not good. I think it's arguable about whether an Identity Provider counts as a security

[Koha-bugs] [Bug 29000] Create a display of patrons with permissions

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29000 --- Comment #4 from Fridolin Somers --- (In reply to David Cook from comment #3) > I have it in the Tools module with the label "User Audit", but I suppose it > should be in the "Patrons" module? Maybe next to "Patron lists" we could

[Koha-bugs] [Bug 27432] Add report run to action logs

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27432 --- Comment #25 from Fridolin Somers --- We need a unit test. Maybe in t/db_dependent/Log.t. Actually there are no test for other reports actions right ? -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #26 from Tomás Cohen Arazi --- (In reply to Fridolin Somers from comment #25) > (In reply to Marcel de Rooy from comment #24) > > (In reply to Joonas Kylmälä from comment #18) > > > > > This patch does not alter the mess

[Koha-bugs] [Bug 28990] Allow changes for a configurable subset of systempreferences by superlibrarian only

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28990 --- Comment #10 from Fridolin Somers --- In my opinion storing security settings inside database is not good. We often copy database from a production server to a test server, where security is on purpose lower. For me the best place

[Koha-bugs] [Bug 28959] virtualshelves.category is really a boolean

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28959 --- Comment #25 from Fridolin Somers --- (In reply to Marcel de Rooy from comment #24) > (In reply to Joonas Kylmälä from comment #18) > > > This patch does not alter the message we are giving out, we already say > > before this pat

[Koha-bugs] [Bug 28914] Wording in authentication forms is confusing

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28914 --- Comment #10 from Fridolin Somers --- Thanks for the info David :) I mean here : https://git.koha-community.org/Koha-community/Koha/src/commit/a5a3a330cfc7c7d6c35db13326745dabf8fe0df3/koha-tmpl/intranet-tmpl/prog/en/modules/auth.

[Koha-bugs] [Bug 27947] Add cancellation reasons to article requests

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #13 from Agustín Moyano --- Created attachment 124851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124851&action=edit Bug 27947: Add cancellation reason to article request This bug adds a cancellatio

[Koha-bugs] [Bug 27947] Add cancellation reasons to article requests

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 --- Comment #12 from Agustín Moyano --- Created attachment 124850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124850&action=edit Bug 27947: [DO NOT PUSH] update ArticleRequest schema -- You are receiving this

[Koha-bugs] [Bug 27947] Add cancellation reasons to article requests

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Agustín Moyano changed: What|Removed |Added Attachment #124063|0 |1 is obsolete|

[Koha-bugs] [Bug 27947] Add cancellation reasons to article requests

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27947 Agustín Moyano changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 28864] The patron search results in the Patron card creator doesn't seem to use PatronsPerPage syspref

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28864 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com ---

[Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 Lucas Gass changed: What|Removed |Added Attachment #124453|0 |1 is obsolete|

[Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivi

[Koha-bugs] [Bug 28937] Use Flatpickr on circulation and patron pages

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28937 Lucas Gass changed: What|Removed |Added Blocks||28942 Referenced Bugs: https

[Koha-bugs] [Bug 28942] Use Flatpickr on acquisitions pages

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28942 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com

[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #43 from Jonathan Druart --- Created attachment 124847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124847&action=edit Bug 28786: Add tests for checkauth -- You are receiving this mail because: You

[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #42 from Jonathan Druart --- Created attachment 124846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124846&action=edit Bug 28786: Correctly inherit from Auth::GoogleAuth -- You are receiving this ma

[Koha-bugs] [Bug 27887] Patrons should not receive overdue notices for claimed returns

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27887 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --- C

[Koha-bugs] [Bug 25825] Allow Claim Return function to be controlled by permissions

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25825 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us --- C

[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #41 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #34) > +package Koha::Auth::TwoFactorAuth; > +=head1 NAME > + > +Koha::Encryption - Koha class to encrypt or decrypt strings > > Hmm Oops, fixed! --

[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Jonathan Druart changed: What|Removed |Added Attachment #124771|0 |1 is obsolete|

[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 Jonathan Druart changed: What|Removed |Added Attachment #124770|0 |1 is obsolete|

[Koha-bugs] [Bug 26865] Double quotes in patron's data breaks patron searches

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26865 Rebecca Coert changed: What|Removed |Added CC||rco...@arlingtonva.us -- Y

[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #38 from Jonathan Druart --- Martin and Marcel, thank you for your interest in this patch set! As you noted, C4::Auth is not an easy place, and we all know that. It was hard to write code that followed the different "che

[Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 --- Comment #4 from David Nind --- > What options did you use to generate that error? I'm not able to reproduce > it. This was with and without selecting any date ranges, With koha-testing-docker (started with ku) it is using Ma

[Koha-bugs] [Bug 28940] IntranetUserJS is called twice on spinelable-print.tt

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #124415|0 |1 is obsolete

[Koha-bugs] [Bug 28940] IntranetUserJS is called twice on spinelable-print.tt

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28940 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You a

[Koha-bugs] [Bug 28977] Most-circulated items (cat_issues_top.pl) is failing with SQL Mode ONLY_FULL_GROUP_BY

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28977 Michael Hafen changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #

[Koha-bugs] [Bug 25534] Add ability to specifying and store a reason when cancelling a hold

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25534 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||29007 Referenced Bu

[Koha-bugs] [Bug 29007] New: Prompt for reason when cancelling waiting hold via popup

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29007 Bug ID: 29007 Summary: Prompt for reason when cancelling waiting hold via popup Change sponsored?: --- Product: Koha Version: master Hardware: All

[Koha-bugs] [Bug 28974] Add pagination to holds queue viewer

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28974 --- Comment #3 from Kyle M Hall --- (In reply to Katrin Fischer from comment #2) > Will it still be possible to print the whole queue over multiple pages? Yes, you can choose the number of results per page. -- You are receiving th

[Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 --- Comment #8 from Kyle M Hall --- Created attachment 124842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124842&action=edit Bug 28510: Remove unused variable -- You are receiving this mail because: You are wa

[Koha-bugs] [Bug 28510] Skip processing holds queue items from closed libraries when HoldsQueueSkipClosed is enabled

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28510 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiv

[Koha-bugs] [Bug 26635] Expand authorised values in REST API call

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26635 --- Comment #36 from Kyle M Hall --- Started an API Users Guide on the Wiki: https://wiki.koha-community.org/wiki/Koha_REST_API_Users_Guide -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect)

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Owen Leonard changed: What|Removed |Added Blocks||29006 Referenced Bugs: htt

[Koha-bugs] [Bug 29006] New: Make GoogleOpenIDConnect options consistent in the OPAC

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29006 Bug ID: 29006 Summary: Make GoogleOpenIDConnect options consistent in the OPAC Change sponsored?: --- Product: Koha Version: master Hardware: All

[Koha-bugs] [Bug 29005] New: Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29005 Bug ID: 29005 Summary: Add support for AutoEmailUser similar to AutoEmailOpacUser to patron imports Change sponsored?: --- Product: Koha Version: master Hardw

[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004 --- Comment #1 from Owen Leonard --- Created attachment 124841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124841&action=edit Bug 29004: Update GoogleOpenIDConnect preference to make it clear that it is OPAC-onl

[Koha-bugs] [Bug 29004] Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch comple

[Koha-bugs] [Bug 10988] Allow login via Google OAuth2 (OpenID Connect)

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10988 Owen Leonard changed: What|Removed |Added Blocks||29004 Referenced Bugs: htt

[Koha-bugs] [Bug 29004] New: Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29004 Bug ID: 29004 Summary: Update GoogleOpenIDConnect preference to make it clear that it is OPAC-only Change sponsored?: --- Product: Koha Version: master Hardwa

[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 20813] Revamp user permissions system

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #23 from Kyle M Hall --- (In reply to Fridolin Somers from comment #18) > This bug is now even more relevant for security reasons Given that, I've rebased this patch set. I haven't tested it at all yet. Please let me kno

[Koha-bugs] [Bug 20813] Revamp user permissions system

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #22 from Kyle M Hall --- Created attachment 124836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124836&action=edit Bug 20813: Remove deleted table -- You are receiving this mail because: You are wat

[Koha-bugs] [Bug 20813] Revamp user permissions system

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 --- Comment #21 from Kyle M Hall --- Created attachment 124835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124835&action=edit Bug 20813: Revamp user permissions system Koha's current user permissions system is

[Koha-bugs] [Bug 20813] Revamp user permissions system

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Kyle M Hall changed: What|Removed |Added Attachment #75542|0 |1 is obsolete|

[Koha-bugs] [Bug 20813] Revamp user permissions system

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Kyle M Hall changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are rec

[Koha-bugs] [Bug 20813] Revamp user permissions system

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Kyle M Hall changed: What|Removed |Added Severity|enhancement |normal -- You are receiving

[Koha-bugs] [Bug 20813] Revamp user permissions system

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Kyle M Hall changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com

[Koha-bugs] [Bug 29003] Apply different reasons via cancel_expired_holds cron based on found value

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29003 --- Comment #1 from Andrew Fuerste-Henry --- Actually, reiterating the importance of this a bit, if a library is using ExpireReservesMaxPickUpDelayCharge then an auto-cancelled waiting hold will result in a fee but an auto-cancelled

[Koha-bugs] [Bug 12656] Allow a CANCELLATION_REASON to be specified on the cancel_expired_holds.pl job

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Andrew Fuerste-Henry changed: What|Removed |Added Blocks||29003 Referenced Bu

[Koha-bugs] [Bug 29003] New: Apply different reasons via cancel_expired_holds cron based on found value

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29003 Bug ID: 29003 Summary: Apply different reasons via cancel_expired_holds cron based on found value Change sponsored?: --- Product: Koha Version: master Hardwar

[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com ---

[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #37 from Marcel de Rooy --- Not a complete QA, but at least some remarks: Nice development! Would like to see 2FA in Koha. There was discussion about moving the secret to another table. I tend to follow Tomas here. Two

[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 --- Comment #22 from Nick Clemens --- Created attachment 124831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124831&action=edit Bug 28847: Remove dead code and make regex consistent This updates the regex code t

[Koha-bugs] [Bug 28847] Branch limits while searching should be expanded in query building and not in CGI

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28847 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are recei

[Koha-bugs] [Bug 29002] Add ability to book items ahead of time

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Donna changed: What|Removed |Added CC||bwsdo...@gmail.com --- Comment #1 f

[Koha-bugs] [Bug 18148] Make list of lists in OPAC sortable

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18148 Owen Leonard changed: What|Removed |Added Assignee|oleon...@myacpl.org |koha-b...@lists.koha-commun

[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Owen Leonard changed: What|Removed |Added Attachment #124322|0 |1 is obsolete|

[Koha-bugs] [Bug 28934] Correct markup of GDPR consent in OPAC patron entry

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28934 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are re

[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 29002] Add ability to book items ahead of time

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 29002] Add ability to book items ahead of time

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Martin Renvoize changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 29002] New: Add ability to book items ahead of time

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 Bug ID: 29002 Summary: Add ability to book items ahead of time Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW

[Koha-bugs] [Bug 24718] Introduce hour-based holds

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24718 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #36 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #35) > Template process failed: undef error - The method Koha::Patron->auth_method > is not covered by tests! No DBIx schema change. -- You are recei

[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #35 from Marcel de Rooy --- Template process failed: undef error - The method Koha::Patron->auth_method is not covered by tests! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries REST endpoints

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948 --- Comment #15 from Marcel de Rooy --- (In reply to Tomás Cohen Arazi from comment #14) > And have AllowList just read the library's defined lists... I mean not > implementing a new AllowList class for each thing Bug 28999 centrali

[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #34 from Marcel de Rooy --- +package Koha::Auth::TwoFactorAuth; +=head1 NAME + +Koha::Encryption - Koha class to encrypt or decrypt strings Hmm -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 Martin Renvoize changed: What|Removed |Added Attachment #124746|0 |1 is obsolete|

[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #25 from Martin Renvoize --- My final patch is an alternative to Jonathans.. it tries to improve the feedback given to the end user by embedding the parameter that failed validation into the error code and then adding thi

[Koha-bugs] [Bug 28803] process_message_queue.pl dies if any messsages in the message queue contain an invalid to_address

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28803 --- Comment #24 from Martin Renvoize --- Created attachment 124829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124829&action=edit Bug 28803: (follow-up) Error details improvement This patch updates the exceptio

[Koha-bugs] [Bug 28948] Add a /public counterpart for the libraries REST endpoints

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28948 --- Comment #14 from Tomás Cohen Arazi --- Please, keep in mind that the API already has input/output validation, specified in the OpenAPI spec. That's why this dev was originally simple and only included a list of attributes for the

[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Marcel de Rooy changed: What|Removed |Added Status|In Discussion |Failed QA --- Comment #21

[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 --- Comment #20 from Marcel de Rooy --- So from this perspective looking at a new include, I see things like: [% IF item.isa('Koha::Item') %] .. [% IF NOT ( item.isa('Koha::Item') ) AND item.transfertwhen %] Which is awful. Yes, I

[Koha-bugs] [Bug 28762] Item status shows incorrectly on course-details.pl

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28762 Marcel de Rooy changed: What|Removed |Added Attachment #124744|0 |1 is obsolete|

[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 Marcel de Rooy changed: What|Removed |Added Status|NEW |ASSIGNED --- Comment #9 fr

[Koha-bugs] [Bug 28999] Add Koha::AllowList, DenyList and Koha::Object::ColumnSet

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28999 --- Comment #8 from Marcel de Rooy --- Created attachment 124828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124828&action=edit Bug 28999: {CONCEPT] Introduce Koha::Object::ColumnSet -- You are receiving this

[Koha-bugs] [Bug 9525] Add option to define float groups and rules for float

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Summary|group floating rules|Add option to define float

[Koha-bugs] [Bug 13995] Proper Exception handling

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13995 Emmi Takkinen changed: What|Removed |Added Blocks|9525| Referenced Bugs: https:/

[Koha-bugs] [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups.

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 Emmi Takkinen changed: What|Removed |Added Blocks|9525| Referenced Bugs: https:/

[Koha-bugs] [Bug 9525] group floating rules

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Depend

[Koha-bugs] [Bug 9525] group floating rules

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #44 from Emmi Takkinen --- Created attachment 124827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124827&action=edit Bug 9525: Add option to define float groups and rules for float Bug 22284 introduce

[Koha-bugs] [Bug 9525] group floating rules

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 --- Comment #43 from Emmi Takkinen --- Created attachment 124826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124826&action=edit Bug 9525: DO NOT PUSH! Schema update Sponsored-by: Koha-Suomi Oy -- You are recei

[Koha-bugs] [Bug 9525] group floating rules

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Attachment #40102|0 |1 is obsolete|

[Koha-bugs] [Bug 9525] group floating rules

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Assignee|olli-antti.kivila...@jns.fi |emmi.takki...@koha-suomi.fi

[Koha-bugs] [Bug 9525] group floating rules

2021-09-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9525 Emmi Takkinen changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #41 fro