https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523
--- Comment #25 from Martin Renvoize ---
I'm happy for this to progress without my final patch... but I would love to
see it moved to another bug for the next round of performance enhancements and
code cleaning.
I think the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29454
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Marcel de Rooy changed:
What|Removed |Added
Blocks||25790
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
Marcel de Rooy changed:
What|Removed |Added
Depends on||29684
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669
--- Comment #3 from Marcel de Rooy ---
Please correct English:
+die "Mandatory \$params->{xsl_syspref} does not provided, called with
biblionumber $params->{biblionumber}"
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688
Tomás Cohen Arazi changed:
What|Removed |Added
Keywords||rel_21_11_candidate
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 128463
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128463=edit
Bug 29688: Incorrect use of _() in holds.js
Bug 29404 moved code from request.tt into
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688
Tomás Cohen Arazi changed:
What|Removed |Added
Patch complexity|--- |Trivial patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29404
Tomás Cohen Arazi changed:
What|Removed |Added
Blocks||29688
Referenced
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688
Tomás Cohen Arazi changed:
What|Removed |Added
Depends on||29404
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29688
Bug ID: 29688
Summary: Incorrect use of _() in holds.js
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216
Jonathan Druart changed:
What|Removed |Added
Attachment #128424|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28216
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377
--- Comment #33 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #31)
> (In reply to Tomás Cohen Arazi from comment #29)
> > There was another occurence from prior patches (mine :-/) that gets
> > fixed as well.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128458|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377
--- Comment #31 from Jonathan Druart ---
(In reply to Tomás Cohen Arazi from comment #29)
> There was another occurence from prior patches (mine :-/) that gets
> fixed as well.
Should be on its own bug report if it's in stable.
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687
--- Comment #1 from Marcel de Rooy ---
Created attachment 128460
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128460=edit
Bug 29687: Uninitialized warning C4/XSLT line 286
From plack-opac-error.log:
[WARN] Use
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12561
Jonathan Druart changed:
What|Removed |Added
Blocks||29669
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29669
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687
Marcel de Rooy changed:
What|Removed |Added
Status|NEW |ASSIGNED
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687
Marcel de Rooy changed:
What|Removed |Added
Severity|enhancement |normal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687
Marcel de Rooy changed:
What|Removed |Added
Blocks||25790
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25790
Marcel de Rooy changed:
What|Removed |Added
Depends on||29687
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29687
Bug ID: 29687
Summary: Get rid of a few OPAC warnings
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377
--- Comment #30 from Tomás Cohen Arazi ---
(In reply to Fridolin Somers from comment #27)
> + alert(_("Your request could not be processed. Check the logs"));
> It is in holds.js, shouldn't it use __("foo") ?
Thanks for spotting
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040
Marcel de Rooy changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040
Marcel de Rooy changed:
What|Removed |Added
Attachment #128253|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29040
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377
--- Comment #29 from Tomás Cohen Arazi ---
Created attachment 128458
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128458=edit
Bug 28377: (QA follow-up) .js files should use __()
As noted by QA, this bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28377
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Failed QA |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686
Nick Clemens changed:
What|Removed |Added
Assignee|oleon...@myacpl.org |n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686
--- Comment #1 from Nick Clemens ---
Created attachment 128457
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128457=edit
Bug 29686: Adapt Koha to use new fulfillment API for OverDrive
This patch modifies the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686
Nick Clemens changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29686
Bug ID: 29686
Summary: Adapt OverDrive for new fulfillment API
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523
--- Comment #24 from Tomás Cohen Arazi ---
(In reply to Jonathan Druart from comment #23)
> Can you clarify the situation? What's missing to make it ready for a QA
> review? I like the idea but don't manage to see how far we are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685
Owen Leonard changed:
What|Removed |Added
Assignee|oleon...@myacpl.org |n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523
--- Comment #23 from Jonathan Druart ---
Can you clarify the situation? What's missing to make it ready for a QA review?
I like the idea but don't manage to see how far we are from something done.
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523
--- Comment #22 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #19)
> I have a question.. if you embed a plural on a route.. like 'patrons'..
> should the result be an array with 'null' gaps.. or an array that
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679
--- Comment #4 from Owen Leonard ---
Created attachment 128456
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128456=edit
Bug 29679: Remove redundant divider element from reports menu
The SQL report batch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679
Owen Leonard changed:
What|Removed |Added
Patch complexity|--- |Trivial patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29523
--- Comment #21 from Jonathan Druart ---
(In reply to Martin Renvoize from comment #18)
> Created attachment 128048 [details] [review]
> As an asside, I also update Koha::Patron->can_see_patrons_from to use
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679
Owen Leonard changed:
What|Removed |Added
Summary|Reports result menu shows |Reports result menu shows
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685
--- Comment #1 from Nick Clemens ---
Created attachment 128455
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128455=edit
Bug 29685: Reduce item processing by calculating 'items any available' outside
of loop
See
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685
Nick Clemens changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481
--- Comment #9 from Jonathan Druart ---
Created attachment 128454
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128454=edit
Bug 28481: (QA follow-up) Set date to 23:59:59
This patch changes the fix from adding a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481
Jonathan Druart changed:
What|Removed |Added
Attachment #128428|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28481
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29685
Bug ID: 29685
Summary: 'If all unavailable' state for 'on shelf holds' makes
holds page very slow if there's a lot of items on opac
Change sponsored?: ---
Product: Koha
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403
--- Comment #15 from Jonathan Druart ---
In my opinion we should not backport those patches.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403
--- Comment #14 from Jonathan Druart ---
Created attachment 128452
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128452=edit
Bug 29403: Fix api/v1/patrons.t
t::lib::Dates::compare expects either correct DateTime
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403
--- Comment #13 from Jonathan Druart ---
Created attachment 128451
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128451=edit
Bug 29403: Match the whole string
This patch wraps the constructed regex such that we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403
Jonathan Druart changed:
What|Removed |Added
Attachment #128272|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29403
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631
--- Comment #17 from Tomás Cohen Arazi ---
(In reply to Manos PETRIDIS from comment #16)
> Aren't language_descriptions.id and language_rfc4646_to_iso639.id already
> referenced anywhere in koha? Shouldn't there be some previous
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128358|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631
--- Comment #16 from Manos PETRIDIS ---
Aren't language_descriptions.id and language_rfc4646_to_iso639.id already
referenced anywhere in koha? Shouldn't there be some previous statements, where
use is determined (if any) and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28782
--- Comment #21 from Jonathan Druart ---
Joonas, do you think you will be back at this one soon?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28855
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27801
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587
--- Comment #23 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #22)
> (In reply to Fridolin Somers from comment #16)
> > Maybe we could prefer using Koha::Cache::Memory::Lite like in other places :
> >
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586
--- Comment #12 from Tomás Cohen Arazi ---
Good catch! Trivial fix, working as expected and QA scripts happy. We need a
script to catch those in the QA tools.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128124|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587
--- Comment #22 from Jonathan Druart ---
(In reply to Fridolin Somers from comment #16)
> Maybe we could prefer using Koha::Cache::Memory::Lite like in other places :
> https://git.koha-community.org/Koha-community/Koha/src/commit/
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128123|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587
--- Comment #21 from Jonathan Druart ---
Created attachment 128446
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128446=edit
Bug 26587: Use Koha::Cache::Memory::Lite
--
You are receiving this mail because:
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29586
Tomás Cohen Arazi changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
Tomás Cohen Arazi changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128313|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128314|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128239|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128158|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128157|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128156|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128155|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128154|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128153|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128152|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128114|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
Tomás Cohen Arazi changed:
What|Removed |Added
Attachment #128113|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
--- Comment #26 from Tomás Cohen Arazi ---
Ok. This is ready to go IMHO. The only missing bit is the updated DBIC files,
which make sense and should be done by the RM on pushing, so we are good.
New revisited test plan:
% git
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587
Jonathan Druart changed:
What|Removed |Added
Summary|detail.pl is very slow for |Cache libraries in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587
Jonathan Druart changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26587
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
--- Comment #25 from Tomás Cohen Arazi ---
(In reply to David Nind from comment #19)
> Created attachment 128314 [details]
> Bug 29605 - Error when accessing staff interface and OPAC
>
> I haven't signed off because when I try to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29684
Bug ID: 29684
Summary: Warning File not found: js/locale_data.js
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
--- Comment #24 from Tomás Cohen Arazi ---
After the upgrade:
- language_script_mapping.language_subtag is_nullable 0 vs 1
- __PACKAGE__->add_unique_constraint("uniq_code", ["rfc4646_subtag",
"iso639_2_code"]);
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662
--- Comment #3 from Jonathan Druart ---
This patch removes the code that dealt with that specific case, but it would be
good to know when this regression occurred.
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662
--- Comment #2 from Jonathan Druart ---
Created attachment 128436
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128436=edit
Bug 29662: (bug 27526 follow-up) Prefill all subfields if
SubfieldsToUseWhenPrefill is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662
Jonathan Druart changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
Jonathan Druart changed:
What|Removed |Added
Blocks||29662
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662
Jonathan Druart changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29662
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29679
Jonathan Druart changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29605
--- Comment #23 from Tomás Cohen Arazi ---
(In reply to Martin Renvoize from comment #22)
> I was slow to the game here.. adding to the ndiscussion on tiaga, I've used
> a few systems that take the approach Julian suggests and never
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631
--- Comment #15 from Tomás Cohen Arazi ---
I ran the original INSERTs (on the three tables) several times before running
the db_rev, and it made the original patch fail (of course).
My follow-up covers that.
It still feels we
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29631
--- Comment #14 from Tomás Cohen Arazi ---
Created attachment 128435
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=128435=edit
Bug 29631: (QA follow-up) Add missing cleanups
Signed-off-by: Tomas Cohen Arazi
--
101 - 200 of 222 matches
Mail list logo