[Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released

[Koha-bugs] [Bug 29820] Print summary just show 20 items

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 --- Comment #6 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29820] Print summary just show 20 items

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29820 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released

[Koha-bugs] [Bug 29812] C4::Context not included, but used in Koha::Token

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 --- Comment #3 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29812] C4::Context not included, but used in Koha::Token

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29812 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29758] CGI::param in list context in boraccount.pl warning

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29758 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 --- Comment #4 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29704] Holds reminder emails should allow configuration for a specific number of days

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29704 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order"

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 --- Comment #16 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order"

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released

[Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 --- Comment #5 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29498] Remove usage of deprecated Mojolicious::Routes::Route::detour

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29498 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released

[Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 --- Comment #51 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29474] Automatic renewals cronjob is slow on systems with large numbers of reserves

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29474 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released

[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 --- Comment #18 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29464] GET /acquisitions/orders doesn't honour sorting

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29464 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 --- Comment #31 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master

[Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 --- Comment #7 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs

[Koha-bugs] [Bug 18540] koha-indexdefs-to-zebra.xsl introduces MARC21 stuff into UNIMARC xslts

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18540 Fridolin Somers changed: What|Removed |Added Version(s)||22.05.00 released

[Koha-bugs] [Bug 29336] Some authorised_value FKs are too short

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29336 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 --- Comment #8 from David Cook --- I have wondered a bit about OpacSuppressionByIPRange with an API although I don't know how much that is used. We don't have stats on it on Hea due to the private nature of the values I think... --

[Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 --- Comment #7 from David Cook --- (In reply to Tomás Cohen Arazi from comment #6) > (In reply to Fridolin Somers from comment #2) > > For OpacHideItems, create a new report depending on Bug 24403 omnibus > > https://git.koha-commun

[Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 AspenCat Team changed: What|Removed |Added CC||aspencatt...@clicweb.org --

[Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 --- Comment #6 from Tomás Cohen Arazi --- (In reply to Fridolin Somers from comment #2) > For OpacHideItems, create a new report depending on Bug 24403 omnibus https://git.koha-community.org/Koha-community/Koha/src/branch/master/Koh

[Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 --- Comment #5 from David Cook --- (In reply to Fridolin Somers from comment #2) > For OpacHideItems, create a new report depending on Bug 24403 omnibus I don't think I have a report at the moment. I think Tomas has made progress o

[Koha-bugs] [Bug 29890] Unprivileged route to bib records needs check on OpacSuppression

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29890 --- Comment #4 from David Cook --- (In reply to Fridolin Somers from comment #3) > I hope our open-source ILS is mainly used for 100% open-data ;) Hahahaha -- You are receiving this mail because: You are the assignee for the bug.

[Koha-bugs] [Bug 14007] Item Types for items hidden by OpacHiddenItems turn up in facet results

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 --- Comment #13 from David Cook --- (In reply to Tomás Cohen Arazi from comment #6) > We should have separate indexes for OPAC and staff interface. > Probably public_* for the OPAC. We could need some trick for when > OpacHiddenItems

[Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Lucas Gass changed: What|Removed |Added Attachment #129497|0 |1 is obsolete|

[Koha-bugs] [Bug 17018] Split AdvancedSearchTypes for staff and OPAC

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17018 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivi

[Koha-bugs] [Bug 29066] Remove text in OPAC search form and use Font Awesome icons

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29066 --- Comment #9 from Lucas Gass --- I think the follow-up is correct, the aria-label belongs on the button. Now I think the the icon needs the aria-hidden="true" attribute. In fact the QA tool thinks so too: FAIL koha-tmpl/opac

[Koha-bugs] [Bug 29277] Replace the use of jQueryUI tabs on item circulation alerts page

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29277 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --

[Koha-bugs] [Bug 29226] OMNIBUS: Replace the use of jQueryUI tabs

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29226 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --

[Koha-bugs] [Bug 19532] Recalls for Koha

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #817 from Marcel de Rooy --- (In reply to Aleisha Amohia from comment #816) > I see. In the email chain we had discussed reformatting but clearly there > was some misunderstanding. > > I had started rewriting things befo

[Koha-bugs] [Bug 19532] Recalls for Koha

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 --- Comment #816 from Aleisha Amohia --- I see. In the email chain we had discussed reformatting but clearly there was some misunderstanding. I had started rewriting things before Christmas but it was proving to be very difficult to

[Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Andrew Fuerste-Henry changed: What|Removed |Added Text to go in the||This enhancement make

[Koha-bugs] [Bug 27868] Adding the Expiration Date to the Holds Awaiting Pickup report

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27868 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 29884] Missing test in api/v1/patrons.t

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29884 Bug 29884 depends on bug 28632, which changed state. Bug 28632 Summary: patrons.t fragile on slow boxes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 What|Removed |Added --

[Koha-bugs] [Bug 25551] [OMNIBUS] Some tests are failing randomly

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25551 Bug 25551 depends on bug 28632, which changed state. Bug 28632 Summary: patrons.t fragile on slow boxes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 What|Removed |Added --

[Koha-bugs] [Bug 28632] patrons.t fragile on slow boxes

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28632 Fridolin Somers changed: What|Removed |Added Resolution|--- |FIXED Status|

[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #44 from Fridolin Somers --- Thanks Martin and Jonathan I understand the keyword "additional_work_needed". UT is now OK : kohadev-koha@kohadevbox:/kohadevbox/koha$ prove t/db_dependent/TestBuilder.t t/db_dependent/TestB

[Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 --- Comment #4 from Fridolin Somers --- > Also add a space character between itemnumbers. I tested with 2 items impossible to delete and notices that itemnumbers do not have a separator. Very small fix so I made it will signing. BTW

[Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Fridolin Somers changed: What|Removed |Added Attachment #129588|0 |1 is obsolete|

[Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Fridolin Somers changed: What|Removed |Added Attachment #129019|0 |1 is obsolete|

[Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Fridolin Somers changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are re

[Koha-bugs] [Bug 29797] Background job detail for batch delete items not listing the itemnumbers

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29797 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Trivial patch

[Koha-bugs] [Bug 29609] Links to guess the biblio default view need to be centralized

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29609 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.c

[Koha-bugs] [Bug 29899] Show public note to patrons when placing a hold

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Lucas Gass changed: What|Removed |Added Attachment #129586|0 |1 is obsolete|

[Koha-bugs] [Bug 29899] Show public note to patrons when placing a hold

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Lucas Gass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receivi

[Koha-bugs] [Bug 29902] New: While upgrading all empty deleteditems.datelastborrowed turned deleteditems.timestamp to date of upgrade

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29902 Bug ID: 29902 Summary: While upgrading all empty deleteditems.datelastborrowed turned deleteditems.timestamp to date of upgrade Change sponsored?: --- Product:

[Koha-bugs] [Bug 29899] Show public note to patrons when placing a hold

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 --- Comment #1 from Owen Leonard --- Created attachment 129586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129586&action=edit Bug 29899: Show public note to patrons when placing a hold This patch adds public no

[Koha-bugs] [Bug 29899] Show public note to patrons when placing a hold

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff Patch comple

[Koha-bugs] [Bug 29899] Show public note to patrons when placing a hold

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Owen Leonard changed: What|Removed |Added Summary|Visibility of Public Note |Show public note to patrons

[Koha-bugs] [Bug 29899] Visibility of Public Note to Patrons when Placing a Hold

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Owen Leonard changed: What|Removed |Added Status|NEW |ASSIGNED Version|

[Koha-bugs] [Bug 29901] New: Editing purchase suggestions create a new suggestion

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29901 Bug ID: 29901 Summary: Editing purchase suggestions create a new suggestion Change sponsored?: --- Product: Koha Version: 20.05 Hardware: All OS: All

[Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order"

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 --- Comment #15 from Jonathan Druart --- Created attachment 129585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129585&action=edit Bug 29670: Fix EDI for AcqCreateItem = 'placing on order' The AcqCreatItem at or

[Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order"

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Jonathan Druart changed: What|Removed |Added Attachment #128419|0 |1 is obsolete|

[Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order"

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 Jonathan Druart changed: What|Removed |Added Status|Failed QA |Passed QA -- You are rec

[Koha-bugs] [Bug 29670] Restore functionality broken by bug 27708 for AcqCreateItem set to "placing an order"

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29670 --- Comment #13 from Jonathan Druart --- (In reply to Fridolin Somers from comment #12) > Ah QA tests fail for me : > FAIL t/db_dependent/Koha/Edifact/Order.t >FAIL spelling >segement ==> segment >

[Koha-bugs] [Bug 20502] Record URL broken, when there is more than one 856 on the record

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20502 --- Comment #19 from Jonathan Druart --- This is stuck, how do we move forward? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-b

[Koha-bugs] [Bug 29385] Add missing cash register support to SIP2

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 --- Comment #6 from Martin Renvoize --- Jonathan's patch is much better.. I've replaced my own and signed off. -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 29385] Add missing cash register support to SIP2

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Martin Renvoize changed: What|Removed |Added Attachment #128159|0 |1 is obsolete|

[Koha-bugs] [Bug 29385] Add missing cash register support to SIP2

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29385 Martin Renvoize changed: What|Removed |Added Attachment #127178|0 |1 is obsolete|

[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What|Removed |Added Attachment #129575|0 |1 is obsolete|

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Amanda Campbell changed: What|Removed |Added CC||acampb...@hmcpl.org -- Y

[Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #12 from Jonathan Druart --- I would rename ->qr_dataurl with ->qr_code as it actually generates an image. -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Jonathan Druart changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |jonathan.druart+koha@gmail

[Koha-bugs] [Bug 15565] Place multiple item-level holds at once for the same record

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15565 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 24857] Add ability to group items for records

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24857 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-communit

[Koha-bugs] [Bug 29900] New: API calls should update datelastseen for API patron

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29900 Bug ID: 29900 Summary: API calls should update datelastseen for API patron Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All

[Koha-bugs] [Bug 29899] Visibility of Public Note to Patrons when Placing a Hold

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Kelly McElligott changed: What|Removed |Added CC||and...@bywatersolutions.c

[Koha-bugs] [Bug 29899] New: Visibility of Public Note to Patrons when Placing a Hold

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29899 Bug ID: 29899 Summary: Visibility of Public Note to Patrons when Placing a Hold Change sponsored?: --- Product: Koha Version: unspecified Hardware: All

[Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #11 from Marcel de Rooy --- Created attachment 129581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129581&action=edit Bug 29873: Update cpanfile Signed-off-by: Marcel de Rooy -- You are receiving

[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 Martin Renvoize changed: What|Removed |Added Attachment #129547|0 |1 is obsolete|

[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #42 from Martin Renvoize --- Seems like a better approach to me :).. I wasn't close enough to TestBuilder to spot where I'd need to do that. Thanks Jonathan -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What|Removed |Added Blocks||29894 Referenced Bugs: h

[Koha-bugs] [Bug 29894] Trying to still improve Koha/Auth/TwoFactorAuth

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29894 Marcel de Rooy changed: What|Removed |Added Depends on||29873 Referenced Bugs: h

[Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What|Removed |Added Attachment #129578|0 |1 is obsolete|

[Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What|Removed |Added Attachment #129577|0 |1 is obsolete|

[Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #8 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #6) > Still looking at size of QR image (but it works). And impact on Selenium > test. t/db_dependent/selenium/authentication_2fa.t seems fine to me sti

[Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #7 from Marcel de Rooy --- Created attachment 129578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129578&action=edit Bug 29873: Adjust QR image size Size parameter 8 results in too big images. Size p

[Koha-bugs] [Bug 29877] MaxReserves should be enforced consistently between staff interface and API

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29877 Kyle M Hall changed: What|Removed |Added CC||k...@bywatersolutions.com ---

[Koha-bugs] [Bug 27741] Accessibility: Staff Client - Headings should have correct tags and hierarchy

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27741 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --

[Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #6 from Marcel de Rooy --- Still looking at size of QR image (but it works). And impact on Selenium test. -- You are receiving this mail because: You are watching all bug changes. ___

[Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 --- Comment #5 from Marcel de Rooy --- Created attachment 129577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129577&action=edit Bug 29873: Add unit test Test plan: Run t/db_dependent/Koha/Auth/TwoFactorAuth.t

[Koha-bugs] [Bug 29873] 2FA: Generate QR code without exposing secret via HTTP GET

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29873 Marcel de Rooy changed: What|Removed |Added Attachment #129402|0 |1 is obsolete|

[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #41 from Jonathan Druart --- Martin, this patch fixes the failure and don't modify the relation. It seems better to me. What do you think? -- You are receiving this mail because: You are watching all bug changes. __

[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #89 from Marcel de Rooy --- my $auth = Koha::Auth::TwoFactorAuth->new( { patron => $logged_in_user, secret => $secret } ); -my $secret32 = $auth->generate_secret32; my $qr_code_url = - $auth->

[Koha-bugs] [Bug 29495] Issue link is lost in return claims when using 'MarkLostItemsAsReturned'

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29495 --- Comment #40 from Jonathan Druart --- Created attachment 129575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129575&action=edit Bug 29495: Fix TestBuilder.t Value not allowed for auto_incr issue_id in Issue a

[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #88 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #86) > Passing > secret to the constructor is useless. Please look at the changes in my generate_secret32 patch. You need to pass the secret, but it i

[Koha-bugs] [Bug 29898] New: Overdues.pm line 663, Use of uninitialized value in string eq

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29898 Bug ID: 29898 Summary: Overdues.pm line 663, Use of uninitialized value in string eq Change sponsored?: --- Product: Koha Version: 20.11 Hardware: PC

[Koha-bugs] [Bug 28786] Two-factor authentication for staff client - TOTP

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28786 --- Comment #87 from Marcel de Rooy --- Yes, I replaced that patch. -my $secret32 = $auth->generate_secret32; +my $secret32 = encode_base32(Koha::AuthUtils::generate_salt("strong", 32)); Base32 encoding is done by the modul

[Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #129529|0 |1 is obsolete

[Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Andrew Fuerste-Henry changed: What|Removed |Added Attachment #129528|0 |1 is obsolete

[Koha-bugs] [Bug 29781] Allow item batch modification to use capturing groups in regex option

2022-01-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29781 Andrew Fuerste-Henry changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You a

  1   2   >